Re: [dpdk-dev] [PATCH v5 1/8] net/mvneta: add neta PMD skeleton

[Ferruh Yigit <ferruh.yigit@intel.com>]

On 9/24/2018 10:21 AM, Ferruh Yigit wrote:
> On 9/20/2018 10:05 AM, Andrzej Ostruszka wrote:
>> From: Zyta Szpak <zr@semihalf.com>
>>
>> Add neta pmd driver skeleton providing base for the further
>> development.
>>
>> Signed-off-by: Natalie Samsonov <nsamsono@marvell.com>
>> Signed-off-by: Yelena Krivosheev <yelena@marvell.com>
>> Signed-off-by: Dmitri Epshtein <dima@marvell.com>
>> Signed-off-by: Zyta Szpak <zr@semihalf.com>
>> Signed-off-by: Andrzej Ostruszka <amo@semihalf.com>
> 
> <...>
> 
>> @@ -0,0 +1,75 @@
>> +/* SPDX-License-Identifier: BSD-3-Clause
>> + * Copyright(c) 2018 Marvell International Ltd.
>> + * Copyright(c) 2018 Semihalf.
>> + * All rights reserved.
>> + */
>> +
>> +#ifndef _MVNETA_ETHDEV_H_
>> +#define _MVNETA_ETHDEV_H_
>> +
>> +/*
>> + * container_of is defined by both DPDK and MUSDK,
>> + * we'll declare only one version.
>> + *
>> + * Note that it is not used in this PMD anyway.
>> + */
>> +#ifdef container_of
>> +#undef container_of
>> +#endif
>> +
>> +#include <drivers/mv_neta.h>
>> +#include <drivers/mv_neta_ppio.h>
> 
> Can't find mv_neta.h in $(LIBMUSDK_PATH)/include [1]
> 
> There is a "mv_neta.h" in "./src/include/drivers/mv_neta.h" but not in the
> installed path.
> <musdk>/usr/local/include/drivers.
> 
> Is there a specific build param required for musdk for neta support?

I found it: --enable-bpool-dma=64 --enable-pp2=no --enable-neta,

But this means I need different musdk builds for mvpp2 and mvneta!
Can't it possible to use single musdk build for both libraries?

> 
> [1]
> .../drivers/net/mvneta/mvneta_ethdev.h:24:10: fatal error: 'drivers/mv_neta.h'
> file not found
> #include <drivers/mv_neta.h>
> 
>          ^~~~~~~~~~~~~~~~~~~
>