From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1A4ACA0C43; Thu, 21 Oct 2021 04:54:46 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9EB7940150; Thu, 21 Oct 2021 04:54:45 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 27D4340142 for ; Thu, 21 Oct 2021 04:54:43 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10143"; a="229201535" X-IronPort-AV: E=Sophos;i="5.87,168,1631602800"; d="scan'208";a="229201535" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Oct 2021 19:54:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,168,1631602800"; d="scan'208";a="463450951" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga002.jf.intel.com with ESMTP; 20 Oct 2021 19:54:40 -0700 Received: from shsmsx604.ccr.corp.intel.com (10.109.6.214) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 20 Oct 2021 19:54:40 -0700 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by SHSMSX604.ccr.corp.intel.com (10.109.6.214) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 21 Oct 2021 10:54:38 +0800 Received: from shsmsx601.ccr.corp.intel.com ([10.109.6.141]) by SHSMSX601.ccr.corp.intel.com ([10.109.6.141]) with mapi id 15.01.2242.012; Thu, 21 Oct 2021 10:54:38 +0800 From: "Zhang, Qi Z" To: "Wang, Haiyue" , Tudor Cornea CC: "Zhang, AlvinX" , "Yigit, Ferruh" , "dev@dpdk.org" Thread-Topic: [PATCH v2] net/ixgbe: initialize port even if mtu config fails Thread-Index: AQHXxd5JJVROGRvGc0qYXHS57n++JKvcIAiAgACiHqA= Date: Thu, 21 Oct 2021 02:54:38 +0000 Message-ID: References: <1634306769-20123-1-git-send-email-tudor.cornea@gmail.com> <1634753626-84056-1-git-send-email-tudor.cornea@gmail.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.200.16 dlp-product: dlpe-windows x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] net/ixgbe: initialize port even if mtu config fails X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Wang, Haiyue > Sent: Thursday, October 21, 2021 9:14 AM > To: Tudor Cornea ; Zhang, Qi Z > > Cc: Zhang, AlvinX ; Yigit, Ferruh > ; dev@dpdk.org > Subject: RE: [PATCH v2] net/ixgbe: initialize port even if mtu config fai= ls >=20 > > -----Original Message----- > > From: Tudor Cornea > > Sent: Thursday, October 21, 2021 02:14 > > To: Zhang, Qi Z > > Cc: Wang, Haiyue ; Zhang, AlvinX > > ; Yigit, Ferruh ; > > dev@dpdk.org; Tudor Cornea > > Subject: [PATCH v2] net/ixgbe: initialize port even if mtu config > > fails > > > > On a VMware ESXi 6.0 setup with an Intel 82599 NIC the ports don't > > seem to initialize anymore, while running testpmd. > > > > Configuring Port 0 (socket 0) > > ixgbevf_dev_rx_init(): Set max packet length to 1518 failed. > > ixgbevf_dev_start(): Unable to initialize RX hardware (-22) Fail to > > start port 0: Invalid argument Configuring Port 1 (socket 0) > > ixgbevf_dev_rx_init(): Set max packet length to 1518 failed. > > ixgbevf_dev_start(): Unable to initialize RX hardware (-22) Fail to > > start port 1: Invalid argument Please stop the ports first > > > > If the call to ixgbevf_rlpml_set_vf fails and we return prematurely, > > we will not be able to initialize the ports correctly. > > > > The behavior seems to have changed since the following commit: > > > > commit c77866a16904 ("net/ixgbe: detect failed VF MTU set") > > > > We can make this particular use case work correctly if we don't return > > an error, which seems to be consistent with the overall kernel ixgbevf > > implementation. > > > > [1] > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tre > > e/drivers/net/ethernet/intel/ixg > > bevf/ixgbevf_main.c#n2015 > > > > Signed-off-by: Tudor Cornea > > > > --- > > v2: > > * Change title > > * Remove max_rx_pkt_len fix in ixgbe_ethdev.c > > It's already fixed as part of Ferruh's changes in next-net branch, > > so this part should be redundant, now > > --- > > drivers/net/ixgbe/ixgbe_rxtx.c | 4 +--- > > 1 file changed, 1 insertion(+), 3 deletions(-) > > >=20 > Thanks! >=20 > Acked-by: Haiyue Wang Applied to dpdk-next-net-intel. Thanks Qi >=20 >=20 > > -- > > 2.7.4 >=20