From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 833A8A0521; Tue, 3 Nov 2020 13:11:39 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 643AAC96C; Tue, 3 Nov 2020 13:11:38 +0100 (CET) Received: from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191]) by dpdk.org (Postfix) with ESMTP id DEBCFC964 for ; Tue, 3 Nov 2020 13:11:35 +0100 (CET) Received: from DGGEMS413-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4CQTCh6K7yzLt6Q for ; Tue, 3 Nov 2020 20:11:28 +0800 (CST) Received: from [10.67.103.119] (10.67.103.119) by DGGEMS413-HUB.china.huawei.com (10.3.19.213) with Microsoft SMTP Server id 14.3.487.0; Tue, 3 Nov 2020 20:11:23 +0800 To: Ferruh Yigit CC: , References: <1604327899-60126-1-git-send-email-oulijun@huawei.com> <1604327899-60126-8-git-send-email-oulijun@huawei.com> <44cc36e0-c554-f717-953a-fe0d0ea259bc@intel.com> From: oulijun Message-ID: Date: Tue, 3 Nov 2020 20:11:23 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: <44cc36e0-c554-f717-953a-fe0d0ea259bc@intel.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.103.119] X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH 7/8] net/hns3: fix some static check errors by coverity X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 在 2020/11/3 19:41, Ferruh Yigit 写道: > On 11/2/2020 2:38 PM, Lijun Ou wrote: >> From: Hongbo Zheng >> >> This patch fixes some warnings. >> coverity:function format symbol does not match > > I think we are not getting these warnings in the public coverity, is > there a specific configuration for it? > Yes, the coverity scan is configured internally instead of the DPDK CI coverity warning. However, we think it is reasonable. >> >> coverity:not_unsigned: Violation: Operand >> "hw->hw_tc_map & (1UL << i)", Right Expression: >> "1UL << i" is not an unsigned type >> > > Can you please split this patch into multiple patches, one for each type > of issue? > >> Coverity issue: 91708127 >> Coverity issue: 89776953 > > I assume these are internal coverity ids, it has not much value to > record them in the commit log. > > We record the public coverity [1] ids with this tag. Hi, Ferruh The warning is our configuration. As a result, it has no public id.If the ID is not added, the check-git-log check fails. Do you have any good advice? Thanks Lijun Ou > > [1] > https://scan.coverity.com/projects/dpdk-data-plane-development-kit?tab=overview > > >> Fixes: 62e3ccc2b94c ("net/hns3: support flow control") >> Fixes: 19a3ca4c99cf ("net/hns3: add start/stop and configure operations") >> Fixes: a5475d61fa34 ("net/hns3: support VF") >> Fixes: fb94f359481f ("net/hns3: fix adding multicast MAC address") >> Fixes: fcba820d9b9e ("net/hns3: support flow director") >> Fixes: a951c1ed3ab5 ("net/hns3: support different numbers of Rx and Tx >> queues") >> Fixes: 2790c6464725 ("net/hns3: support device reset") >> Fixes: 23d4b61fee5d ("net/hns3: support multiple process") >> Fixes: bba636698316 ("net/hns3: support Rx/Tx and related operations") >> Fixes: e31f123db06b ("net/hns3: support NEON Tx") >> Fixes: 8839c5e202f3 ("net/hns3: support device stats") >> Cc: stable@dpdk.org >> >> Signed-off-by: Hongbo Zheng >> Signed-off-by: Lijun Ou > > <...> > > . >