From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id BA6BAA491 for ; Tue, 13 Mar 2018 15:46:37 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Mar 2018 07:46:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,465,1515484800"; d="scan'208";a="41583628" Received: from rhorton-mobl1.ger.corp.intel.com (HELO [163.33.230.232]) ([163.33.230.232]) by orsmga002.jf.intel.com with ESMTP; 13 Mar 2018 07:46:34 -0700 To: dev@dpdk.org References: <1520828243-25191-1-git-send-email-zijie.pan@6wind.com> <1520828243-25191-3-git-send-email-zijie.pan@6wind.com> Cc: Zijie Pan From: Remy Horton Organization: Intel Shannon Limited Message-ID: Date: Tue, 13 Mar 2018 14:46:34 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <1520828243-25191-3-git-send-email-zijie.pan@6wind.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 2/5] examples/ethtool: add a new command module-eeprom X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Mar 2018 14:46:39 -0000 Comments inline. On the whole looks good to me. On 12/03/2018 04:17, Zijie Pan wrote: [..] > Signed-off-by: Zijie Pan > --- > doc/guides/sample_app_ug/ethtool.rst | 2 ++ > examples/ethtool/ethtool-app/ethapp.c | 61 +++++++++++++++++++++++++++++++++ > examples/ethtool/lib/rte_ethtool.c | 30 ++++++++++++++++ > examples/ethtool/lib/rte_ethtool.h | 34 ++++++++++++++++++ > 4 files changed, 127 insertions(+) Reviewed-by: Remy Horton > cmdline_parse_token_string_t pcmd_eeprom_token_cmd = > TOKEN_STRING_INITIALIZER(struct pcmd_intstr_params, cmd, "eeprom"); > +cmdline_parse_token_string_t pcmd_module_eeprom_token_cmd = > + TOKEN_STRING_INITIALIZER(struct pcmd_intstr_params, cmd, "module-eeprom"); Checkpatch: 80 character limit. > + info_eeprom.len = module_info[1]; > + info_eeprom.offset = 0; > + stat = rte_ethtool_get_module_eeprom(params->port, > + &info_eeprom, bytes_eeprom); > + if (stat != 0 || module_info[1] <= 0) { This supposed to be module_info[1] rather than info_eeprom.len ?