From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id AC6481B73F for ; Thu, 10 Jan 2019 15:48:48 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 008ED12E51F; Thu, 10 Jan 2019 14:48:48 +0000 (UTC) Received: from [10.36.112.17] (ovpn-112-17.ams2.redhat.com [10.36.112.17]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 15A7D601A9; Thu, 10 Jan 2019 14:48:46 +0000 (UTC) To: sunwenjie , dev@dpdk.org References: <20190108114509.31489-1-findtheonlyway@gmail.com> From: Maxime Coquelin Message-ID: Date: Thu, 10 Jan 2019 15:48:44 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1 MIME-Version: 1.0 In-Reply-To: <20190108114509.31489-1-findtheonlyway@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Thu, 10 Jan 2019 14:48:48 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH] vhostuser: fix deadlock when vhost unregister X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jan 2019 14:48:49 -0000 Hi Sunwenjie, Thanks for your patch. Please resend with following contribution guidelines, that can be found in doc/guides/contributing/. First, the commit message prefix should be vhost. For other comments, please see inline: On 1/8/19 12:45 PM, sunwenjie wrote: > When rte_vhost_driver_unregister delete the connection fd, fdset_try_del will > always try and donot release the vhostuser.mutex if the fd is busy, but the > fdset_event_dispatch will set the fd to busy and call vhost_user_msg_handler > to get vhostuser.mutex, which will cause deadlock. > The commit message should not be indented, and wrapped at 72 chars. > To fix it: > Unlock the vhost_user.mutex if fdset_try_del fail and relock it when > retry. You need to add your Sined-off-by with your full name. > --- > lib/librte_vhost/socket.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/lib/librte_vhost/socket.c b/lib/librte_vhost/socket.c > index 9cf34ad17..a9effa115 100644 > --- a/lib/librte_vhost/socket.c > +++ b/lib/librte_vhost/socket.c > @@ -961,13 +961,12 @@ rte_vhost_driver_unregister(const char *path) > int count; > struct vhost_user_connection *conn, *next; > > +again: > pthread_mutex_lock(&vhost_user.mutex); > > for (i = 0; i < vhost_user.vsocket_cnt; i++) { > struct vhost_user_socket *vsocket = vhost_user.vsockets[i]; > - Keep this new line, it is out of the scope of the change. > if (!strcmp(vsocket->path, path)) { > -again: > pthread_mutex_lock(&vsocket->conn_mutex); > for (conn = TAILQ_FIRST(&vsocket->conn_list); > conn != NULL; > @@ -981,6 +980,7 @@ rte_vhost_driver_unregister(const char *path) > */ > if (fdset_try_del(&vhost_user.fdset, > conn->connfd) == -1) { > + pthread_mutex_unlock(&vhost_user.mutex); > pthread_mutex_unlock( > &vsocket->conn_mutex); > goto again; > Thanks, Maxime