From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-BY2-obe.outbound.protection.outlook.com (mail-by2nam01on0073.outbound.protection.outlook.com [104.47.34.73]) by dpdk.org (Postfix) with ESMTP id 5B78AD1BB for ; Thu, 23 Mar 2017 13:18:24 +0100 (CET) Received: from BN6PR03CA0083.namprd03.prod.outlook.com (10.164.122.149) by CY4PR03MB2790.namprd03.prod.outlook.com (10.173.38.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.961.17; Thu, 23 Mar 2017 12:18:22 +0000 Received: from BY2FFO11FD040.protection.gbl (2a01:111:f400:7c0c::108) by BN6PR03CA0083.outlook.office365.com (2603:10b6:405:6f::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.991.14 via Frontend Transport; Thu, 23 Mar 2017 12:18:22 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BY2FFO11FD040.mail.protection.outlook.com (10.1.14.225) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.977.7 via Frontend Transport; Thu, 23 Mar 2017 12:18:21 +0000 Received: from [127.0.0.1] ([10.232.134.49]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id v2NCIE1h017557; Thu, 23 Mar 2017 05:18:19 -0700 To: Sergio Gonzalez Monroy , References: <20170317084510.2120-1-akhil.goyal@nxp.com> <20170323080648.7149-1-akhil.goyal@nxp.com> <20170323080648.7149-2-akhil.goyal@nxp.com> <1db2a8d1-e59c-b4ae-7496-6b59e28adba3@intel.com> <05d41e32-1ec0-8532-c8a5-a0eea852e1f5@intel.com> CC: , , , From: Akhil Goyal Message-ID: Date: Thu, 23 Mar 2017 17:48:14 +0530 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <05d41e32-1ec0-8532-c8a5-a0eea852e1f5@intel.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131347451021323584; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(336005)(39410400002)(39860400002)(39450400003)(39850400002)(39380400002)(39400400002)(39840400002)(2980300002)(1110001)(1109001)(3190300001)(339900001)(24454002)(377454003)(189002)(199003)(9170700003)(53936002)(4001350100001)(104016004)(81166006)(229853002)(54906002)(8656002)(23746002)(7246003)(77096006)(8936002)(4326008)(2906002)(5890100001)(6246003)(38730400002)(64126003)(85426001)(8676002)(76176999)(83506001)(65826007)(2950100002)(6666003)(36756003)(54356999)(33646002)(50986999)(5660300001)(7126002)(189998001)(93886004)(31686004)(86362001)(50466002)(305945005)(575784001)(106466001)(120886001)(105606002)(65956001)(356003)(53546009)(230700001)(31696002)(47776003)(65806001); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR03MB2790; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; MLV:ovrnspm; MX:1; A:1; PTR:InfoDomainNonexistent; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BY2FFO11FD040; 1:AGELf+8lcvfGHOMWZtfQKGdMNJPXJ6zy860vw8UBlSCzRZLSZGCmD06n1DT5GF6ARIBHyaOwreW9wRBS08M1byPBaWZLw+asXHx/RIfvrcWQjxOGYxbgeftOaaMvCpTpw0fo3Rzvp+DYKgbjJ6xAsAD6gx64hP0dBIMsWfFgK3NvHMbyaUdexRD1OxT7B8GdwRt7qgsaR9ja3aVSjTuP6eeeW41Jfrg+wvWUlgLPKZ9w0UHWT134dKUYctFt1Qg1hwW8S5iTlhc/ognfx0/OO2JghTLnNJaS2vtWpXTvYvScuOJBueOenN1XbQx3TcHfbjmGWJsOSxLL4N6KvtoBMmsOx6AVZhnFJlVxd2Xi3tTpXhDsz0wY6v29GTi704tDi36nYkDWmKioaoRTZZxO1T/ZRYZRsbTAHpjJGmjFkE6+qExSZ6l+1XRmfWkTAIz5K8dOnYkvEvDqZPPtBnphrnuz044bXP69CHZzwgTFsiSJQdQXkAjkp9AXVA82PcavggAxawlJq41rbY0vKCzCxSFdWFJ8+p/8+8GOJaIA84RbsHwMpsCg4CUTMLWDx7NsWn8bX0D1n1m5KT3TE1W6LYkgg+JC4x+3Oxvxao8Fv3j2PVCY9ygNNtBc2CvuUoas X-MS-Office365-Filtering-Correlation-Id: 696a08f5-89f8-43d0-6d40-08d471e6b2be X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:CY4PR03MB2790; X-Microsoft-Exchange-Diagnostics: 1; CY4PR03MB2790; 3:BwdnX4L6UABAmm9aTZbv3QMq9ujHL17YaWbvQ4obIbp7cZpMnEDZJwlzPN7jlqBDtPuDcMGKA1xaHxESkkpfqwI5tyq6ThuSa7DEqVL9qOTTB/9ZjfoPYEOGRTqE3Gy+ynf+2N0UNGRPEP427iLvXSttUVdaWssGi5kv9wYtec8OfUQK39Ltl9f7w9/hFZycRDZRQnM5YnihDMsHC6i9FuSqWgyJrsee2J8L5Aym5aFORhu5v2sids3vNlqtW6Z2mcOglf/x4T4bmPWPZ8Xv/KJVOu2XwnMhgBkAc6vxku7NhsCeLKnXehtE6jcAxpJXL4tGmiP81tc6DTto2FuweTiOW9NwZh/GFsCzsX55G1J1Y1UUNKy9CBSylpeJ0ymc; 25:sEBtlnb888oz9LTjSKnYnYxEKDhCmHNLQybHTIxDCEpMOYYMhGtptcBvzfCsC23KM/56/d6ONLjHTXmG2OL4FeM4yeQz7jJg1Wgfq8TAOANI/0eFfh9Gx1lZhmErTnvH9ltrgMf/5/gUFknN2RO/Aq+ADJDxWQ993jVIuFloupo+It0i2c9pet1pt7gHlsVFbuswL0b6lH5aj5A4mSmOa1Y0y9nVYjBL0mRY/kifl0rUkjZudURg6Cv61NCC84FdUBachsYR8/0xURnRSp75cfeTn/hSbDPT7cSGYtKjVOYKtmubFmOg8pm4iBULccYj02K77+1hsNIZyWVZe5b77KbT7EELZzn2SZFMiXom/+66DiRMjdHQPN6TSYHHvbESwvV3mFYs95M6gjJrs3wy/pcGGzqigSv5DMNkNL1CpeWSsZyisv1NwCTil6koNoxihuKCZX//0+kLbn+xblOmzQ== X-Microsoft-Exchange-Diagnostics: 1; CY4PR03MB2790; 31:OXyt7mBDCpa3i6vkh6fDkxq0vhud9YYE0jHcrZGYZRKf0efb8KJ8RPlLFrxe/M8M84hUf+1joPtOzfWLbAu86tZY4nkIvLUTUMqR+NoF0j3bFIoeeZPXjb09+GQpBatSrhNvKz3l9CkWxgqgHfo28s9mx9LszsrbFIZ4gXW7PVPCzrDqyjJzGCVVnjpy9kRpqUvwMjAJTdZWkLzkXON0aTOhNFSITZoeJx1z+ZruZYKq11TnJN7eaab1XM0msW1qKrlu1aAXTeuIL+fMGfVQVA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197)(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6095060)(601004)(2401047)(8121501046)(13024025)(13015025)(13017025)(13018025)(13023025)(5005006)(3002001)(10201501046)(6055026)(6096035)(20161123559025)(20161123563025)(20161123556025)(20161123561025)(20161123565025); SRVR:CY4PR03MB2790; BCL:0; PCL:0; RULEID:(400006); SRVR:CY4PR03MB2790; X-Microsoft-Exchange-Diagnostics: 1; CY4PR03MB2790; 4:8viKq79cFR5mrKgTqRo+vBHYnzDHdMcaBM7rsHQWCqFnavgrpfnURTiHTl4SdKJs/XLDHCXEPNT0YntnSvZh5glFqnDQYfZQEQDAD5gwAFVdxVCj57Dh4ENtOHCDnAft4r64AwDtk4YwWxERSZ80kMFILsMwJjwQ0W/XrxzXwFEsOXf6auqLa50hFqqheUSIE0OE3VobWm4HIvcd/ykFPq8BMYgNnzZCCSVnE/QbnwPtlYaEVJQ0s5cqE8T+QsS0YRIGK8XDhk9yc+myUcYlS7b1BQwCFLFcNm4ptEThCqKeXWb5nJOA/SUn4AEoz6Z1IfEiPGw4yfVtnGjVZROt4k3V9K3MwRISsMf+ymD/cvNIhe9/HW2JkW6j68cNA43XW4gr2pnEtFBK9/qlbwq86uEv4hRvqgcfUOaA4vxKI/LV6y3GI7oznVHd/grb/4RQziGzRyqlpTE/XpPNNpCjELCUXCInZCK4AXyX67eKt/edRmxUxYWip9d9FSKCcQUnYPm3AL+QE7Kw4hXt7YG2p4hviDfuSt7tiZt2SlKx4c3gF8NFLczxkEDGNXGjveBHRHELVkXaXvR3EMQVot1qL2VCtIfOOS3Lv019jOnjHxy/uCjN6yjgL1UvP1MKa4RtXNhTpqK6sFKKdav3DVRcwNNbiy1L6c4PXdk9OvAjF/dKDvtQM6j/lhBhBDc9MnxZKvQa+jwStNu787N0oA/QnU/7zDlWiQgoTgP/qrgi8y5Lh6L/Yk9mRzV8y7LvE0bJb+JYhtDt0paE8fimAVncLg== X-Forefront-PRVS: 0255DF69B9 X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; CY4PR03MB2790; 23:8vyLszABielrq7QiCG6gUePRYYh5TypFbM/Gb?= =?Windows-1252?Q?gAMia2HsuJMqVyErgvbS3xFQfwX+0gYGYQ8obriqT3Q0kt5ERUZWjHJk?= =?Windows-1252?Q?XQX1QZPBEB7yCxa1aHx/IMuki8RzkIe7ZxA9hMANhL/7KeEMyCE2cbhM?= =?Windows-1252?Q?ibKS5RfJj/fsiO0XKFQ8jVtikHxWunwCFBalc0ewDJ4q9eTCDYAhJoYD?= =?Windows-1252?Q?ZKDx7HtukWEccAnSQrMvNAQxH/3hrXgkTqNvcG7BVKC8SGk1yKN/dvkw?= =?Windows-1252?Q?r7cv+KoynjncYLwOqcC1dWTGAHmFGW1BdX3E0CmK0+G7WtiZ0RqEEwXr?= =?Windows-1252?Q?BglSkjZXYxGF4tNuUdDayxz0bbYbBuUjg+cLiXSyPs68+smHEVWEZhdv?= =?Windows-1252?Q?LaBk3SXODTf2V7uIKjWDeZDyVg1m6Kmxe4jQ+snKdpL2eOIfZVerxwL5?= =?Windows-1252?Q?SrQnayBWZy58FYGQJTHotB3M3/PiA/b8t4YD08YLUsG0n5KnGxXeKHwE?= =?Windows-1252?Q?Yut1dQA0OiwQp5EyX2ufsTzPoq6iR1IxCsghMMwT+r0CfVfTQJ2cHYOe?= =?Windows-1252?Q?REowTfp7ohKC+npmDTGlFwHaVtlDHWycvmFOLZLTDP0gRQWevx4N/wov?= =?Windows-1252?Q?mFxtua3L0DAjgkcbrsjVGvLzUnz4MXI3/Wwzbi2+kOBkLqSArRfnP5Jt?= =?Windows-1252?Q?WhdFFKfT3q/90VFmdiy9jorEfj1QEb801LxIX4XMGP/8GTxIxLw4pzFr?= =?Windows-1252?Q?BPF5WD0tB1dRKYOp/8gn4UMqdF7YeJvstTsVbW1UQjJVkKuIFCfVTGwA?= =?Windows-1252?Q?PyvPMcSEmoWh5o4dP9pk+N27s3SfiaI4drBso28G9QzrEL75Ozi3P1yZ?= =?Windows-1252?Q?6AaLkRQdxX/6QnNOiTsotaeFmmzA9VJHPQ4Guvstgbg9NQPbjU4X9han?= =?Windows-1252?Q?XF/b4qhch3WuAeHTbMI1L7h7iCIVCmYJdKT96GrgEkG9ePwQ2PtvoOqy?= =?Windows-1252?Q?DYEqiey89ofpkqlX1QKuuQ164j4T/8QphO4A3nh7klldUI3ZIFYRuP9B?= =?Windows-1252?Q?A6WBKT8DvCd9HVrYRll9+YwZ+wbnSDBaLFbQGSK4e55vusCj1oktA8+w?= =?Windows-1252?Q?0ApWzkQc3uuRLJhBwvzCFMmrnGXsU67Ed7kTx/p/TP2c1JSkSIwo1qDL?= =?Windows-1252?Q?1FFY2RyzpzjHICsvB3kFrV1hktyyO9vZ1vRE+WVLnfdLxo1/geV7gvMx?= =?Windows-1252?Q?pIpNiXl9i1umcitOZ/IDe6M4B7ukmFemGhngTCP+zpH0QYWsAyWrsviZ?= =?Windows-1252?Q?QTcFfrlQiXsUQQ/61JcdJHaI2O/6MbneBm0VgQpHWJWpfIqi4pmVDj5I?= =?Windows-1252?Q?GRFpJj1zdTjz2/nkMvhE4NWmjonGhfyj910VGmD4PR6/cC2bvNAFy4Kx?= =?Windows-1252?Q?t3em/eC53aQdlcbgib9W9d1kUeQ1mVatFvhrnurAIj3VEMLNqW0lRbCj?= =?Windows-1252?Q?NHo7XeSTeTzlNhChLbHxDpiciyu3YNoAwShewBMDOD38adEY0hXAPnL9?= =?Windows-1252?Q?pfigrVwaidfjd/E3vePo41rhxYhcGw7FppaUKT7x3gVAbVRF/2BU/B4J?= =?Windows-1252?Q?LyF/tPO2tGALN+rYgBch+pIK1EdH5NHniHqsFdA4ewZR/4so48b789GP?= =?Windows-1252?Q?GDv+uBj+7DbFU2RhV6L7skzkCVCE1LA84U3ArORe1UoTjejG5CS?= X-Microsoft-Exchange-Diagnostics: 1; CY4PR03MB2790; 6:wf5a+qqe2nmw5f9aNaF1wsPmllJ442aEjdmOiBPb4Wh3R8ZPCKP0SSKQ9eNBsULszp23IwS85Zpa6PPDX9WjhsGpZzKHLlzHr6pCUdoPOLULpZ4Pe1TJvEYx6kVgIfbk5FUo7SOjSYmsUhJN/P6eACK19TviKU4ybq6/wsYxsvN1CemgHaDYMMQDDb0N8E5JKcZPnZGC5ZRFB6Op/E9QQ4Ns7HLKLamFbo3cY4BUA02uAkxOMc6u5PlJlgDjvSsoYR3qnuD3eGsoIrNx3F1mO27/PDokbzNRIInlSJKoS37FV8PJSJWdtKAXABRmIgZoSsCAU6RgsI4tml/IzPyywiI5vsi0vxOTuDmZGRaQt8BP05FcQPy5DS5H4DBJ7ORLHqcAv43Eazk3ZY5QWb/Ir8uMBUgs5m1zQKXE+ldT35U=; 5:UwUS3P2uuIKxK//8vPk+5GclINSAo1ZqFL3SRohtpruuIZGAfi30as14zkFWZiDydsYgTcpMBY+89cXqOxFLlj1Gz7W0Kb4L7VE6LSqr5hTKhBmqlUcX3z4UeOGW2YswJQmsSpj0EgntH92AB2rnMs8tjzA1HslFvy1/Aqi6qc8z049GeZyN9ea1xzYhZRw0; 24:08GRQ8Bh++mQr5T+WHN3xvUaFHsQU+hwMnGBGMhCxH6RUpc+nHjCCs6c1O0QVH4niMvucR9H6dBcq9X85pOBUwKDA63npMR0aIlPIjzmr4Y= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; CY4PR03MB2790; 7:eSs1CROJdqytiLrxBc5TIyfnyz7SSOgMbawK4nvGwCoh1ctxpk4lYnSXZZX5Pzc0A3RhSCwzypAqBLqYG6zlTSwuw/W+u6WKET3Y72OI1IkaJgEXNfnJTJp2/bMN9StWNRsgvP72IMNdQmBXv1ZD2Ke0yldQcszdO6gZW2gly8v9zaZxwAPURgVZg5QPUXe5oBJXFEvHJpLjilSdhSE1Se0Gr75QTQX6O5ombBFFlMya/JwuMSpRT85DpHId3t2evbp7wJTOk7eAzFC+m80sPfk0mGurMh0D6qW6dsq14Cu0sCGEQ/1F4pHM/fueCkaaJloPRFZPv8KofJqBs1x9sQ== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2017 12:18:21.8983 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR03MB2790 Subject: Re: [dpdk-dev] [PATCH v2 2/2] examples/ipsec-secgw: attach session-qp X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Mar 2017 12:18:24 -0000 On 3/23/2017 4:13 PM, Sergio Gonzalez Monroy wrote: > On 23/03/2017 10:38, Akhil Goyal wrote: >> On 3/23/2017 4:00 PM, Sergio Gonzalez Monroy wrote: >>> That was simpler than I thought. >>> >>> For some reason I understood that the device will support thousands of >>> queues and single session per queue which would have needed more app >>> changes. >>> >>> On 23/03/2017 08:06, akhil.goyal@nxp.com wrote: >>>> From: Akhil Goyal >>>> >>>> adding support for attaching session to queue pairs. >>>> This is required as underlying crypto driver may only >>>> support limited number of sessions per queue pair >>>> if max_nb_sessions_per_qp > 0, session should be >>>> attached to a particular qp. >>>> >>>> Signed-off-by: Akhil Goyal >>>> --- >>>> examples/ipsec-secgw/ipsec.c | 12 ++++++++++++ >>>> 1 file changed, 12 insertions(+) >>>> >>>> diff --git a/examples/ipsec-secgw/ipsec.c >>>> b/examples/ipsec-secgw/ipsec.c >>>> index 144f0aa..b35b30f 100644 >>>> --- a/examples/ipsec-secgw/ipsec.c >>>> +++ b/examples/ipsec-secgw/ipsec.c >>>> @@ -47,6 +47,7 @@ >>>> static inline int >>>> create_session(struct ipsec_ctx *ipsec_ctx __rte_unused, struct >>>> ipsec_sa *sa) >>>> { >>>> + struct rte_cryptodev_info cdev_info; >>>> unsigned long cdev_id_qp = 0; >>>> int32_t ret; >>>> struct cdev_key key = { 0 }; >>>> @@ -73,6 +74,17 @@ create_session(struct ipsec_ctx *ipsec_ctx >>>> __rte_unused, struct ipsec_sa *sa) >>>> sa->crypto_session = rte_cryptodev_sym_session_create( >>>> ipsec_ctx->tbl[cdev_id_qp].id, sa->xforms); >>>> + rte_cryptodev_info_get(ipsec_ctx->tbl[cdev_id_qp].id, &cdev_info); >>>> + if (cdev_info.sym.max_nb_sessions_per_qp > 0) { >>>> + ret = rte_cryptodev_queue_pair_attach_sym_session( >>>> + ipsec_ctx->tbl[cdev_id_qp].qp, >>>> + sa->crypto_session); >>>> + if (ret < 0) { >>>> + RTE_LOG(ERR, IPSEC, "Session cannot be attached" >>>> + " to qp %u ", ipsec_ctx->tbl[cdev_id_qp].qp); >>> >>> Guideline is to keep error strings in single line to facilitate grep. >>> Other than that: >>> >>> Acked-by: Sergio Gonzalez Monroy >>> >>>> + return -1; >>>> + } >>>> + } >>>> sa->cdev_id_qp = cdev_id_qp; >>>> return 0; >>> >>> >>> >> Hi Sergio, >> >> Similar error string is mentioned above my change also in the same >> function. I deliberately did that as per the error strings in the file. >> >> Thanks, >> Akhil >> > > That means that we need to update those strings too, but new code should > try to keep error string in single line. > > Thanks, > Sergio > Ok I would correct the string. Will send the v3 with this change only if there is no more comments from Fiona. Thanks, Akhil