From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 277B7A04AC; Fri, 7 Aug 2020 06:02:17 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 57CB42B87; Fri, 7 Aug 2020 06:02:16 +0200 (CEST) Received: from huawei.com (szxga06-in.huawei.com [45.249.212.32]) by dpdk.org (Postfix) with ESMTP id E349D2B84 for <dev@dpdk.org>; Fri, 7 Aug 2020 06:02:13 +0200 (CEST) Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 1EB175C03D9DCFADB790; Fri, 7 Aug 2020 12:02:12 +0800 (CST) Received: from [127.0.0.1] (10.65.81.238) by DGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP Server id 14.3.487.0; Fri, 7 Aug 2020 12:02:03 +0800 To: Slava Ovsiienko <viacheslavo@mellanox.com>, "dev@dpdk.org" <dev@dpdk.org> References: <1596619484-19714-1-git-send-email-tangchengchang@huawei.com> <1596686446-8138-1-git-send-email-tangchengchang@huawei.com> <AM4PR05MB3265E393D61E9E02DDE0A747D2480@AM4PR05MB3265.eurprd05.prod.outlook.com> CC: "linuxarm@huawei.com" <linuxarm@huawei.com>, Thomas Monjalon <thomas@monjalon.net>, "ferruh.yigit@intel.com" <ferruh.yigit@intel.com>, "arybchenko@solarflare.com" <arybchenko@solarflare.com>, "stephen@networkplumber.org" <stephen@networkplumber.org> From: Chengchang Tang <tangchengchang@huawei.com> Message-ID: <a8d0cee3-9344-d040-2d98-a6d43646c068@huawei.com> Date: Fri, 7 Aug 2020 12:00:46 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <AM4PR05MB3265E393D61E9E02DDE0A747D2480@AM4PR05MB3265.eurprd05.prod.outlook.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.65.81.238] X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH v2] doc: add new field to rxq info struct X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> On 2020/8/6 20:50, Slava Ovsiienko wrote: >> -----Original Message----- >> From: dev <dev-bounces@dpdk.org> On Behalf Of Chengchang Tang >> Sent: Thursday, August 6, 2020 7:01 >> To: dev@dpdk.org >> Cc: linuxarm@huawei.com; Thomas Monjalon <thomas@monjalon.net>; >> ferruh.yigit@intel.com; arybchenko@solarflare.com; >> stephen@networkplumber.org >> Subject: [dpdk-dev] [PATCH v2] doc: add new field to rxq info struct >> >> Struct rte_eth_rxq_info will be modified to include a new field, indicating the >> size of each buffer that could be used for hw to receive packets. Add this >> field to rte_eth_rxq_info to expose relevant information to upper layer >> users/application. >> >> For more details: >> https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fmails. >> dpdk.org%2Farchives%2Fdev%2F2020- >> July%2F176135.html&data=02%7C01%7Cviacheslavo%40mellanox.com >> %7Cdb0d8bcc221145a4a67508d839bd9f14%7Ca652971c7d2e4d9ba6a4d149 >> 256f461b%7C0%7C0%7C637322833881598698&sdata=W2G3iEdepIjSlp >> Wq4296k7cmXV1RhMnfl88TAjivWLc%3D&reserved=0 >> >> Signed-off-by: Chengchang Tang <tangchengchang@huawei.com> >> Acked-by: Andrew Rybchenko <arybchenko@solarflare.com> >> --- >> v2: >> - Remove field name. >> - Fix some spelling mistakes. >> --- >> doc/guides/rel_notes/deprecation.rst | 9 +++++++++ >> 1 file changed, 9 insertions(+) >> >> diff --git a/doc/guides/rel_notes/deprecation.rst >> b/doc/guides/rel_notes/deprecation.rst >> index ea4cfa7..f08b5f9 100644 >> --- a/doc/guides/rel_notes/deprecation.rst >> +++ b/doc/guides/rel_notes/deprecation.rst >> @@ -110,6 +110,15 @@ Deprecation Notices >> break the ABI checks, that is why change is planned for 20.11. >> The list of internal APIs are mainly ones listed in ``rte_ethdev_driver.h``. >> >> +* ethdev: A new field will be added to the public data structure >> + ``rte_eth_rxq_info`` to indicate the buffer size used in receiving >> +packets >> + for HW. When receive packets, HW DMA won't exceed this size. And it >> +will >> + affect the number of fragments in receiving packets when scatter is >> enabled. >> + So, add this field to ``rte_eth_rxq_info`` to expose relevant >> +information to >> + upper layer user/application. >> + This change is planned for 20.11. For more details: >> + >> +https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fmail >> s >> +.dpdk.org%2Farchives%2Fdev%2F2020- >> July%2F176135.html&data=02%7C01%7 >> +Cviacheslavo%40mellanox.com%7Cdb0d8bcc221145a4a67508d839bd9f14 >> %7Ca65297 >> +1c7d2e4d9ba6a4d149256f461b%7C0%7C0%7C637322833881598698& >> ;sdata=W2G3i >> +EdepIjSlpWq4296k7cmXV1RhMnfl88TAjivWLc%3D&reserved=0 >> + >> * traffic manager: All traffic manager API's in ``rte_tm.h`` were mistakenly >> made >> ABI stable in the v19.11 release. The TM maintainer and other contributors >> have >> agreed to keep the TM APIs as experimental in expectation of additional >> spec >> -- >> 2.7.4 > We are going to introduce the more flexible format to descript the rx buffers > with multiple segment lengths/pools. It might be worth to consider extending this > info structure single field to array. I suppose it is the subject for further discussion (on RFC). I saw your announcement about changing rxconf structure, and it looks interesting. I am not sure if I need to mention this in v3? > > Acked-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com> > > > > . >