From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 453DCA00C2; Thu, 6 Oct 2022 12:13:15 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 36C3E42B70; Thu, 6 Oct 2022 12:13:15 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 708E140042 for ; Thu, 6 Oct 2022 12:13:14 +0200 (CEST) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 0792786; Thu, 6 Oct 2022 13:13:14 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 0792786 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1665051194; bh=n/W1+oHlsbReS8uGhJNaEVIHDa6/3MREz/fi9JN79fI=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=tFC7HoQJwmTvI/mrVPL1C+RUMJLsXjhOdcEtIKau6RPeBx9mO5gD85P3IntAU5Yvr E77tF/9N35ozVdf/AL+6QdfQvvKLL8zz0dj9vIR0s/IxrqC4SKpZn+vFoBAOzUeBsJ ZaCYdMSNRNAr36tGr1OLGoIEL3X4XlkVfw80T9g4= Message-ID: Date: Thu, 6 Oct 2022 13:13:13 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v8 0/4] support protocol based buffer split Content-Language: en-US To: Yuan Wang , dev@dpdk.org Cc: thomas@monjalon.net, ferruh.yigit@xilinx.com, mdr@ashroe.eu, xiaoyun.li@intel.com, aman.deep.singh@intel.com, yuying.zhang@intel.com, qi.z.zhang@intel.com, qiming.yang@intel.com, jerinjacobk@gmail.com, viacheslavo@nvidia.com, stephen@networkplumber.org, xuan.ding@intel.com, hpothula@marvell.com, yaqi.tang@intel.com References: <20220812181552.2908067-1-yuanx.wang@intel.com> <20221005231836.215112-1-yuanx.wang@intel.com> From: Andrew Rybchenko Organization: OKTET Labs In-Reply-To: <20221005231836.215112-1-yuanx.wang@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 10/6/22 02:18, Yuan Wang wrote: > Protocol type based buffer split consists of splitting a received packet > into several separate segments based on the packet content. It is useful > in some scenarios, such as GPU acceleration. The splitting will help to > enable true zero copy and hence improve the performance significantly. > > This patchset aims to support protocol header split based on current buffer > split. When Rx queue is configured with RTE_ETH_RX_OFFLOAD_BUFFER_SPLIT > offload and corresponding protocol, packets received will be directly split > into different mempools. > > Change log: > v8: > Restrict length == 0 and proto_hdr == 0 in another buffer split. > Add check for proto_hdr == 0 in last segment. > Use heap instead of stack for array to avoid vulnerabilities. > Define the proto_hdr for two segments and multi-segments, respectively. > Separate variable definition and code. > Refine the doc and commit log. Overall LGTM, please, process review notes and I think it will be ready to be accepted.