From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 044871066 for ; Wed, 25 Apr 2018 10:24:44 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Apr 2018 01:24:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,325,1520924400"; d="scan'208";a="50642230" Received: from tanjianf-mobl.ccr.corp.intel.com (HELO [10.67.64.57]) ([10.67.64.57]) by orsmga001.jf.intel.com with ESMTP; 25 Apr 2018 01:24:41 -0700 To: Anatoly Burakov , dev@dpdk.org References: <02a4a77c846287fcb3abb56af38e8b35dc040979.1523979264.git.anatoly.burakov@intel.com> Cc: thomas@monjalon.net From: "Tan, Jianfeng" Message-ID: Date: Wed, 25 Apr 2018 16:24:41 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <02a4a77c846287fcb3abb56af38e8b35dc040979.1523979264.git.anatoly.burakov@intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 5/5] malloc: fix potential negative return X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Apr 2018 08:24:45 -0000 On 4/17/2018 11:48 PM, Anatoly Burakov wrote: > Return value from rte_socket_id_by_idx() may be negative, which would > result in negative index access. > > Additionally, return value was of mismatched type (function returns > signed int, socket id was unsigned). > > Coverity issue: 272571 > Coverity issue: 272597 > > Fixes: 30bc6bf0d516 ("malloc: add function to dump heap contents") > Cc: anatoly.burakov@intel.com > > Signed-off-by: Anatoly Burakov > --- > lib/librte_eal/common/rte_malloc.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/lib/librte_eal/common/rte_malloc.c b/lib/librte_eal/common/rte_malloc.c > index b51a6d1..f207ba2 100644 > --- a/lib/librte_eal/common/rte_malloc.c > +++ b/lib/librte_eal/common/rte_malloc.c > @@ -169,7 +169,11 @@ rte_malloc_dump_heaps(FILE *f) > unsigned int idx; > > for (idx = 0; idx < rte_socket_count(); idx++) { > - unsigned int socket = rte_socket_id_by_idx(idx); > + int socket = rte_socket_id_by_idx(idx); > + if (socket < 0) { > + RTE_LOG(ERR, EAL, "Invalid socket index: %u\n", idx); > + continue; > + } For such check (and many others), we are clear that idx is guaranteed by rte_socket_count(), so rte_socket_id_by_idx() can never return -1. So why not just reporting this as false-positive? Thanks, Jianfeng > fprintf(f, "Heap on socket %i:\n", socket); > malloc_heap_dump(&mcfg->malloc_heaps[socket], f); > }