From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 101D3A0C4B; Thu, 17 Jun 2021 16:21:59 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E929B4069C; Thu, 17 Jun 2021 16:21:58 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 0B77E40150 for ; Thu, 17 Jun 2021 16:21:58 +0200 (CEST) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id AFC9E7F50E; Thu, 17 Jun 2021 17:21:57 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru AFC9E7F50E DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1623939717; bh=H3BeiMOAOz3Z52zGXf8F9Fav9KL8hTh5KNEaaAmmOsQ=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=QGYHXCIJwbch66xH79VMFtWWcD2+Y8faSH5wbRfmPcwRcV3bAGDJfWcMoDVfADioi 2xArC2S/mrOOt/yXXv32kk5qeAqgw58DlREkJEBlh6CwmgUZk50kz+7JWQ9Y2ZvnC6 UNWjsJKzN/me6LOE9fJVeIx+SkB37xUZwcpGubXc= To: "Li, Xiaoyun" , Ori Kam Cc: "dev@dpdk.org" , "Richardson, Bruce" , "Yigit, Ferruh" , "Singh, Aman Deep" References: <20210527162452.1568351-1-andrew.rybchenko@oktetlabs.ru> <20210616163209.823918-1-andrew.rybchenko@oktetlabs.ru> From: Andrew Rybchenko Organization: OKTET Labs Message-ID: Date: Thu, 17 Jun 2021 17:21:57 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: send failure logs to stderr X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi On 6/17/21 6:29 AM, Li, Xiaoyun wrote: > Hi > >> -----Original Message----- >> From: Andrew Rybchenko >> Sent: Thursday, June 17, 2021 00:32 >> To: Li, Xiaoyun ; Ori Kam >> Cc: dev@dpdk.org; Richardson, Bruce ; Yigit, >> Ferruh ; Singh, Aman Deep >> >> Subject: [PATCH v2] app/testpmd: send failure logs to stderr >> >> Running with stdout suppressed or redirected for further processing >> is very confusing in the case of errors. Fix it by logging errors and >> warnings to stderr. >> >> Since lines with log messages are touched anyway concatanate split > > Typo: "concatenate" > And it's really good to have those split strings combined. Thanks. Thanks, fixed in v3. >> format string to make it easier to search using grep. >> >> Fix indent of format string arguments. >> >> Signed-off-by: Andrew Rybchenko >> --- >> v2: >> - switch from printf() to fpritnf(stderr, ...) in more cases >> - do not inherit acks from the previous version since the patch is >> much bigger >> - fix style in few cases (TAB vs spaces, missing space separtor etc) >> - still don't use TESTPMD_LOG() since the patch does not add new logs. >> Also switching to TESTPMD_LOG() will add "testpmd: " prefix to log >> messages and it is a real change and could be a pain for automation. >> >> app/test-pmd/bpf_cmd.c | 6 +- >> app/test-pmd/cmdline.c | 957 ++++++++++++++----------- >> app/test-pmd/cmdline_flow.c | 20 +- >> app/test-pmd/cmdline_mtr.c | 8 +- >> app/test-pmd/cmdline_tm.c | 33 +- >> app/test-pmd/config.c | 452 ++++++------ >> app/test-pmd/csumonly.c | 5 +- >> app/test-pmd/parameters.c | 21 +- >> app/test-pmd/testpmd.c | 298 ++++---- >> app/test-pmd/util.c | 19 +- >> doc/guides/rel_notes/release_21_08.rst | 5 + >> 11 files changed, 1002 insertions(+), 822 deletions(-) > >> 2.30.2 > > This patch overall looks good to me. > > But there're some warnings about coding styles reported. http://mails.dpdk.org/archives/test-report/2021-June/199047.html > Not all of them makes sense. > But can you check ones with QUOTED_WHITESPACE_BEFORE_NEWLINE, UNSPECIFIED_INT, EMBEDDED_FUNCTION_NAME? > The latter two type of warnings are legacy issues but it'll be good to have them fixed. Yes, I agree. Fixed. Andrew.