From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id CDC7F7CBA for ; Wed, 25 Apr 2018 16:14:28 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Apr 2018 07:14:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,326,1520924400"; d="scan'208";a="36958732" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.237.220.109]) ([10.237.220.109]) by orsmga006.jf.intel.com with ESMTP; 25 Apr 2018 07:14:25 -0700 To: Arnon Warshavsky Cc: Thomas Monjalon , "Lu, Wenzhuo" , "Doherty, Declan" , jerin.jacob@caviumnetworks.com, Bruce Richardson , "Yigit, Ferruh" , dev@dpdk.org References: <1524608213-2080-1-git-send-email-arnon@qwilt.com> <1524663944-30376-1-git-send-email-arnon@qwilt.com> <1524663944-30376-8-git-send-email-arnon@qwilt.com> From: "Burakov, Anatoly" Message-ID: Date: Wed, 25 Apr 2018 15:14:25 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v8 07/10] eal: replace rte_panic instances in hugepage_info X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Apr 2018 14:14:29 -0000 On 25-Apr-18 3:02 PM, Arnon Warshavsky wrote: > > I think i've already acked this. You should keep acks etc. between > versions (unless you're making significant enough changes that you > think would invalidate a prior ack). Having acks makes it easier to > track what still needs to be reviewed and what is good to go, and it > makes it easier to see if the entire patchset is ready for apply. > > > Hmm, so unless I am missing yet another thing - this needs to be done > manually? > Yes. Well, if someone series-acks your patch, you can do "git filter-branch", but for individual patches, yes, you need to do this manually by editing the commit message. -- Thanks, Anatoly