From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 195A391; Tue, 13 Nov 2018 12:19:18 +0100 (CET) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us1.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id 1850C780069; Tue, 13 Nov 2018 11:19:17 +0000 (UTC) Received: from [192.168.38.17] (91.220.146.112) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 13 Nov 2018 11:19:11 +0000 To: Ferruh Yigit , Thomas Monjalon CC: , Wenzhuo Lu , References: <1541642954-37497-1-git-send-email-wenzhuo.lu@intel.com> <20181113111238.80107-1-ferruh.yigit@intel.com> From: Andrew Rybchenko Message-ID: Date: Tue, 13 Nov 2018 14:19:08 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20181113111238.80107-1-ferruh.yigit@intel.com> Content-Language: en-GB X-Originating-IP: [91.220.146.112] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24218.003 X-TM-AS-Result: No-6.042600-8.000000-10 X-TMASE-MatchedRID: VPleTT1nwdQOwH4pD14DsPHkpkyUphL9wx0jRRxcQfOtj24Xqh0yXLqp W/iJ1C/p16im8aWNj2sMLq3lVTN3H9RvK63SVd6gaDgPZBX/bMvqvccKLF+4pwwv1ZvdCH+FVM2 p/cRDyjFic/5yraYWDlebGpjHs5mWxldSKOGXaXwZCVRU/aI9zC2VljVYB9GN2Yajy1P9W1XdKU SBW7I322+5ieh24ZYRkZOl7WKIImrvXOvQVlExsNAtbEEX0MxBnH7sbImOEBTFn2jK56fezIW/q OBC0kidWOO/eBGtGdf73/B9lrLW6WZab/emqB0LhUB4HepM7rTp/8/p7WzGBVyjSpAg03+0/Ga3 3hTfnKrAvpLE+mvX8g== X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--6.042600-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24218.003 X-MDID: 1542107957-E6OCgZmB_Zd0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v4 1/3] ethdev: fix invalid device configuration after failure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Nov 2018 11:19:19 -0000 On 11/13/18 2:12 PM, Ferruh Yigit wrote: > From: Wenzhuo Lu > > The new configuration is stored during the rte_eth_dev_configure() API > but the API may fail. After failure stored configuration will be > invalid since it is not fully applied to the device. > > We better roll the configuration back after failure. > > Fixes: af75078fece3 ("first public release") > Cc: stable@dpdk.org > > Signed-off-by: Wenzhuo Lu > Signed-off-by: Ferruh Yigit Reviewed-by: Andrew Rybchenko