From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Jeff Guo <jia.guo@intel.com>,
helin.zhang@intel.com, jingjing.wu@intel.com
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] pci: fix configure device fail issue
Date: Wed, 8 Feb 2017 10:53:46 +0000 [thread overview]
Message-ID: <a9339940-1fa6-b354-6972-b5792c48b257@intel.com> (raw)
In-Reply-To: <1486547416-63712-1-git-send-email-jia.guo@intel.com>
On 2/8/2017 9:50 AM, Jeff Guo wrote:
> If assign the "data->dev_flags" after run function "rte_eth_copy_pci_info", the
> flag would be miss the “RTE_ETH_DEV_INTR_LSC” value, that will result the device
> configuration fail, when rte check the flag if device support link state interrupt.
> So the assignment must be modified to "|=" to fix the issue.
>
> Fixes: 22dda618c00c ("pci: separate detaching ethernet ports from PCI devices")
>
> Signed-off-by: Jeff Guo <jia.guo@intel.com>
This is same as Qi's patch:
http://dpdk.org/dev/patchwork/patch/20163/
That one is earlier, but missing em driver, so I will use this patch
with sign-off from both of you. Please shout if you disagree.
Thanks,
ferruh
next prev parent reply other threads:[~2017-02-08 10:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-08 9:50 Jeff Guo
2017-02-08 10:53 ` Ferruh Yigit [this message]
2017-02-08 13:58 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a9339940-1fa6-b354-6972-b5792c48b257@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=helin.zhang@intel.com \
--cc=jia.guo@intel.com \
--cc=jingjing.wu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).