From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id 69CE9952
 for <dev@dpdk.org>; Wed,  8 Feb 2017 11:53:48 +0100 (CET)
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
 by orsmga102.jf.intel.com with ESMTP; 08 Feb 2017 02:53:48 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.33,346,1477983600"; d="scan'208";a="1123694487"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.137])
 ([10.237.220.137])
 by fmsmga002.fm.intel.com with ESMTP; 08 Feb 2017 02:53:46 -0800
To: Jeff Guo <jia.guo@intel.com>, helin.zhang@intel.com, jingjing.wu@intel.com
References: <1486547416-63712-1-git-send-email-jia.guo@intel.com>
Cc: dev@dpdk.org
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <a9339940-1fa6-b354-6972-b5792c48b257@intel.com>
Date: Wed, 8 Feb 2017 10:53:46 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.7.1
MIME-Version: 1.0
In-Reply-To: <1486547416-63712-1-git-send-email-jia.guo@intel.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH] pci: fix configure device fail issue
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 08 Feb 2017 10:53:49 -0000

On 2/8/2017 9:50 AM, Jeff Guo wrote:
> If assign the "data->dev_flags" after run function "rte_eth_copy_pci_info", the
> flag would be miss the “RTE_ETH_DEV_INTR_LSC” value, that will result the device
> configuration fail, when rte check the flag if device support link state interrupt.
> So the assignment must be modified to "|=" to fix the issue.
> 
> Fixes: 22dda618c00c ("pci: separate detaching ethernet ports from PCI devices")
> 
> Signed-off-by: Jeff Guo <jia.guo@intel.com>

This is same as Qi's patch:
http://dpdk.org/dev/patchwork/patch/20163/

That one is earlier, but missing em driver, so I will use this patch
with sign-off from both of you. Please shout if you disagree.

Thanks,
ferruh