Re: [PATCH] net/nfp: improve readability NFP HWINFO header

[Ferruh Yigit <ferruh.yigit@xilinx.com>]

On 9/21/2022 8:19 AM, Niklas Söderlund wrote:
> Hello Ferruh,
> 
> On 2022-09-20 19:01:47 +0100, Ferruh Yigit wrote:
>> Instead of changing the log content and API with same patch, it is
>> better to have them separate.
> 
> I agree.
> 
>>
>> I prefer to convert them to proper log API first, and later fix the content
>> of the log (to not update a line with wrong call).
>> But order of patch preference is a soft one, if somehow other-way around
>> (first fix the log content, later the API) makes your life easier, I am OK
>> to go with that too (as long as both issues are fixed).
> 
> In principle I agree with you here as well. In this case it would make
> our life easier if we could do it the other way around. Reason being the
> patch to convert the NFP PMD to the log API touch most files in the
> driver and is at the tail of the 50+ patches we have in our internal
> queue trying to get out.
> 
> While it would be somewhat OK to post that patch separately I fear it
> would create conflicts with the other patches in our queue. So I thin
> either we drop this patch now and we pick it up at the end of our queue,
> or we take this as is now. My preference would be to take it now, but
> I'm not feeling strongly about it.
> 

It is very trivial change, lets get it out of way.
For log fix patch, I understand concern on the conflicts, but please 
don't forget to sent it out after functional patches are done.