From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2B070A034C; Wed, 21 Sep 2022 10:09:37 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D02C640E0F; Wed, 21 Sep 2022 10:09:36 +0200 (CEST) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2040.outbound.protection.outlook.com [40.107.236.40]) by mails.dpdk.org (Postfix) with ESMTP id F13954014F for ; Wed, 21 Sep 2022 10:09:34 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GKL/fyu97neJ/lfFYIoPqWNMSfJpGz+t9y5F3v5eihkEN3mqdw4mGZszrtvNCdFvmGPkWA7UqjBg3+0dD181fWsh23Vhwcxny/sMYayI2sg1NDIvU2MApJCI8Y857xquqYRqwewjk9aArwwWLYRsUF90bq7a1YC015SJL2h969mS8k4kYPuQPD1/bv6ME8H9m7mUIjq6VIClt0nQw4pbgexYNKfLJSG43S9S/59JG39f6OD7ueF2H2hJvlGAyRpgaQk/l3B85BnpJBzbFtvj29q/eOq/4BXUfLThuheWdwWy9s0wXa4qQVjznDrY5G7/sTp0eUdTq2t3aXwivGkVEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Sgzqihbf9AgIZqDK9FEZBROZaAzdDd0faVfNNe2rnU4=; b=WTBOWoRvb+ubVsxf81iysHhhMp4JbINQLipSj8qrrW0dx1h1yIXayvDsaDFMXQ+aTB1auLsDLIfhTrHylUlWAQznyg9ufeEbPCj3L9P255yudNtdpXTRwyRWgJ3XMfRrxKNjQoxSJRp7dS0Dh1R2scAaOjgj4sV6BRDzUNXbGftspJfjDbFWvwTyeYwyW/FtYOYynYF0hPU5Zjzboe5eZN/EYUFEt+SGRrGyeJjQ9juERZqCZ+iaUsAfXsqcwRuYgn0XbSHej7AD61zgLoHQIC7mAAoVsFeam3tPH8lRJaZeGH2NVrXdDvjUcEMwChtWuuiL/NBsc8n6E1LO9r4Iag== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.80.198) smtp.rcpttodomain=corigine.com smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Sgzqihbf9AgIZqDK9FEZBROZaAzdDd0faVfNNe2rnU4=; b=tKKulEd23Vd2YblTA8PWgUpfYJH2KwAfv8m13fgjkrgrtOuvXWcd9ZbEBDJ5Dj7EpyLRCHocY0TAdqjjFqhPLHxVTK1bcBEgZWSUCznXjVO6cKev0kX4HVpE0NX49Qs4kE54cbgmFgqxClRmCwYThoQKzn6cXS2v0ionwqw5j0Y= Received: from BN9PR03CA0459.namprd03.prod.outlook.com (2603:10b6:408:139::14) by CH2PR02MB6742.namprd02.prod.outlook.com (2603:10b6:610:7a::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.16; Wed, 21 Sep 2022 08:09:32 +0000 Received: from BN1NAM02FT045.eop-nam02.prod.protection.outlook.com (2603:10b6:408:139:cafe::8a) by BN9PR03CA0459.outlook.office365.com (2603:10b6:408:139::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.16 via Frontend Transport; Wed, 21 Sep 2022 08:09:32 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.80.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.80.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.80.198; helo=xir-pvapexch01.xlnx.xilinx.com; pr=C Received: from xir-pvapexch01.xlnx.xilinx.com (149.199.80.198) by BN1NAM02FT045.mail.protection.outlook.com (10.13.2.156) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5654.14 via Frontend Transport; Wed, 21 Sep 2022 08:09:31 +0000 Received: from xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) by xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 21 Sep 2022 09:09:30 +0100 Received: from smtp.xilinx.com (172.21.105.198) by xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server id 15.1.2375.24 via Frontend Transport; Wed, 21 Sep 2022 09:09:30 +0100 Envelope-to: niklas.soderlund@corigine.com, chaoyong.he@corigine.com, dev@dpdk.org, oss-drivers@corigine.com, james.hershaw@corigine.com Received: from [10.71.194.74] (port=58459) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1oaunS-0003ds-HT; Wed, 21 Sep 2022 09:09:30 +0100 Message-ID: Date: Wed, 21 Sep 2022 09:09:30 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH] net/nfp: improve readability NFP HWINFO header Content-Language: en-US To: =?UTF-8?Q?Niklas_S=c3=b6derlund?= CC: Chaoyong He , , , James Hershaw References: <1661492343-23225-1-git-send-email-chaoyong.he@corigine.com> <12848fb2-4957-1425-ea4e-0e4f62f13024@xilinx.com> From: Ferruh Yigit In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN1NAM02FT045:EE_|CH2PR02MB6742:EE_ X-MS-Office365-Filtering-Correlation-Id: 8e425fb5-b1be-4fbe-49d9-08da9ba89d16 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: UkUAkd5Nm1VTsdYs26SWLvMzy4xLiA/QbkPtiTpp+wuxGO8skKVANkkUWxa1yrATVwvL2iLLQeViIso97uGzS311oyvgmZbzNF+Hg32/lRccTtSZUj+39xK/ezonvmF6eSSPuw6OeIoxSajgTZ3Xm7RWsrp8R5xnCt2nooOc7JBKE+j/5Lfy0D1EPDtiW/aQCqf7XnZqyaT3I3vFanSpA2BEImKlxO685IBdwxTG35qAfSWrsn6EL5/BkGfmTsUGnlyMptZZrWtAwW3m8G/jCBfEk3QuWRxEziPt6S1DGqWakA5HzPQGKeYw5ojA2ZK0fC5JZkdNzy5DEyHDZlnRXqIOAZSE3WVnbczppY25VP2fzG1rImhaSdzyntkOQEr+nk+s0G5PHpRwqJXcdr6dnCYzqDlMQrS9PSiVAWeskpUs9+EPLuOnrNhvBekkdS9DovG/R2T0h8oSxbk14rh02gar9O2vBboU7FObSEIQ3Oxd8yNviPNm00G31d1CERjX4OJdHoczMzspUEeT+3go2XzD5vbn3ivNpljxtrylZmhIiiJziZ/qoS201gFKzYqRXYVT6TJE81hLby2KsdBKtzcGDtYRujMNG3n4FOiloml+pZ+Samz/1mULpHddueG52y3egkEhjJNwR6NTwyVjT14tiBsMtVEUA0/OqB/nwWPP2hqfN3DjgjMR3DyJQtUFWJKmVmuxrG9PinTYxt8Wg3V6scRU1ioT/GQafFptlDcZtgs2ljtY3+HFCtPncOssURonBnmbtHialRaAyPQsPjI66sofihiAhEd2S+zkkxbdGUOnfwCKRzj59ncuTuB8fLGq7n2GmiOGKuSvzEJy4Q== X-Forefront-Antispam-Report: CIP:149.199.80.198; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:xir-pvapexch01.xlnx.xilinx.com; PTR:unknown-80-198.xilinx.com; CAT:NONE; SFS:(13230022)(4636009)(39860400002)(136003)(376002)(396003)(346002)(451199015)(40470700004)(36840700001)(46966006)(36756003)(53546011)(26005)(31686004)(356005)(7636003)(40460700003)(31696002)(70586007)(6916009)(82310400005)(54906003)(4326008)(8676002)(70206006)(41300700001)(40480700001)(36860700001)(82740400003)(83380400001)(47076005)(426003)(2616005)(186003)(478600001)(66574015)(2906002)(5660300002)(316002)(44832011)(336012)(9786002)(8936002)(50156003)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Sep 2022 08:09:31.7078 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8e425fb5-b1be-4fbe-49d9-08da9ba89d16 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.80.198]; Helo=[xir-pvapexch01.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: BN1NAM02FT045.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR02MB6742 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 9/21/2022 8:19 AM, Niklas Söderlund wrote: > Hello Ferruh, > > On 2022-09-20 19:01:47 +0100, Ferruh Yigit wrote: >> Instead of changing the log content and API with same patch, it is >> better to have them separate. > > I agree. > >> >> I prefer to convert them to proper log API first, and later fix the content >> of the log (to not update a line with wrong call). >> But order of patch preference is a soft one, if somehow other-way around >> (first fix the log content, later the API) makes your life easier, I am OK >> to go with that too (as long as both issues are fixed). > > In principle I agree with you here as well. In this case it would make > our life easier if we could do it the other way around. Reason being the > patch to convert the NFP PMD to the log API touch most files in the > driver and is at the tail of the 50+ patches we have in our internal > queue trying to get out. > > While it would be somewhat OK to post that patch separately I fear it > would create conflicts with the other patches in our queue. So I thin > either we drop this patch now and we pick it up at the end of our queue, > or we take this as is now. My preference would be to take it now, but > I'm not feeling strongly about it. > It is very trivial change, lets get it out of way. For log fix patch, I understand concern on the conflicts, but please don't forget to sent it out after functional patches are done.