From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Harold Huang <baymaxhuang@gmail.com>, <dev@dpdk.org>,
Ophir Munk <ophirmu@nvidia.com>,
Raslan Darawsheh <rasland@nvidia.com>
Cc: <stable@dpdk.org>, Keith Wiles <keith.wiles@intel.com>
Subject: Re: [PATCH] net/tap: do not include l2 header in gso size when compared with mtu
Date: Fri, 4 Mar 2022 16:30:44 +0000 [thread overview]
Message-ID: <a9641e82-67a7-46db-03ab-c7ba3ceac441@intel.com> (raw)
In-Reply-To: <20220228082724.1646930-1-baymaxhuang@gmail.com>
On 2/28/2022 8:27 AM, Harold Huang wrote:
> The gso size is calculated with all of the headers and payload. As a
> result, the l2 header should not be included when comparing gso size
> with mtu.
>
> Fixes: 050316a88313 ("net/tap: support TSO (TCP Segment Offload)")
> Cc: stable@dpdk.org
> Signed-off-by: Harold Huang <baymaxhuang@gmail.com>
> ---
> drivers/net/tap/rte_eth_tap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
> index f1b48cae82..2b561d232c 100644
> --- a/drivers/net/tap/rte_eth_tap.c
> +++ b/drivers/net/tap/rte_eth_tap.c
> @@ -731,7 +731,7 @@ pmd_tx_burst(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)
> mbuf_in->l4_len;
> tso_segsz = mbuf_in->tso_segsz + hdrs_len;
> if (unlikely(tso_segsz == hdrs_len) ||
> - tso_segsz > *txq->mtu) {
> + tso_segsz > *txq->mtu + mbuf_in->l2_len) {
> txq->stats.errs++;
> break;
> }
update emails for Ophir & Raslan.
Hi Ophir, since original code is from you can you please
help on review?
next prev parent reply other threads:[~2022-03-04 16:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-28 8:27 Harold Huang
2022-03-04 16:30 ` Ferruh Yigit [this message]
2022-03-08 14:35 ` Harold Huang
2022-05-20 22:08 ` Ferruh Yigit
2022-05-24 14:01 ` Ophir Munk
2023-10-17 16:47 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a9641e82-67a7-46db-03ab-c7ba3ceac441@intel.com \
--to=ferruh.yigit@intel.com \
--cc=baymaxhuang@gmail.com \
--cc=dev@dpdk.org \
--cc=keith.wiles@intel.com \
--cc=ophirmu@nvidia.com \
--cc=rasland@nvidia.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).