DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: pbhagavatula@marvell.com, jerinj@marvell.com,
	John McNamara <john.mcnamara@intel.com>,
	Marko Kovacevic <marko.kovacevic@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2 1/6] octeontx: update mbox definition to version 1.1.3
Date: Fri, 1 May 2020 16:40:58 +0100
Message-ID: <a9763f5f-21f8-ab7f-838d-990f7a76a452@intel.com> (raw)
In-Reply-To: <20191120034808.2760-2-pbhagavatula@marvell.com>

On 11/20/2019 3:48 AM, pbhagavatula@marvell.com wrote:
> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
> 
> Sync mail box data structures to version 1.1.3.
> Add mail box version verification and defer initializing octeontx
> devices if mail box version mismatches.
> Update OCTEON TX limitaion with max mempool size used.
> 
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> Reviewed-by: Jerin Jacob Kollanukkaran <jerinj@marvell.com>

<...>

> +static int
> +octeontx_check_mbox_version(struct mbox_intf_ver app_intf_ver,
> +			    struct mbox_intf_ver *intf_ver)
> +{
> +	struct mbox_intf_ver kernel_intf_ver = {0};
> +	struct octeontx_mbox_hdr hdr = {0};
> +	int result = 0;
> +
> +
> +	hdr.coproc = NO_COPROC;
> +	hdr.msg = RM_INTERFACE_VERSION;
> +
> +	result = octeontx_mbox_send(&hdr, &app_intf_ver, sizeof(app_intf_ver),
> +			&kernel_intf_ver, sizeof(kernel_intf_ver));
> +	if (result != sizeof(kernel_intf_ver)) {
> +		mbox_log_err("Could not send interface version. Err=%d. FuncErr=%d\n",
> +			     result, hdr.res_code);
> +		result = -EINVAL;
> +	}
> +
> +	if (intf_ver)
> +		*intf_ver = kernel_intf_ver;
> +
> +	if (app_intf_ver.platform != kernel_intf_ver.platform ||
> +			app_intf_ver.major != kernel_intf_ver.major ||
> +			app_intf_ver.minor != kernel_intf_ver.minor)
> +		result = -EINVAL;
> +
> +	return result;
> +}

Hi Pavan, Jerin,

This is an old code, but with a new version of a cross compiler [1], this is
generating a compiler note [2], can you please check if it has anything to fix
and should the note be silenced?

[1]
aarch64-linux-gcc.br_real (Buildroot 2020.02-00011-g7ea8a52) 9.3.0


[2] https://pastebin.com/gYfwM5kD

.../dpdk/drivers/common/octeontx/octeontx_mbox.c: In function
‘octeontx_check_mbox_version’:
.../dpdk/drivers/common/octeontx/octeontx_mbox.c:282:1: note: parameter passing
for argument of type ‘struct mbox_intf_ver’ changed in GCC 9.1
  282 | octeontx_check_mbox_version(struct mbox_intf_ver app_intf_ver,
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~

  reply	other threads:[~2020-05-01 15:41 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-20  3:48 [dpdk-dev] [PATCH v2 0/6] octeontx: sync with latest SDK pbhagavatula
2019-11-20  3:48 ` [dpdk-dev] [PATCH v2 1/6] octeontx: update mbox definition to version 1.1.3 pbhagavatula
2020-05-01 15:40   ` Ferruh Yigit [this message]
2019-11-20  3:48 ` [dpdk-dev] [PATCH v2 2/6] net/octeontx: add application domain validation pbhagavatula
2019-11-20  3:48 ` [dpdk-dev] [PATCH v2 3/6] net/octeontx: cleanup redudant mbox structs pbhagavatula
2019-11-20  3:48 ` [dpdk-dev] [PATCH v2 4/6] mempool/octeontx: add application domain validation pbhagavatula
2019-11-20  3:48 ` [dpdk-dev] [PATCH v2 5/6] event/octeontx: add appication " pbhagavatula
2019-11-20  3:48 ` [dpdk-dev] [PATCH v2 6/6] net/octeontx: make Rx queue offloads same as dev offloads pbhagavatula
2019-11-21  2:40 ` [dpdk-dev] [PATCH v2 0/6] octeontx: sync with latest SDK Jerin Jacob

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a9763f5f-21f8-ab7f-838d-990f7a76a452@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=dev@dpdk.org \
    --cc=jerinj@marvell.com \
    --cc=john.mcnamara@intel.com \
    --cc=marko.kovacevic@intel.com \
    --cc=pbhagavatula@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git