From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2B9BDA056A; Thu, 5 Mar 2020 23:28:10 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7ECD02BB8; Thu, 5 Mar 2020 23:28:09 +0100 (CET) Received: from mail-qk1-f195.google.com (mail-qk1-f195.google.com [209.85.222.195]) by dpdk.org (Postfix) with ESMTP id 938B62BA8 for ; Thu, 5 Mar 2020 23:28:07 +0100 (CET) Received: by mail-qk1-f195.google.com with SMTP id b5so467926qkh.8 for ; Thu, 05 Mar 2020 14:28:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=scylladb-com.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language; bh=ZigUrWsqz2KrqvmSMj65i3s9iB/Yj/QXvUWo6XhKEm0=; b=PXqzMniuGHLwg+B4Og5beF7vA3RdvJRxmWWGu0frWEvsVj+87FEw1PQyuW+iIWmqb/ f3qQt5DxREOj8U889LRv8aLP7CKoqvrbiKhpLsOT9+/urmaU0GDGpCg4ZDY0DuWCLhEb 8sTPTbCPbI0m0xhG/YMyH046kCTOoMwtNJo5aHzpcEgIw/xXg0sAhYuRR9eWWX7dDuDa oOqYE+/7cbMGwis0+y5qTbHe3+K87gPIGI1PEyOUsrZw1HoaxQY6/RFGg53Deg/6VMDX gmfpMuDfRdx9Q9o0qz7QvraPh4yZBtzaK/AG72Kzk25CDs5JyL97wd7YL4PQkiWGwger EdCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language; bh=ZigUrWsqz2KrqvmSMj65i3s9iB/Yj/QXvUWo6XhKEm0=; b=qeMosoBFrX5963YpR06zVivPzUwp2V0ODAa00j0qenkaLjkz9jBfLZxrFV+wap3g0M B1Kr8zJdqOAoEMFH+pMFY5l6g/v4+8q3a5qxsbn/AfhY55qB5ITObu+2taO3XEMAAU3k 4b6fs32haDJVGzCeaQnu4IQpwt0T6gprGl7X7LaOcjWhcoIMP9nhhx5NJGsBgvOw8JTH hIFs/gwyaDp6l3W4rTE9Ehd/tWLcu5eQD8StkXsAbLp5e1RrxFmNpfQrxFVAFCPXvkxj JPSnfIY0Bw0PJ8zo5NyhXw9BxEq8hBSlZmBF68L7/IDUX5Pfr1x3kRqeleBZ4LtIsztP Knkg== X-Gm-Message-State: ANhLgQ3BY2aRpeo1WRCs/D53UHntW66JrR6NAGlnF6OEkbJ8s8se2TeZ Wf6gK/ZPrO12PwK0BgJsmKgE1A== X-Google-Smtp-Source: ADFU+vvuJMFJIFN7Vy6Jjii1Cku+nMok8cOM6M0AGW6dXLzV4w9fn2d+xjLdF+jBF25LIloSW6Zp4Q== X-Received: by 2002:a37:ba05:: with SMTP id k5mr229501qkf.257.1583447286926; Thu, 05 Mar 2020 14:28:06 -0800 (PST) Received: from [192.168.1.103] (ool-2f14799e.dyn.optonline.net. [47.20.121.158]) by smtp.gmail.com with ESMTPSA id v30sm8826070qte.93.2020.03.05.14.28.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Mar 2020 14:28:06 -0800 (PST) To: dev@dpdk.org, evgenys@amazon.com, igorch@amazon.com References: <20200305222333.18784-1-vladz@scylladb.com> From: Vladislav Zolotarov Message-ID: Date: Thu, 5 Mar 2020 17:28:05 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200305222333.18784-1-vladz@scylladb.com> Content-Language: en-US Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v1] ena_ethdev: don't override the user provided queue length value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Igor, Evgeny, Please, review. On 3/5/20 5:23 PM, Vlad Zolotarov wrote: > There is a funny logic that seems to be outdated which tries to detect > a situation when a user requests a default size of the queue and > configures a device specific default value. > > This seems to be not in line with the DPDK current design that expects > the user to go via the rte_eth_dev_info_get() in order to get device > specific values. > > And if the user doesn't care it should pass 0 as a queue length and this > case is also being taken care of on the rte_eth level. > > Signed-off-by: Vlad Zolotarov > --- > drivers/net/ena/ena_ethdev.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c > index 665afee4f..bf632dee0 100644 > --- a/drivers/net/ena/ena_ethdev.c > +++ b/drivers/net/ena/ena_ethdev.c > @@ -1221,9 +1221,6 @@ static int ena_tx_queue_setup(struct rte_eth_dev *dev, > return -EINVAL; > } > > - if (nb_desc == RTE_ETH_DEV_FALLBACK_TX_RINGSIZE) > - nb_desc = adapter->tx_ring_size; > - > txq->port_id = dev->data->port_id; > txq->next_to_clean = 0; > txq->next_to_use = 0; > @@ -1292,9 +1289,6 @@ static int ena_rx_queue_setup(struct rte_eth_dev *dev, > return ENA_COM_FAULT; > } > > - if (nb_desc == RTE_ETH_DEV_FALLBACK_RX_RINGSIZE) > - nb_desc = adapter->rx_ring_size; > - > if (!rte_is_power_of_2(nb_desc)) { > PMD_DRV_LOG(ERR, > "Unsupported size of RX queue: %d is not a power of 2.\n",