From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EE656A0032; Fri, 29 Oct 2021 12:33:51 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F2EAA4111F; Fri, 29 Oct 2021 12:33:50 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 9C09C410E0 for ; Fri, 29 Oct 2021 12:33:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635503628; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ApZS8UKMUZ2JyD2GTmN/3b7Nt9rfGM1zpQq9wtNhenw=; b=cqLkM520ZWFXckXxouTlwyJivxHsLp0jm27+OsiiFF4om1TY64mMg9Bav8RvtQRrowQs67 eG8MrQ30BE+bK0+zrQDjtkd9RRCnCG5CpMRf7FiC6q6VxNkUy1CDuJypsUONlSHZoPAIYk e9Nl1k3nMwpwv055cOrnCAHv1sdtHqU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-287-nlVYu5RjMymQ8wpiMTUepQ-1; Fri, 29 Oct 2021 06:33:47 -0400 X-MC-Unique: nlVYu5RjMymQ8wpiMTUepQ-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 39E5A18414A4; Fri, 29 Oct 2021 10:33:46 +0000 (UTC) Received: from [10.39.208.19] (unknown [10.39.208.19]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D00D969FA1; Fri, 29 Oct 2021 10:33:44 +0000 (UTC) Message-ID: Date: Fri, 29 Oct 2021 12:33:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 To: Andrew Rybchenko , Chenbo Xia , Ivan Dyukov Cc: dev@dpdk.org, Ivan Ilchenko , stable@dpdk.org References: <20211022131755.932304-1-andrew.rybchenko@oktetlabs.ru> From: Maxime Coquelin In-Reply-To: <20211022131755.932304-1-andrew.rybchenko@oktetlabs.ru> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/virtio: fix link update in speed feature case X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/22/21 15:17, Andrew Rybchenko wrote: > From: Ivan Ilchenko > > Link update callback reports speed/duplex based on data > filled on device initialization. This is wrong in case of > VIRTIO_NET_F_SPEED_DUPLEX is negotiated since link could > be down at this time. Fix this function to actually > update the HW data in this case with respect to the fact > that specifying speed via devarg is a highest priority. > > Fixes: 1357b4b36246 ("net/virtio: support Virtio link speed feature") > Cc: stable@dpdk.org > > Signed-off-by: Ivan Ilchenko > Signed-off-by: Andrew Rybchenko > --- > drivers/net/virtio/virtio.h | 5 ++++ > drivers/net/virtio/virtio_ethdev.c | 47 +++++++++++++++++++++--------- > 2 files changed, 39 insertions(+), 13 deletions(-) > Applied to dpdk-next-virtio/main with suggested change. Thanks, Maxime