From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4A74EA0533; Fri, 24 Jan 2020 16:51:21 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 932212BDB; Fri, 24 Jan 2020 16:51:20 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 66514235 for ; Fri, 24 Jan 2020 16:51:19 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Jan 2020 07:51:18 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,358,1574150400"; d="scan'208";a="251318920" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.237.220.124]) ([10.237.220.124]) by fmsmga004.fm.intel.com with ESMTP; 24 Jan 2020 07:51:15 -0800 To: Bruce Richardson , dev@dpdk.org References: <20200124153755.13939-1-bruce.richardson@intel.com> <20200124153755.13939-3-bruce.richardson@intel.com> From: "Burakov, Anatoly" Message-ID: Date: Fri, 24 Jan 2020 15:51:16 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200124153755.13939-3-bruce.richardson@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 2/2] build: remove warnings for builds with icc X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 24-Jan-20 3:37 PM, Bruce Richardson wrote: > While icc builds without the "werror" setting build successfully, there are > a lot of warnings. To make the output cleaner, and to allow building with > warnings enabled, we can add a list of warning ids to ignore. > > Signed-off-by: Bruce Richardson > --- > config/meson.build | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/config/meson.build b/config/meson.build > index 28a57f56f..6c46767e3 100644 > --- a/config/meson.build > +++ b/config/meson.build > @@ -197,6 +197,12 @@ if not dpdk_conf.get('RTE_ARCH_64') > # for 32-bit, don't warn about casting a 32-bit pointer to 64-bit int - it's fine!! > warning_flags += '-Wno-pointer-to-int-cast' > endif > +if cc.get_id() == 'intel' > + warning_ids = [188, 2203, 2279, 2557, 3179, 3656] Maybe worth it to add short warning descriptions in comments? e.g. # 188: unused blah # 2203: wrong foo > + foreach i:warning_ids > + warning_flags += '-diag-disable=@0@'.format(i) > + endforeach > +endif > foreach arg: warning_flags > if cc.has_argument(arg) > add_project_arguments(arg, language: 'c') > -- Thanks, Anatoly