DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Singh, Jasvinder" <jasvinder.singh@intel.com>,
	"Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/softnic: remove useless address check
Date: Wed, 13 Oct 2021 22:45:35 +0100	[thread overview]
Message-ID: <a9e4517a-cce1-a13e-5b19-9bcb2cb8f8cc@intel.com> (raw)
In-Reply-To: <BN9PR11MB52584C846100C93C8EE48681E0B79@BN9PR11MB5258.namprd11.prod.outlook.com>

On 10/13/2021 4:54 PM, Singh, Jasvinder wrote:
> 
> 
>> -----Original Message-----
>> From: Yigit, Ferruh <ferruh.yigit@intel.com>
>> Sent: Monday, October 4, 2021 6:27 PM
>> To: Singh, Jasvinder <jasvinder.singh@intel.com>; Dumitrescu, Cristian
>> <cristian.dumitrescu@intel.com>
>> Cc: Yigit, Ferruh <ferruh.yigit@intel.com>; dev@dpdk.org
>> Subject: [PATCH] net/softnic: remove useless address check
>>
>> Reported by "gcc (GCC) 12.0.0 20211003 (experimental)":
>>
>> ./drivers/net/softnic/rte_eth_softnic_cli.c:
>> 	In function ‘tmgr_hierarchy_default’:
>> ./drivers/net/softnic/rte_eth_softnic_cli.c:634:73:
>> 	error: the comparison will always evaluate as ‘true’ for the
>> 	address of ‘tc_valid’ will never be NULL [-Werror=address]
>>    634 | (&params->shared_shaper_id.tc_valid[0]) ? 1 : 0,
>>        |                                         ^
>>
>> Fixing it by removing useless check.
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>

     Fixes: 1af2dc5111ce ("net/softnic: add command for default tmgr hierarchy")
     Fixes: 5eb676d74fc8 ("net/softnic: add config flexibility to TM")
     Cc: stable@dpdk.org
     
     Acked-by: Jasvinder Singh <jasvinder.singh@intel.com>

Applied to dpdk-next-net/main, thanks.

      reply	other threads:[~2021-10-13 21:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-04 17:27 Ferruh Yigit
2021-10-13 15:54 ` Singh, Jasvinder
2021-10-13 21:45   ` Ferruh Yigit [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a9e4517a-cce1-a13e-5b19-9bcb2cb8f8cc@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=cristian.dumitrescu@intel.com \
    --cc=dev@dpdk.org \
    --cc=jasvinder.singh@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).