From: Bruce Richardson <bruce.richardson@intel.com>
To: "Morten Brørup" <mb@smartsharesystems.com>
Cc: <dev@dpdk.org>
Subject: Re: [PATCH] net/i40e: Fast release optimizations
Date: Wed, 25 Jun 2025 11:47:54 +0100 [thread overview]
Message-ID: <aFvT2qlUuS9_Tgcc@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <20250624061238.89259-1-mb@smartsharesystems.com>
On Tue, Jun 24, 2025 at 06:12:38AM +0000, Morten Brørup wrote:
> When fast releasing mbufs, the mbufs are not accessed, so do not prefetch
> them.
> This saves a mbuf load operation for each fast released TX mbuf.
>
> When fast release of mbufs is enabled for a TX queue, cache the mbuf
> mempool pointer in the TX queue structure.
> This saves one mbuf load operation for each burst of fast released TX
> mbufs.
>
> The txep->mbuf pointer is not used after the mbuf has been freed, so do
> not reset the pointer.
> This saves a txep store operation for each TX mbuf freed.
>
> Signed-off-by: Morten Brørup <mb@smartsharesystems.com>
> ---
> drivers/net/intel/common/tx.h | 5 +++
> .../i40e/i40e_recycle_mbufs_vec_common.c | 4 +-
> drivers/net/intel/i40e/i40e_rxtx.c | 39 ++++++++++---------
> 3 files changed, 28 insertions(+), 20 deletions(-)
>
Thanks, Morten. This optimization probably applies other places in our
drivers too. I'll look at this patch - and where else it can apply - for
25.11, since we are nearing the end of the 25.07 release cycle.
/Bruce
next prev parent reply other threads:[~2025-06-25 10:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-24 6:12 Morten Brørup
2025-06-25 10:47 ` Bruce Richardson [this message]
2025-06-25 11:15 ` Morten Brørup
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aFvT2qlUuS9_Tgcc@bricha3-mobl1.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=mb@smartsharesystems.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).