Re: [PATCH v3 16/18] test/power: fix tests without power drivers

[Bruce Richardson <bruce.richardson@intel.com>]

On Tue, Jul 08, 2025 at 02:28:20PM +0200, David Marchand wrote:
> In the absence of drivers, skip tests instead of failing.
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
>  app/test/meson.build | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/app/test/meson.build b/app/test/meson.build
> index 7d38f51918..79d635b42b 100644
> --- a/app/test/meson.build
> +++ b/app/test/meson.build
> @@ -145,10 +145,12 @@ source_file_deps = {
>      'test_pmd_ring.c': ['net_ring', 'ethdev', 'bus_vdev'],
>      'test_pmd_ring_perf.c': ['ethdev', 'net_ring', 'bus_vdev'],
>      'test_pmu.c': ['pmu'],
> -    'test_power.c': ['power'],
> -    'test_power_cpufreq.c': ['power'],
> -    'test_power_intel_uncore.c': ['power'],
> -    'test_power_kvm_vm.c': ['power'],
> +    'test_power.c': ['power', 'power_acpi', 'power_kvm_vm', 'power_intel_pstate',
> +        'power_amd_pstate', 'power_cppc'],

Is this better done at build time or at runtime? Unfortunately we don't
have support for "or" operations on dependencies, so if even one driver is
missing the whole test file will not be built. I would think it better to
look for the drivers at runtime and return TEST_SKIPPED if not present.
WDYT?

> +    'test_power_cpufreq.c': ['power', 'power_acpi', 'power_intel_pstate', 'power_amd_pstate',
> +        'power_cppc'],
> +    'test_power_intel_uncore.c': ['power', 'power_intel_uncore'],
> +    'test_power_kvm_vm.c': ['power', 'power_kvm_vm'],
>      'test_prefetch.c': [],
>      'test_ptr_compress.c': ['ptr_compress'],
>      'test_rand_perf.c': [],
> -- 
> 2.50.0
>