[PATCH] net/ixgbe: fix sctp mask in flow director

[PATCH] net/ixgbe: fix sctp mask in flow director

[Yuan Wang]

Since the default value of the port mask is set to 0, the port mask does
not change in some cases when creating SCTP flow rules, which results in
incorrect L4P register configuration.

This patch fixes this issue by setting the mask to 0xffff in these cases.

Fixes: c81daae2383a (net/ixgbe: fix port mask default value in filter)
Cc: stable@dpdk.org

Signed-off-by: Yuan Wang <yuanx.wang@intel.com>
---
 drivers/net/intel/ixgbe/ixgbe_flow.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/intel/ixgbe/ixgbe_flow.c b/drivers/net/intel/ixgbe/ixgbe_flow.c
index 6278646720..9f2e470ad9 100644
--- a/drivers/net/intel/ixgbe/ixgbe_flow.c
+++ b/drivers/net/intel/ixgbe/ixgbe_flow.c
@@ -2161,6 +2161,8 @@ ixgbe_parse_fdir_filter_normal(struct rte_eth_dev *dev,
 					item, "Not supported by fdir filter");
 				return -rte_errno;
 			}
+			rule->mask.src_port_mask = 0xffff;
+			rule->mask.dst_port_mask = 0xffff;
 		}
 
 		item = next_no_fuzzy_pattern(pattern, item);
-- 
2.47.1

Re: [PATCH] net/ixgbe: fix sctp mask in flow director

[Bruce Richardson]

On Fri, Jun 27, 2025 at 04:59:53PM +0800, Yuan Wang wrote:
> Since the default value of the port mask is set to 0, the port mask does
> not change in some cases when creating SCTP flow rules, which results in
> incorrect L4P register configuration.
> 
> This patch fixes this issue by setting the mask to 0xffff in these cases.
> 
> Fixes: c81daae2383a (net/ixgbe: fix port mask default value in filter)
> Cc: stable@dpdk.org
> 
> Signed-off-by: Yuan Wang <yuanx.wang@intel.com>
> ---
>  drivers/net/intel/ixgbe/ixgbe_flow.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/net/intel/ixgbe/ixgbe_flow.c b/drivers/net/intel/ixgbe/ixgbe_flow.c
> index 6278646720..9f2e470ad9 100644
> --- a/drivers/net/intel/ixgbe/ixgbe_flow.c
> +++ b/drivers/net/intel/ixgbe/ixgbe_flow.c
> @@ -2161,6 +2161,8 @@ ixgbe_parse_fdir_filter_normal(struct rte_eth_dev *dev,
>  					item, "Not supported by fdir filter");
>  				return -rte_errno;
>  			}
> +			rule->mask.src_port_mask = 0xffff;
> +			rule->mask.dst_port_mask = 0xffff;
>  		}
>  

Hi,

can you give a quick example of how to demonstrate the issue here, so I can
test the patch? Presumably without this patch some packets are incorrectly
classified/filtered based on the rte_flow rules?

Thanks,
/Bruce