* [PATCH] net/ixgbe: fix sctp mask in flow director
@ 2025-06-27 8:59 Yuan Wang
2025-06-30 9:10 ` Bruce Richardson
0 siblings, 1 reply; 2+ messages in thread
From: Yuan Wang @ 2025-06-27 8:59 UTC (permalink / raw)
To: anatoly.burakov, vladimir.medvedkin; +Cc: dev, Yuan Wang, stable
Since the default value of the port mask is set to 0, the port mask does
not change in some cases when creating SCTP flow rules, which results in
incorrect L4P register configuration.
This patch fixes this issue by setting the mask to 0xffff in these cases.
Fixes: c81daae2383a (net/ixgbe: fix port mask default value in filter)
Cc: stable@dpdk.org
Signed-off-by: Yuan Wang <yuanx.wang@intel.com>
---
drivers/net/intel/ixgbe/ixgbe_flow.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/intel/ixgbe/ixgbe_flow.c b/drivers/net/intel/ixgbe/ixgbe_flow.c
index 6278646720..9f2e470ad9 100644
--- a/drivers/net/intel/ixgbe/ixgbe_flow.c
+++ b/drivers/net/intel/ixgbe/ixgbe_flow.c
@@ -2161,6 +2161,8 @@ ixgbe_parse_fdir_filter_normal(struct rte_eth_dev *dev,
item, "Not supported by fdir filter");
return -rte_errno;
}
+ rule->mask.src_port_mask = 0xffff;
+ rule->mask.dst_port_mask = 0xffff;
}
item = next_no_fuzzy_pattern(pattern, item);
--
2.47.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] net/ixgbe: fix sctp mask in flow director
2025-06-27 8:59 [PATCH] net/ixgbe: fix sctp mask in flow director Yuan Wang
@ 2025-06-30 9:10 ` Bruce Richardson
0 siblings, 0 replies; 2+ messages in thread
From: Bruce Richardson @ 2025-06-30 9:10 UTC (permalink / raw)
To: Yuan Wang; +Cc: anatoly.burakov, vladimir.medvedkin, dev, stable
On Fri, Jun 27, 2025 at 04:59:53PM +0800, Yuan Wang wrote:
> Since the default value of the port mask is set to 0, the port mask does
> not change in some cases when creating SCTP flow rules, which results in
> incorrect L4P register configuration.
>
> This patch fixes this issue by setting the mask to 0xffff in these cases.
>
> Fixes: c81daae2383a (net/ixgbe: fix port mask default value in filter)
> Cc: stable@dpdk.org
>
> Signed-off-by: Yuan Wang <yuanx.wang@intel.com>
> ---
> drivers/net/intel/ixgbe/ixgbe_flow.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/intel/ixgbe/ixgbe_flow.c b/drivers/net/intel/ixgbe/ixgbe_flow.c
> index 6278646720..9f2e470ad9 100644
> --- a/drivers/net/intel/ixgbe/ixgbe_flow.c
> +++ b/drivers/net/intel/ixgbe/ixgbe_flow.c
> @@ -2161,6 +2161,8 @@ ixgbe_parse_fdir_filter_normal(struct rte_eth_dev *dev,
> item, "Not supported by fdir filter");
> return -rte_errno;
> }
> + rule->mask.src_port_mask = 0xffff;
> + rule->mask.dst_port_mask = 0xffff;
> }
>
Hi,
can you give a quick example of how to demonstrate the issue here, so I can
test the patch? Presumably without this patch some packets are incorrectly
classified/filtered based on the rte_flow rules?
Thanks,
/Bruce
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-06-30 9:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-06-27 8:59 [PATCH] net/ixgbe: fix sctp mask in flow director Yuan Wang
2025-06-30 9:10 ` Bruce Richardson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).