From: Bruce Richardson <bruce.richardson@intel.com>
To: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Cc: <dev@dpdk.org>, <stable@dpdk.org>,
Qi Zhang <qi.z.zhang@intel.com>,
Mingjin Ye <mingjinx.ye@intel.com>
Subject: Re: [PATCH] net/ice: fix inconsistency in Rx queue VLAN tag placement
Date: Tue, 1 Jul 2025 13:43:34 +0100 [thread overview]
Message-ID: <aGPX9jCnKADwSWB6@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <c58479e7-9a2a-4b8f-b9f3-0b69600aaf0b@intel.com>
On Fri, Jun 27, 2025 at 04:31:20PM +0200, Burakov, Anatoly wrote:
> On 6/27/2025 3:52 PM, Bruce Richardson wrote:
> > When VLAN or QinQ stripping is enabled in the ice driver, an
> > inconsistency was observed between the placement of the VLAN tag in the
> > descriptors of the final Rx queue (irrespective of the number of queues)
> > vs descriptors of all other queues. This inconsistency was due to the
> > fact that the driver - when updating l2tsel (L2 tag selection) field -
> > used the queue id, rather than the register index for the queue. Queue 0
> > is normally HW queue 1, etc., meaning the final queue never had its
> > field updated.
> >
> > Fixes: de5da9d16430 ("net/ice: support double VLAN")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > ---
>
> Acked-By: Anatoly Burakov <anatoly.burakov@intel.com>
>
Applied to dpdk-next-net-intel
/Bruce
prev parent reply other threads:[~2025-07-01 12:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-27 13:52 Bruce Richardson
2025-06-27 14:31 ` Burakov, Anatoly
2025-07-01 12:43 ` Bruce Richardson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aGPX9jCnKADwSWB6@bricha3-mobl1.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=mingjinx.ye@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).