From: Bruce Richardson <bruce.richardson@intel.com>
To: Yuan Wang <yuanx.wang@intel.com>
Cc: <anatoly.burakov@intel.com>, <vladimir.medvedkin@intel.com>,
<dev@dpdk.org>, <stable@dpdk.org>
Subject: Re: [PATCH] net/ixgbe: fix SCTP port support on E610
Date: Thu, 7 Aug 2025 15:43:31 +0100 [thread overview]
Message-ID: <aJS7kySPEL1-ksp5@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <20250718085335.648078-1-yuanx.wang@intel.com>
On Fri, Jul 18, 2025 at 04:53:35PM +0800, Yuan Wang wrote:
> E610 supports SCTP port in FDIR filter, so add it to the support list.
>
> Fixes: 86e19565f5e2 (net/ixgbe: fix SCTP port support)
When this commit was made back in 2017, there was no E610 to support, so
therefore it wasn't the broken commit. Putting fixline of 316637762a5f
("net/ixgbe/base: enable E610 device"), to ensure that this gets backported
only onto those releases which have E610 support.
> Cc: stable@dpdk.org
>
> Signed-off-by: Yuan Wang <yuanx.wang@intel.com>
> ---
> drivers/net/intel/ixgbe/ixgbe_flow.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/intel/ixgbe/ixgbe_flow.c b/drivers/net/intel/ixgbe/ixgbe_flow.c
> index 6278646720..1bf0af330f 100644
> --- a/drivers/net/intel/ixgbe/ixgbe_flow.c
> +++ b/drivers/net/intel/ixgbe/ixgbe_flow.c
> @@ -2114,7 +2114,8 @@ ixgbe_parse_fdir_filter_normal(struct rte_eth_dev *dev,
> /* only x550 family only support sctp port */
This comment needs update now too, since it's not just X550 parts. Will
update on apply.
> if (hw->mac.type == ixgbe_mac_X550 ||
> hw->mac.type == ixgbe_mac_X550EM_x ||
> - hw->mac.type == ixgbe_mac_X550EM_a) {
> + hw->mac.type == ixgbe_mac_X550EM_a ||
> + hw->mac.type == ixgbe_mac_E610) {
> /**
> * Only care about src & dst ports,
> * others should be masked.
> --
> 2.47.1
>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Patch applied to dpdk-next-net-intel.
Thanks,
/Bruce
prev parent reply other threads:[~2025-08-07 14:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-18 8:53 Yuan Wang
2025-08-07 14:43 ` Bruce Richardson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aJS7kySPEL1-ksp5@bricha3-mobl1.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=vladimir.medvedkin@intel.com \
--cc=yuanx.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).