DPDK patches and discussions
 help / color / mirror / Atom feed
* [PATCH] net/ixgbe: fix SCTP port support on E610
@ 2025-07-18  8:53 Yuan Wang
  2025-08-07 14:43 ` Bruce Richardson
  0 siblings, 1 reply; 2+ messages in thread
From: Yuan Wang @ 2025-07-18  8:53 UTC (permalink / raw)
  To: anatoly.burakov, vladimir.medvedkin; +Cc: dev, Yuan Wang, stable

E610 supports SCTP port in FDIR filter, so add it to the support list.

Fixes: 86e19565f5e2 (net/ixgbe: fix SCTP port support)
Cc: stable@dpdk.org

Signed-off-by: Yuan Wang <yuanx.wang@intel.com>
---
 drivers/net/intel/ixgbe/ixgbe_flow.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/intel/ixgbe/ixgbe_flow.c b/drivers/net/intel/ixgbe/ixgbe_flow.c
index 6278646720..1bf0af330f 100644
--- a/drivers/net/intel/ixgbe/ixgbe_flow.c
+++ b/drivers/net/intel/ixgbe/ixgbe_flow.c
@@ -2114,7 +2114,8 @@ ixgbe_parse_fdir_filter_normal(struct rte_eth_dev *dev,
 		/* only x550 family only support sctp port */
 		if (hw->mac.type == ixgbe_mac_X550 ||
 		    hw->mac.type == ixgbe_mac_X550EM_x ||
-		    hw->mac.type == ixgbe_mac_X550EM_a) {
+		    hw->mac.type == ixgbe_mac_X550EM_a ||
+		    hw->mac.type == ixgbe_mac_E610) {
 			/**
 			 * Only care about src & dst ports,
 			 * others should be masked.
-- 
2.47.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] net/ixgbe: fix SCTP port support on E610
  2025-07-18  8:53 [PATCH] net/ixgbe: fix SCTP port support on E610 Yuan Wang
@ 2025-08-07 14:43 ` Bruce Richardson
  0 siblings, 0 replies; 2+ messages in thread
From: Bruce Richardson @ 2025-08-07 14:43 UTC (permalink / raw)
  To: Yuan Wang; +Cc: anatoly.burakov, vladimir.medvedkin, dev, stable

On Fri, Jul 18, 2025 at 04:53:35PM +0800, Yuan Wang wrote:
> E610 supports SCTP port in FDIR filter, so add it to the support list.
> 
> Fixes: 86e19565f5e2 (net/ixgbe: fix SCTP port support)

When this commit was made back in 2017, there was no E610 to support, so
therefore it wasn't the broken commit. Putting fixline of 316637762a5f
("net/ixgbe/base: enable E610 device"), to ensure that this gets backported
only onto those releases which have E610 support.

> Cc: stable@dpdk.org
> 
> Signed-off-by: Yuan Wang <yuanx.wang@intel.com>
> ---
>  drivers/net/intel/ixgbe/ixgbe_flow.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/intel/ixgbe/ixgbe_flow.c b/drivers/net/intel/ixgbe/ixgbe_flow.c
> index 6278646720..1bf0af330f 100644
> --- a/drivers/net/intel/ixgbe/ixgbe_flow.c
> +++ b/drivers/net/intel/ixgbe/ixgbe_flow.c
> @@ -2114,7 +2114,8 @@ ixgbe_parse_fdir_filter_normal(struct rte_eth_dev *dev,
>  		/* only x550 family only support sctp port */

This comment needs update now too, since it's not just X550 parts. Will
update on apply.

>  		if (hw->mac.type == ixgbe_mac_X550 ||
>  		    hw->mac.type == ixgbe_mac_X550EM_x ||
> -		    hw->mac.type == ixgbe_mac_X550EM_a) {
> +		    hw->mac.type == ixgbe_mac_X550EM_a ||
> +		    hw->mac.type == ixgbe_mac_E610) {
>  			/**
>  			 * Only care about src & dst ports,
>  			 * others should be masked.
> -- 
> 2.47.1
> 
Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Patch applied to dpdk-next-net-intel.

Thanks,
/Bruce

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-08-07 14:43 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-07-18  8:53 [PATCH] net/ixgbe: fix SCTP port support on E610 Yuan Wang
2025-08-07 14:43 ` Bruce Richardson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).