DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: Yijun Geng <1204565380@qq.com>
Cc: <dev@dpdk.org>
Subject: Re: [PATCH] net/i40e: support GTP in tunnel parameters parsing
Date: Fri, 8 Aug 2025 10:25:43 +0100	[thread overview]
Message-ID: <aJXClxDQiVORnCcj@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <tencent_51BB4368612AB46A24214A53B97AD8A3CE09@qq.com>

On Wed, Jul 09, 2025 at 04:32:14PM +0800, Yijun Geng wrote:
> i40e I40E_TX_OFFLOAD_MASK indicates that all tunnel types are supported,
> but gtp type is not considered in i40e_parse_tunneling_params(),
> tunneling parameter: L4TUNLEN is not set. During TX checksum offloading,
> the incorrect L3 header offset was used when calculating the inner IP
> checksum,  resulting in modifying the length field of the GTP header.
> 
> Signed-off-by: Yijun Geng <1204565380@qq.com>
> ---
>  drivers/net/intel/i40e/i40e_rxtx.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/intel/i40e/i40e_rxtx.c b/drivers/net/intel/i40e/i40e_rxtx.c
> index aba3c11ee5..d59d81474e 100644
> --- a/drivers/net/intel/i40e/i40e_rxtx.c
> +++ b/drivers/net/intel/i40e/i40e_rxtx.c
> @@ -274,6 +274,7 @@ i40e_parse_tunneling_params(uint64_t ol_flags,
>  		break;
>  	case RTE_MBUF_F_TX_TUNNEL_VXLAN:
>  	case RTE_MBUF_F_TX_TUNNEL_GENEVE:
> +	case RTE_MBUF_F_TX_TUNNEL_GTP:
>  		*cd_tunneling |= I40E_TXD_CTX_UDP_TUNNELING;
>  		break;
>  	case RTE_MBUF_F_TX_TUNNEL_GRE:
> -- 

Seems ok to me.

Acked-by: Bruce Richardson <bruce.richardson@intel.com>


  reply	other threads:[~2025-08-08  9:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-09  8:32 Yijun Geng
2025-08-08  9:25 ` Bruce Richardson [this message]
2025-08-08  9:33   ` Bruce Richardson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aJXClxDQiVORnCcj@bricha3-mobl1.ger.corp.intel.com \
    --to=bruce.richardson@intel.com \
    --cc=1204565380@qq.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).