* [PATCH] net/cpfl: fix display of commands in the docs
@ 2025-10-03 14:58 Bruce Richardson
2025-10-07 7:47 ` Shetty, Praveen
0 siblings, 1 reply; 3+ messages in thread
From: Bruce Richardson @ 2025-10-03 14:58 UTC (permalink / raw)
To: dev; +Cc: Bruce Richardson, stable, Praveen Shetty, Qi Zhang, Yuying Zhang
The literal text of the commands to use were not displayed properly
because of a double ":" at the end of the preceding text, meaning that
the ".. code-block" marker got recognised as the literal text to
include. Change the double colon to single, and also indent the line
continuation in the multi-line flow-create command.
Fixes: 03f976012304 ("net/cpfl: adapt FXP to flow engine")
Cc: stable@dpdk.org
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
doc/guides/nics/cpfl.rst | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/doc/guides/nics/cpfl.rst b/doc/guides/nics/cpfl.rst
index 54a3015aa0..bc42c524ea 100644
--- a/doc/guides/nics/cpfl.rst
+++ b/doc/guides/nics/cpfl.rst
@@ -218,14 +218,14 @@ low level hardware resources.
dpdk-testpmd -l 0,1 -a 0000:af:00.6,vport=[0-1],flow_parser="refpkg.json" -- -i
#. Create one flow to forward ETH-IPV4-TCP from I/O port to a local(CPF's) vport. Flow should be created on
- vport X. Group M should match fxp module. Action port_representor Y means forward packet to local vport Y::
+ vport X. Group M should match fxp module. Action port_representor Y means forward packet to local vport Y:
.. code-block:: console
flow create X ingress group M pattern eth dst is 00:01:00:00:03:14 / ipv4 src is 192.168.0.1 \
- dst is 192.168.0.2 / tcp / end actions port_representor port_id Y / end
+ dst is 192.168.0.2 / tcp / end actions port_representor port_id Y / end
-#. Send a matched packet, and it should be displayed on PMD::
+#. Send a matched packet, and it should be displayed on PMD:
.. code-block:: console
--
2.48.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] net/cpfl: fix display of commands in the docs
2025-10-03 14:58 [PATCH] net/cpfl: fix display of commands in the docs Bruce Richardson
@ 2025-10-07 7:47 ` Shetty, Praveen
2025-10-08 8:13 ` Bruce Richardson
0 siblings, 1 reply; 3+ messages in thread
From: Shetty, Praveen @ 2025-10-07 7:47 UTC (permalink / raw)
To: Richardson, Bruce, dev; +Cc: stable, Zhang, Qi Z, Yuying Zhang
The literal text of the commands to use were not displayed properly because of a double ":" at the end of the preceding text, meaning that the ".. code-block" marker got recognised as the literal text to include. Change the double colon to single, and also indent the line continuation in the multi-line flow-create command.
Fixes: 03f976012304 ("net/cpfl: adapt FXP to flow engine")
Cc: stable@dpdk.org
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
doc/guides/nics/cpfl.rst | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/doc/guides/nics/cpfl.rst b/doc/guides/nics/cpfl.rst index 54a3015aa0..bc42c524ea 100644
--- a/doc/guides/nics/cpfl.rst
+++ b/doc/guides/nics/cpfl.rst
@@ -218,14 +218,14 @@ low level hardware resources.
dpdk-testpmd -l 0,1 -a 0000:af:00.6,vport=[0-1],flow_parser="refpkg.json" -- -i
#. Create one flow to forward ETH-IPV4-TCP from I/O port to a local(CPF's) vport. Flow should be created on
- vport X. Group M should match fxp module. Action port_representor Y means forward packet to local vport Y::
+ vport X. Group M should match fxp module. Action port_representor Y means forward packet to local vport Y:
.. code-block:: console
flow create X ingress group M pattern eth dst is 00:01:00:00:03:14 / ipv4 src is 192.168.0.1 \
- dst is 192.168.0.2 / tcp / end actions port_representor port_id Y / end
+ dst is 192.168.0.2 / tcp / end actions port_representor
+ port_id Y / end
-#. Send a matched packet, and it should be displayed on PMD::
+#. Send a matched packet, and it should be displayed on PMD:
.. code-block:: console
Looks good to me - thanks Bruce!
Acked-by: Praveen Shetty <praveen.shetty@intel.com>
--
2.48.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net/cpfl: fix display of commands in the docs
2025-10-07 7:47 ` Shetty, Praveen
@ 2025-10-08 8:13 ` Bruce Richardson
0 siblings, 0 replies; 3+ messages in thread
From: Bruce Richardson @ 2025-10-08 8:13 UTC (permalink / raw)
To: Shetty, Praveen; +Cc: dev, stable, Zhang, Qi Z, Yuying Zhang
On Tue, Oct 07, 2025 at 08:47:23AM +0100, Shetty, Praveen wrote:
> The literal text of the commands to use were not displayed properly because of a double ":" at the end of the preceding text, meaning that the ".. code-block" marker got recognised as the literal text to include. Change the double colon to single, and also indent the line continuation in the multi-line flow-create command.
>
> Fixes: 03f976012304 ("net/cpfl: adapt FXP to flow engine")
> Cc: stable@dpdk.org
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> doc/guides/nics/cpfl.rst | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> Acked-by: Praveen Shetty <praveen.shetty@intel.com>
>
Applied to next-net-intel.
/Bruce
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-10-08 8:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-10-03 14:58 [PATCH] net/cpfl: fix display of commands in the docs Bruce Richardson
2025-10-07 7:47 ` Shetty, Praveen
2025-10-08 8:13 ` Bruce Richardson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).