DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: Shaiq Wani <shaiq.wani@intel.com>
Cc: <dev@dpdk.org>, <aman.deep.singh@intel.com>, <anatoly.burakov@intel.com>
Subject: Re: [PATCH] net/idpf: correct the enum constant name typo
Date: Wed, 8 Oct 2025 09:28:27 +0100	[thread overview]
Message-ID: <aOYgq56i7mnEohXn@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <20251007040436.2924355-1-shaiq.wani@intel.com>

On Tue, Oct 07, 2025 at 09:34:36AM +0530, Shaiq Wani wrote:
> Correct the typo in the idpf_rx_func_type enum by renaming
> IDPF_RX_SINGLQ_AVX512 to IDPF_RX_SINGLEQ_AVX512 for consistency
> and improved readability.
> 
> Signed-off-by: Shaiq Wani <shaiq.wani@intel.com>

Fixes, even minor ones like this, should always start the patch title with
the word "fix" rather than "correct", for a number of reasons.
a) for consistency with other patches
b) to mark the patch as a bug fix for possible backporting
c) so that tooling such as check-git-log recognise it as a fix and run
additional checks for things like a "fixes" line with correct commit
reference.

Point "c" is especially relevant here. :-)

Fixes: 12b1c2901761 ("net/idpf: use common Rx path selection infrastructure")

Patch applied to next-net-intel with title rewording and fixline applied.

/Bruce

> ---
>  drivers/net/intel/idpf/idpf_common_device.h | 2 +-
>  drivers/net/intel/idpf/idpf_common_rxtx.c   | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/intel/idpf/idpf_common_device.h b/drivers/net/intel/idpf/idpf_common_device.h
> index 3b95d519c6..09d59dd0c1 100644
> --- a/drivers/net/intel/idpf/idpf_common_device.h
> +++ b/drivers/net/intel/idpf/idpf_common_device.h
> @@ -50,7 +50,7 @@ enum idpf_rx_func_type {
>  	IDPF_RX_SINGLEQ_SCATTERED,
>  	IDPF_RX_SINGLEQ_AVX2,
>  	IDPF_RX_AVX512,
> -	IDPF_RX_SINGLQ_AVX512,
> +	IDPF_RX_SINGLEQ_AVX512,
>  	IDPF_RX_MAX
>  };
>  
> diff --git a/drivers/net/intel/idpf/idpf_common_rxtx.c b/drivers/net/intel/idpf/idpf_common_rxtx.c
> index a2b8c372d6..5a1c1561e5 100644
> --- a/drivers/net/intel/idpf/idpf_common_rxtx.c
> +++ b/drivers/net/intel/idpf/idpf_common_rxtx.c
> @@ -1663,7 +1663,7 @@ const struct ci_rx_path_info idpf_rx_path_infos[] = {
>  		.features = {
>  			.rx_offloads = IDPF_RX_VECTOR_OFFLOADS,
>  			.simd_width = RTE_VECT_SIMD_512}},
> -	[IDPF_RX_SINGLQ_AVX512] = {
> +	[IDPF_RX_SINGLEQ_AVX512] = {
>  		.pkt_burst = idpf_dp_singleq_recv_pkts_avx512,
>  		.info = "Single AVX512 Vector",
>  		.features = {
> -- 
> 2.34.1
> 

      parent reply	other threads:[~2025-10-08  8:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-07  4:04 Shaiq Wani
2025-10-07 12:46 ` Burakov, Anatoly
2025-10-08  8:28 ` Bruce Richardson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aOYgq56i7mnEohXn@bricha3-mobl1.ger.corp.intel.com \
    --to=bruce.richardson@intel.com \
    --cc=aman.deep.singh@intel.com \
    --cc=anatoly.burakov@intel.com \
    --cc=dev@dpdk.org \
    --cc=shaiq.wani@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).