Re: [PATCH v5 0/3] Enable DCB/PFC support for ICE PMD

[Bruce Richardson <bruce.richardson@intel.com>]

On Tue, Oct 07, 2025 at 04:05:11PM +0100, Medvedkin, Vladimir wrote:
> On 10/3/2025 1:40 PM, Vladimir Medvedkin wrote:
> > This series introduces an initial implementation of DCB and PFC to the ICE PMD.
> > This includes adding support for TCs in ice_aq_set_mac_cfg() and asymmetric DCB/PFC configuration in base code.
> > 
> > Current implementation relies on current API and has a number of limitation and assumptions such as:
> > 
> > - Symmetric DCB configuration with respect to RX/TX, only dcb_rx_conf is used
> > - All TCs are configured equally with respect to BW they share
> > - No support for Low Latency TCs
> > - All existing queues are split evenly across TCs. Number of queues must be power of 2 and be no less than configured nb_tcs
> > - TX queues assigned to TCs the same way as RX queues
> > 
> > v5:
> > - drop base code patches
> > - rebase on top of the next-net
> > 
> > v4:
> > - fix more endianness
> > 
> > v3:
> >   - ice_get_tc_by_up() is renamed to ice_get_tc_by_priority() for better clarity
> >   - added ice_aq_set_mac_pfc_cfg(). Old ice_aq_set_mac_cfg() is a wrapper around a new function to keep better backward compatibility with an old code
> >   - removed rte_memcpy() and memcry() with direct assignment
> >   - addressed various style-related comments
> > 
> > v2:
> >   - fix spelling
> >   - replace rte_memcpy with memcpy()
> >   - fix endianness in several places
> > 
> > Vladimir Medvedkin (3):
> >    net/ice: enable DCB support
> >    net/ice: enable PFC support
> >    net/ice: add PFC statistics
> > 
> >   drivers/net/intel/ice/ice_ethdev.c | 370 +++++++++++++++++++++++++++++
> >   drivers/net/intel/ice/ice_rxtx.c   |  21 ++
> >   2 files changed, 391 insertions(+)
> 
> Recheck-request: rebase=next-net-intel, iol-compile-amd64-testing,
> iol-compile-arm64-testing, iol-unit-arm64-testing, github-robot
> 
This patchset looks generally ok to me, but the CI is flagging a
compilation error in a number of builds with older GCCs. It looks like a
false positive to me, but it needs to be fixed before I can merge this.

Also, with the addition of this support, I'd expect some documentation
updates to be needed. For example:
* release note update?
* ice driver guide doc update, perhaps?
* driver feature matrix update?

/Bruce