From: Bruce Richardson <bruce.richardson@intel.com>
To: Venkatesh Vemula <venkatesh.vemula@intel.com>
Cc: <dev@dpdk.org>, <aman.deep.singh@intel.com>, <shaiq.wani@intel.com>
Subject: Re: [PATCH v6] net/intel: add IDPF PCI class ID support
Date: Thu, 9 Oct 2025 17:10:10 +0100 [thread overview]
Message-ID: <aOfeYt5kMus0F7Gg@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <20251006181239.362664-1-venkatesh.vemula@intel.com>
On Mon, Oct 06, 2025 at 11:42:39PM +0530, Venkatesh Vemula wrote:
> Current IDPF supports only the MEV device IDs. MMG has new set of
> device IDs and same might be the case for the future devices. Instead
> of adding new device IDs every time, make use of the IDPF PCI class
> ID(0x20001) to differentiate between PF and VF.
>
> Write and read the VF_ARQBAL register to find if the current device is
> a PF or a VF.
>
> Signed-off-by: Venkatesh Vemula <venkatesh.vemula@intel.com>
> ---
Sorry for the late feedback here, but a question: Would this be better as
two patches rather than just one? It seems there are two changes here - one
to cpfl just adding a new device id for the driver to use, and a second,
seeming unrelated change, to idpf to identify PF vs VF. The new defines
used in CPFL are not used (unless I missing something) in IDPF driver and
vice versa, meaning the two changes seem distinct?
/Bruce
prev parent reply other threads:[~2025-10-09 16:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-19 14:51 [PATCH v1] net/idpf: " Vemula Venkatesh
2025-09-22 8:31 ` Wani, Shaiq
2025-09-22 12:09 ` David Marchand
2025-09-22 16:35 ` Singh, Aman Deep
2025-09-23 6:52 ` David Marchand
2025-09-24 12:57 ` [PATCH v2] net/intel: " Vemula Venkatesh
2025-09-24 14:34 ` Bruce Richardson
2025-09-25 10:28 ` Vemula, Venkatesh
2025-09-25 17:47 ` [PATCH v3] " Vemula Venkatesh
2025-09-26 15:26 ` Singh, Aman Deep
2025-09-29 14:00 ` [PATCH v4] " Vemula Venkatesh
2025-10-01 15:30 ` [PATCH v5] " Vemula Venkatesh
2025-10-06 18:12 ` [PATCH v6] " Venkatesh Vemula
2025-10-09 16:10 ` Bruce Richardson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aOfeYt5kMus0F7Gg@bricha3-mobl1.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=aman.deep.singh@intel.com \
--cc=dev@dpdk.org \
--cc=shaiq.wani@intel.com \
--cc=venkatesh.vemula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).