Re: [PATCH v3 3/6] net/iavf: ensure correct conditions for AVX-512 VLAN offload

[Bruce Richardson <bruce.richardson@intel.com>]

On Thu, Nov 06, 2025 at 11:50:13AM +0000, Ciara Loftus wrote:
> Commit 3aa4efa36438 ("net/iavf: support VLAN insertion in AVX512 Tx")
> re-enabled VLAN insertion on the AVX-512 path after it was disabled in
> commit efe1b63775e8 ("net/iavf: fix VLAN insertion in vector path"). The
> initial implementation introduced in commit 4f8259df563a ("net/iavf:
> enable Tx outer checksum offload on AVX512") was inconsistent in that if
> the vlan tag was to be placed in the L2TAG1 field, the offload was only
> performed if IAVF_TX_VLAN_QINQ_OFFLOAD was defined and if the path was
> an offload path. However if the vlan tag was to be placed in the L2TAG2
> field (requiring a context descriptor), the insert was performed
> unconditionally.
> 
> When VLAN insertion was re-enabled, these inconsistencies remained. This
> commit fixes these and ensures the following two conditions are met
> before VLAN insert is offloaded on the AVX-512 path:
> 1. IAVF_TX_VLAN_QINQ_OFFLOAD is defined (defined by default)
> 2. The path is an "offload" path
> 
> Fixes: 3aa4efa36438 ("net/iavf: support VLAN insertion in AVX512 Tx")
> 
> Signed-off-by: Ciara Loftus <ciara.loftus@intel.com>
> ---
Acked-by: Bruce Richardson <bruce.richardson@intel.com>