From: Bruce Richardson <bruce.richardson@intel.com>
To: Ciara Loftus <ciara.loftus@intel.com>
Cc: <dev@dpdk.org>
Subject: Re: [PATCH v3 6/6] net/iavf: fix QinQ insertion with mbuf flags VLAN and QINQ
Date: Thu, 6 Nov 2025 15:10:55 +0000 [thread overview]
Message-ID: <aQy6f3Hvkxk5NhM6@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <20251106115016.3035639-7-ciara.loftus@intel.com>
On Thu, Nov 06, 2025 at 11:50:16AM +0000, Ciara Loftus wrote:
> Fix an issue that would arise in the event an mbuf had both the VLAN and
> QINQ insertion offload flags set. In this case the L2TAG2 field would be
> written to twice and could cause the tag to be corrupted. Reorder the
> logic of populating the L2TAG2 field and ensure that the field is only
> written to once.
>
> Fixes: 3aa4efa36438 ("net/iavf: support VLAN insertion in AVX512 Tx")
>
> Signed-off-by: Ciara Loftus <ciara.loftus@intel.com>
> ---
> drivers/net/intel/iavf/iavf_rxtx_vec_avx512.c | 26 +++++++++----------
> drivers/net/intel/iavf/iavf_rxtx_vec_common.h | 9 +++----
> 2 files changed, 15 insertions(+), 20 deletions(-)
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
next prev parent reply other threads:[~2025-11-06 15:11 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-31 15:22 [PATCH 0/2] Fixes for iavf VLAN insertion offload Ciara Loftus
2025-10-31 15:22 ` [PATCH 1/2] net/iavf: fix AVX-512 double VLAN (QinQ) insertion Ciara Loftus
2025-11-04 17:13 ` Bruce Richardson
2025-11-04 17:16 ` Bruce Richardson
2025-10-31 15:22 ` [PATCH 2/2] net/iavf: fix single VLAN insertion positioning Ciara Loftus
2025-11-04 17:21 ` Bruce Richardson
2025-11-04 17:28 ` Bruce Richardson
2025-11-05 15:26 ` [PATCH v2 0/6] Fixes for iavf VLAN insertion offload Ciara Loftus
2025-11-05 15:26 ` [PATCH v2 1/6] net/iavf: fix compilation with VLAN insertion disabled Ciara Loftus
2025-11-05 19:31 ` Stephen Hemminger
2025-11-05 15:26 ` [PATCH v2 2/6] net/iavf: remove duplication in AVX-512 VLAN insert logic Ciara Loftus
2025-11-05 15:26 ` [PATCH v2 3/6] net/iavf: ensure correct conditions for AVX-512 VLAN offload Ciara Loftus
2025-11-05 15:26 ` [PATCH v2 4/6] net/iavf: fix single VLAN insertion positioning Ciara Loftus
2025-11-05 15:26 ` [PATCH v2 5/6] net/iavf: fix QinQ insertion for single packet Tx Ciara Loftus
2025-11-05 15:26 ` [PATCH v2 6/6] net/iavf: fix QinQ insertion with mbuf flags VLAN and QINQ Ciara Loftus
2025-11-06 11:50 ` [PATCH v3 0/6] Fixes for iavf VLAN insertion offload Ciara Loftus
2025-11-06 11:50 ` [PATCH v3 1/6] net/iavf: fix compilation with VLAN insertion disabled Ciara Loftus
2025-11-06 15:02 ` Bruce Richardson
2025-11-06 11:50 ` [PATCH v3 2/6] net/iavf: remove duplication in AVX-512 VLAN insert logic Ciara Loftus
2025-11-06 15:07 ` Bruce Richardson
2025-11-06 11:50 ` [PATCH v3 3/6] net/iavf: ensure correct conditions for AVX-512 VLAN offload Ciara Loftus
2025-11-06 15:09 ` Bruce Richardson
2025-11-06 11:50 ` [PATCH v3 4/6] net/iavf: fix single VLAN insertion positioning Ciara Loftus
2025-11-06 15:09 ` Bruce Richardson
2025-11-06 11:50 ` [PATCH v3 5/6] net/iavf: fix QinQ insertion for single packet Tx Ciara Loftus
2025-11-06 15:10 ` Bruce Richardson
2025-11-06 11:50 ` [PATCH v3 6/6] net/iavf: fix QinQ insertion with mbuf flags VLAN and QINQ Ciara Loftus
2025-11-06 15:10 ` Bruce Richardson [this message]
2025-11-06 15:32 ` [PATCH v3 0/6] Fixes for iavf VLAN insertion offload Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aQy6f3Hvkxk5NhM6@bricha3-mobl1.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=ciara.loftus@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).