[PATCH] license: standardize SPDX tag for 3-Clause BSD

[PATCH] license: standardize SPDX tag for 3-Clause BSD

[Thomas Monjalon]

Make sure the SPDX tag is used as defined in license/README.
Reduce separator to single space.
Use parenthesis and uppercased "OR" when a second license is applied.

Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
 doc/guides/eventdevs/dpaa.rst             | 2 +-
 drivers/common/dpaax/caamflib/desc/pdcp.h | 2 +-
 drivers/event/dpaa/dpaa_eventdev.c        | 2 +-
 drivers/event/dpaa/dpaa_eventdev.h        | 2 +-
 drivers/net/tap/bpf/tap_rss.c             | 2 +-
 5 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/doc/guides/eventdevs/dpaa.rst b/doc/guides/eventdevs/dpaa.rst
index 33d41fc7c4..8fb1d469dd 100644
--- a/doc/guides/eventdevs/dpaa.rst
+++ b/doc/guides/eventdevs/dpaa.rst
@@ -1,4 +1,4 @@
-.. SPDX-License-Identifier:        BSD-3-Clause
+.. SPDX-License-Identifier: BSD-3-Clause
    Copyright 2017 NXP
 
 NXP DPAA Eventdev Driver
diff --git a/drivers/common/dpaax/caamflib/desc/pdcp.h b/drivers/common/dpaax/caamflib/desc/pdcp.h
index 55159d53f0..460f48c9e3 100644
--- a/drivers/common/dpaax/caamflib/desc/pdcp.h
+++ b/drivers/common/dpaax/caamflib/desc/pdcp.h
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: BSD-3-Clause or GPL-2.0+
+/* SPDX-License-Identifier: (BSD-3-Clause OR GPL-2.0+)
  * Copyright 2008-2013 Freescale Semiconductor, Inc.
  * Copyright 2019-2025 NXP
  */
diff --git a/drivers/event/dpaa/dpaa_eventdev.c b/drivers/event/dpaa/dpaa_eventdev.c
index 400e0ecd1c..e5d93afca2 100644
--- a/drivers/event/dpaa/dpaa_eventdev.c
+++ b/drivers/event/dpaa/dpaa_eventdev.c
@@ -1,4 +1,4 @@
-/*   SPDX-License-Identifier:        BSD-3-Clause
+/*   SPDX-License-Identifier: BSD-3-Clause
  *   Copyright 2017-2019 NXP
  */
 
diff --git a/drivers/event/dpaa/dpaa_eventdev.h b/drivers/event/dpaa/dpaa_eventdev.h
index 047c9781bd..1794f4cde6 100644
--- a/drivers/event/dpaa/dpaa_eventdev.h
+++ b/drivers/event/dpaa/dpaa_eventdev.h
@@ -1,4 +1,4 @@
-/*   SPDX-License-Identifier:        BSD-3-Clause
+/*   SPDX-License-Identifier: BSD-3-Clause
  *   Copyright 2017 NXP
  */
 
diff --git a/drivers/net/tap/bpf/tap_rss.c b/drivers/net/tap/bpf/tap_rss.c
index 6a1c3761b7..040cd7488c 100644
--- a/drivers/net/tap/bpf/tap_rss.c
+++ b/drivers/net/tap/bpf/tap_rss.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: BSD-3-Clause OR GPL-2.0
+/* SPDX-License-Identifier: (BSD-3-Clause OR GPL-2.0)
  * Copyright 2017 Mellanox Technologies, Ltd
  */
 
-- 
2.51.0

Re: [PATCH] license: standardize SPDX tag for 3-Clause BSD

[Bruce Richardson]

On Wed, Nov 12, 2025 at 10:13:35AM +0100, Thomas Monjalon wrote:
> Make sure the SPDX tag is used as defined in license/README.
> Reduce separator to single space.
> Use parenthesis and uppercased "OR" when a second license is applied.
> 

Upper-case or is fine, I suppose, but I'm not convinced we need the
parentheses. However, I see other drivers tend to have it, so let's
standardize on that.

> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>

Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Re: [PATCH] license: standardize SPDX tag for 3-Clause BSD

[Thomas Monjalon]

12/11/2025 10:31, Bruce Richardson:
> On Wed, Nov 12, 2025 at 10:13:35AM +0100, Thomas Monjalon wrote:
> > Make sure the SPDX tag is used as defined in license/README.
> > Reduce separator to single space.
> > Use parenthesis and uppercased "OR" when a second license is applied.
> 
> Upper-case or is fine, I suppose, but I'm not convinced we need the
> parentheses. However, I see other drivers tend to have it, so let's
> standardize on that.

I'm not convinced as well.

Looking at https://spdx.dev/learn/handling-license-info/
it seems we don't need parentheses in general.

Also we should improve our script to check SPDX tag.
Stephen has a patch already in this area.

Re: [PATCH] license: standardize SPDX tag for 3-Clause BSD

[Bruce Richardson]

On Wed, Nov 12, 2025 at 10:38:44AM +0100, Thomas Monjalon wrote:
> 12/11/2025 10:31, Bruce Richardson:
> > On Wed, Nov 12, 2025 at 10:13:35AM +0100, Thomas Monjalon wrote:
> > > Make sure the SPDX tag is used as defined in license/README.
> > > Reduce separator to single space.
> > > Use parenthesis and uppercased "OR" when a second license is applied.
> > 
> > Upper-case or is fine, I suppose, but I'm not convinced we need the
> > parentheses. However, I see other drivers tend to have it, so let's
> > standardize on that.
> 
> I'm not convinced as well.
> 
> Looking at https://spdx.dev/learn/handling-license-info/
> it seems we don't need parentheses in general.
> 
Shall we just avoid fixing the parens until we definitively decide on that.
Just standardize on spacing and upper case "OR"? Whatever approach you
decide for this release, you can keep my ack.

/Bruce

Re: [PATCH] license: standardize SPDX tag for 3-Clause BSD

[Thomas Monjalon]

12/11/2025 10:41, Bruce Richardson:
> On Wed, Nov 12, 2025 at 10:38:44AM +0100, Thomas Monjalon wrote:
> > 12/11/2025 10:31, Bruce Richardson:
> > > On Wed, Nov 12, 2025 at 10:13:35AM +0100, Thomas Monjalon wrote:
> > > > Make sure the SPDX tag is used as defined in license/README.
> > > > Reduce separator to single space.
> > > > Use parenthesis and uppercased "OR" when a second license is applied.
> > > 
> > > Upper-case or is fine, I suppose, but I'm not convinced we need the
> > > parentheses. However, I see other drivers tend to have it, so let's
> > > standardize on that.
> > 
> > I'm not convinced as well.
> > 
> > Looking at https://spdx.dev/learn/handling-license-info/
> > it seems we don't need parentheses in general.
> > 
> Shall we just avoid fixing the parens until we definitively decide on that.
> Just standardize on spacing and upper case "OR"? Whatever approach you
> decide for this release, you can keep my ack.

I plan to rework this patch by standardizing without parentheses,
and add more checks.