From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6E92D4564D; Fri, 19 Jul 2024 11:49:09 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 46D2240E3A; Fri, 19 Jul 2024 11:49:09 +0200 (CEST) Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by mails.dpdk.org (Postfix) with ESMTP id 4B74B40655 for ; Fri, 19 Jul 2024 11:49:07 +0200 (CEST) Received: from mail.maildlp.com (unknown [172.19.88.194]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4WQPxg25T4zVlc6; Fri, 19 Jul 2024 17:48:23 +0800 (CST) Received: from dggpeml500024.china.huawei.com (unknown [7.185.36.10]) by mail.maildlp.com (Postfix) with ESMTPS id 6DE0C1402E2; Fri, 19 Jul 2024 17:49:04 +0800 (CST) Received: from [10.67.121.161] (10.67.121.161) by dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 19 Jul 2024 17:49:04 +0800 Subject: Re: [PATCH v3 0/3] bugfix about KEEP CRC offload To: Jie Hai , , , , , CC: , References: <20240206011030.2007689-1-haijie1@huawei.com> <20240719090415.1513301-1-haijie1@huawei.com> From: fengchengwen Message-ID: Date: Fri, 19 Jul 2024 17:49:04 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20240719090415.1513301-1-haijie1@huawei.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.121.161] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpeml500024.china.huawei.com (7.185.36.10) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Series-reviewed-by: Chengwen Feng On 2024/7/19 17:04, Jie Hai wrote: > For hns3 NIC, when KEEP_CRC offload is enabled, the CRC data is > still be stripped in rare scenarios. Some users of hns3 are > already using this feature. So driver has to recaculate packet CRC. > In addition, in the mbuf, the data that exceeds the length specified > by pkt_len is invalid. Therefore, if the packet contains CRC data, > pkt_len should contain the CRC data length. However, almost of drivers > supported KEEP CRC feature didn't add the CRC data length to pkt_len. > > This patch adds description for KEEP CRC offload. > > Dengdui Huang (3): > ethdev: add description for KEEP CRC offload > net/hns3: fix packet length do not contain CRC data length > net/hns3: fix Rx packet without CRC data > > drivers/net/hns3/hns3_ethdev.c | 5 + > drivers/net/hns3/hns3_ethdev.h | 23 +++++ > drivers/net/hns3/hns3_rxtx.c | 134 ++++++++++++++++---------- > drivers/net/hns3/hns3_rxtx.h | 3 + > drivers/net/hns3/hns3_rxtx_vec.c | 3 +- > drivers/net/hns3/hns3_rxtx_vec_neon.h | 19 ---- > drivers/net/hns3/hns3_rxtx_vec_sve.c | 3 +- > lib/ethdev/rte_ethdev.h | 6 ++ > 8 files changed, 124 insertions(+), 72 deletions(-) >