From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id BFA2D1B5E8 for ; Mon, 16 Oct 2017 11:44:59 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga105.jf.intel.com with ESMTP; 16 Oct 2017 02:44:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,386,1503385200"; d="scan'208";a="146929558" Received: from smonroyx-mobl.ger.corp.intel.com (HELO [10.252.25.241]) ([10.252.25.241]) by orsmga002.jf.intel.com with ESMTP; 16 Oct 2017 02:44:54 -0700 To: aviadye@dev.mellanox.co.il, dev@dpdk.org, pablo.de.lara.guarch@intel.com, aviadye@mellanox.com References: <1507987683-12315-1-git-send-email-aviadye@dev.mellanox.co.il> <1507987683-12315-10-git-send-email-aviadye@dev.mellanox.co.il> Cc: borisp@mellanox.com, akhil.goyal@nxp.com, hemant.agrawal@nxp.com, radu.nicolau@intel.com, declan.doherty@intel.com, liranl@mellanox.com, nelio.laranjeiro@6wind.com, thomas@monjalon.net From: Sergio Gonzalez Monroy Message-ID: Date: Mon, 16 Oct 2017 10:44:54 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <1507987683-12315-10-git-send-email-aviadye@dev.mellanox.co.il> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 10/11] app/testpmd: compile even if ixgbe anf bnxt pmds are not compiling X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Oct 2017 09:45:00 -0000 On 14/10/2017 14:28, aviadye@dev.mellanox.co.il wrote: > From: Aviad Yehezkel > > Signed-off-by: Aviad Yehezkel > Signed-off-by: Nicolai Radu > --- > app/test-pmd/cmdline.c | 13 ++++++++++--- > app/test-pmd/config.c | 12 +++++++++++- > 2 files changed, 21 insertions(+), 4 deletions(-) This patch is modifying a different app, should be on its own. Thanks, Sergio > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c > index bb19d72..e4a636e 100644 > --- a/app/test-pmd/cmdline.c > +++ b/app/test-pmd/cmdline.c > @@ -7377,11 +7377,17 @@ struct cmd_set_vf_rxmode { > }; > > static void > -cmd_set_vf_rxmode_parsed(void *parsed_result, > - __attribute__((unused)) struct cmdline *cl, > - __attribute__((unused)) void *data) > +cmd_set_vf_rxmode_parsed( > +#if defined(RTE_LIBRTE_IXGBE_PMD) || defined(RTE_LIBRTE_BNXT_PMD) > + void *parsed_result, > +#else > + __attribute__((unused)) void *parsed_result, > +#endif > + __attribute__((unused)) struct cmdline *cl, > + __attribute__((unused)) void *data) > { > int ret = -ENOTSUP; > +#if defined(RTE_LIBRTE_IXGBE_PMD) || defined(RTE_LIBRTE_BNXT_PMD) > uint16_t rx_mode = 0; > struct cmd_set_vf_rxmode *res = parsed_result; > > @@ -7396,6 +7402,7 @@ cmd_set_vf_rxmode_parsed(void *parsed_result, > else if (!strncmp(res->mode, "MPE",3)) > rx_mode |= ETH_VMDQ_ACCEPT_MULTICAST; > } > +#endif > > #ifdef RTE_LIBRTE_IXGBE_PMD > if (ret == -ENOTSUP) > diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c > index bafe76c..d38ba82 100644 > --- a/app/test-pmd/config.c > +++ b/app/test-pmd/config.c > @@ -3181,7 +3181,17 @@ set_queue_rate_limit(portid_t port_id, uint16_t queue_idx, uint16_t rate) > } > > int > -set_vf_rate_limit(portid_t port_id, uint16_t vf, uint16_t rate, uint64_t q_msk) > +set_vf_rate_limit( > + portid_t port_id, > +#if defined(RTE_LIBRTE_IXGBE_PMD) || defined(RTE_LIBRTE_BNXT_PMD) > + uint16_t vf, > + uint16_t rate, > + uint64_t q_msk) > +#else > + __attribute__((unused)) uint16_t vf, > + __attribute__((unused)) uint16_t rate, > + __attribute__((unused)) uint64_t q_msk) > +#endif > { > int diag = -ENOTSUP; >