From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D3979A00C2; Wed, 23 Feb 2022 18:26:00 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9F0A840E5A; Wed, 23 Feb 2022 18:26:00 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 4D39E40DF6 for ; Wed, 23 Feb 2022 18:25:59 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1645637159; x=1677173159; h=message-id:date:to:cc:references:from:subject: in-reply-to:content-transfer-encoding:mime-version; bh=inkcA3LvC8+t5ZNbh/h5G7fBbkz/O2YpRGHRmF9ou3w=; b=ORWXsIKKn2xCkvaI87CSbIdz/kyO8RBT7BJK2rsRENYSuulw4HvigwKY ZscnA5HRgu2sQMC7fBJFPnTMiJ7riNngyPDYgzl3CHZAxgRaZmBCXkeYE 2VltIkvLOxt+3D+PxJTSf6UO0BM/PzPwz6IIyKBeNrtMoKJqprjSwXcet IuVuehmdPfe9/6/JVBQ+STq3djoGHyB4czSr1hjF4ABAwH5wVwG5WzYkP JENVAS3JSs1nHxDG5SVWdx2NwCuwUTobA47YzUlK4OGgfFUjvPxYELw6y iYomFRumhDq4ylBpKhkYsBOCfntR4cqFi5REpD9p8xV4G3XzPxLKgwe55 w==; X-IronPort-AV: E=McAfee;i="6200,9189,10267"; a="251769409" X-IronPort-AV: E=Sophos;i="5.88,391,1635231600"; d="scan'208";a="251769409" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Feb 2022 09:25:58 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,391,1635231600"; d="scan'208";a="491284500" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by orsmga003.jf.intel.com with ESMTP; 23 Feb 2022 09:25:57 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Wed, 23 Feb 2022 09:25:57 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Wed, 23 Feb 2022 09:25:57 -0800 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.46) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Wed, 23 Feb 2022 09:25:56 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Kx4t5iD14IG1iS9yaJVEinOTz3ynkdfh/kB8RVLvbxEf0vpCNtWNUrkaOECTb0JPPzD2COY6f0m1EPrqefzyuofBVlK8epX9u0DiS7bffJuQVDY/UKGl91tCQ2GL00Q7fbNks0EqVVwhJKnD8qmJcUMTh5Ac//gYVNRoQCuYkEGhF/tdPaKKHBGvjJ/PB97VQCMaD1UuD2+KB2rAC1EB4iCWJzxPmg3FNWGzSDtxCF/nVCbPQpQ6mpKgMrom6H3NYmPk+pNJc5K0GeFAr8btXs+1hqiSinZyzD8Vjhq3ukY1rkVel2p96Qfaw+CXhY5xHzBVXDoOYtjCA92g+Yiwmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ITEXo94vAsDZOqYxEwgKv0Ns+EEybZyJneVXbmwM4Bg=; b=FvD3jJkfcqWAnauoN93YtOjbibn1KVkEh4/B6+iiV5w5UpX9JySpSyXfRyu7kCZT5ixmac8bBn08xuDtT2UFw34wDBmlrmxHMYHeg8XtqOWNY63I6plTMnfS2Gmg/toKN/Z3xnZEOc+W39qKXxwhUDCTxGsAVvuZa9Qz6Ockhi1en71L+QTPw4iZxYHXfUAFodHxjfg8aNpju8YtbHd95Qqe1Td8wyIoLVBP8Lh18mTKnxMKuKtfxQpZXKD3OiWMNDDnGLEHgY5uWEdjBFFz1wGaLdiIR7F6ig5U98YbVW02X5HMnHSjfW5bIFljr8BMCPuhxuRi+e2+D9ADUWgWsQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by DM5PR11MB1994.namprd11.prod.outlook.com (2603:10b6:3:e::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.17; Wed, 23 Feb 2022 17:25:55 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2%4]) with mapi id 15.20.4995.027; Wed, 23 Feb 2022 17:25:55 +0000 Message-ID: Date: Wed, 23 Feb 2022 17:25:48 +0000 Content-Language: en-US To: Michal Krawczyk , CC: , , Artur Rojek , Dawid Gorecki , Igor Chauskin References: <20220222181146.28882-1-mk@semihalf.com> <20220223121944.24156-1-mk@semihalf.com> <20220223121944.24156-4-mk@semihalf.com> From: Ferruh Yigit Subject: Re: [PATCH v3 03/21] net/ena: remove unused enumeration X-User: ferruhy In-Reply-To: <20220223121944.24156-4-mk@semihalf.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0223.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a6::12) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e6436ba7-5a36-4b55-dcde-08d9f6f18c36 X-MS-TrafficTypeDiagnostic: DM5PR11MB1994:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: faOibtwtXkhyNw+EvQSVyG4HffXl4bqaHHH8m5VT5CVR2otH1aHHOaxDghx73gSfq9+nLkpwG0kVdTIgBSZosBdYmhljSrpBRDEs59Y15dcVTkzUooI8Ps1PS760IG96J6CgNoycN5Ew+cjoKspuzzL23n2Vu40yN0iJjlisuPvKQhCDlAgJc/0RoxvcJOT61lVNL/Zd8eR271F6BRi0db5Imf/rfJU4hFX0AeZbGYtR7iHm6802tIshzNaQDXeuPTHmDVA/QYB+4YqQ1SbezSVrvYKXSQAJiPOUCWIT1lGI2zRU6PbZb7PsmcucdyPjDBG0tr2LInvieHqyXLEXe7KscWb57Bjmc1vhVNTSt11aaOU+8MDIJgKsOzi6sMhSinUPLmkBVXCAQYxiJTIG5rM2AOaIzMlcme40G81VT94MVdTde7WQQzVtSjZXpYegVAuWKQ+k16c+gTML6Q/uIkC9jUyKsCcq07Jdl3kc/1yVmH1xCIS3v7IBVbrd5OlJmvxglcNIEbIZ2sdYLEosTi8m7JADns6fUVvb2CIs9L5o/RxPyng6pOX5G+eXSh9J/k8IbKFJc0w+CQID/qLCSVvLFViZdp52dMgr+CrZHxWTRBw9aO+MZ2xB+bo9nw6q5pA61284mmPgYZzg3E9vPNBQ4FtJA7Z41JA/ELrOP4fHlzX/gwHBolgHrsHHBf5KiyjRxqwA0Vqe7NqBjn0hPg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(4326008)(36756003)(38100700002)(44832011)(83380400001)(31686004)(5660300002)(2906002)(8936002)(54906003)(6486002)(66476007)(316002)(186003)(26005)(6512007)(2616005)(66946007)(66556008)(82960400001)(8676002)(53546011)(6506007)(6666004)(508600001)(31696002)(86362001)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MDFDdDVqVXlyWFJweFMxMG81eER5V0V2cmxMUmk4NWh6V2h2Y3RoNHNyeUJI?= =?utf-8?B?dzQ3ZisyQ0RERGRnRm9LeVpBMzhlOWs2akY0aDVabHZKQlo4MG83SG0rakVl?= =?utf-8?B?OU01TTlxVnZ1TnY4Rm5JR3Npd1Q4WnNEbC9FNmRZNVYwVlR5ZDJ2KzkvM2VU?= =?utf-8?B?YXg3MUZzQTVlTzN4YytRTExWdTNLMDNTbXVibXhuTEZycmJlcHo4WkVrdkRY?= =?utf-8?B?RWhCQmIyYjZuZEtjVWhQcUNRSHFyUXNFYTNqcDVKYndMWkwzT1VvTjA1S0NH?= =?utf-8?B?RVkwbVJPYzZYTVlaRzUzQ3d2L3g4QWxyV1hTNjRnNmhEeWx3c0EyTDV3QjVC?= =?utf-8?B?WTRkRkYrV1BXeG5yUktmK2o1WXBkTVBDQjRxa2tlSFY3RnNsdlNKOUlKNllH?= =?utf-8?B?eGNnQzVVek92aW9MSWtqakpNUWpMSU5jZUdNQ2VqZmVFdEw0ZDJ1bnZlTUFl?= =?utf-8?B?LytoeUtBT0ErdkR3Zk5qYmFWeFRyQks2VWFqU1lBdjg0R2VNOVhaVHpPdk9F?= =?utf-8?B?elAvb0dNcG4xTkpQV3ZyM1RtTmUva2N1S1BNQ29hNWtZOTVrR1VtVmhraG5H?= =?utf-8?B?QXpIUldsZVBkTHBMNFozbXRvbEgvYnREZitjMDhFaVFkVmV2TTJuQXJLajBM?= =?utf-8?B?d1FTL1RXTVpsVFFpdEEyZXlPbFVWS2t0UUVnQ25TYlB4dEJGVTI4eUhLZzlr?= =?utf-8?B?czhXTDMyMURVSjB4Vm55T3BFSEhXdVJnZWZIVHo5TGVJcmlkQlUzQy9wZExB?= =?utf-8?B?enRqWTNWYVZTTHA2aHFiZGdxMlRBd3ZpYkd3K3pyMDRXWUZBZCtXTnZYVVd0?= =?utf-8?B?aHV1Y29ibEVtbzdPakhiOUpYSDZoZ3JpMDRtc0JNaCtmWVlrVHNGbWhhVEpL?= =?utf-8?B?OERBdHdnNGtqdEZtejRiTms3UEFackYyblU3bDByUU15U2xwclEzVzVIYzB4?= =?utf-8?B?QjFXRHVjdlBCQStxRkVlZU14ZnVEM25VS2MvVzJjSXVGeW95NjRialJtdW5T?= =?utf-8?B?NUVaKzQ4TGdid1BERmNRUUJ2a1BBN29vdlpKSnNzRzdIbEZYL1NqOHc5eitV?= =?utf-8?B?SU0zS3pDMXA5NWRxUVJVWVBFNkNxNG81bit3eGFObHQvaDJLNDViYjYrWStZ?= =?utf-8?B?SFZOdmZEemg2aXJZOVQrSDhidWtFWHdTSnZWd1AyM3JMMjNrTnlyTzRHcnBr?= =?utf-8?B?NlVTYVpldjNiTEtDa2RyNGtkNWh2WDM4bGdmWWc0bVZTUWdhVTVQZGJ1UXRG?= =?utf-8?B?Q2NQODY5K1NtRlgzeEFvZmVBbUlwV0NENHFxSUVIdjV2WkF5TVVmellremNW?= =?utf-8?B?bFkyZGZhSUxYSlJNc0wvSWpwM0lhTlRGRTJmVVZuTmdReWE4aTJobkZvaHpV?= =?utf-8?B?RnlNY21pUG1WbWdHZjdGeU1zS0pEcWRraCtUYWx0bTVIY29QbG1OTXVLbjNU?= =?utf-8?B?ZmtPYjVpMGdmZ2d1K1c4Mlp4M1BNS25uTFBEeVplT3NqbDhHOTBjUU5ZcUpB?= =?utf-8?B?V25oSHM3bk9od0pkYktZd0lJek5xUitFTGRXQXJSM0lBSHRvUlRnUjdDaE95?= =?utf-8?B?bEt6VGNQUUlVTW9XRE5ZaFVYNFRsTTRPUlEzVERjaUVEdXJKNCtmY2J2ZzNX?= =?utf-8?B?WEM4WGpEQ2FVdkdQdDRsVW42YmtFaEVLNDMrZUtoQ2hIWTU5WVF3ekd6SE8w?= =?utf-8?B?WmFSUDE5b2pIbFhNaEpSZFJiaXBHWUFZS1RUM0g0c21oSDVBTU85SkVrZllH?= =?utf-8?B?ZHQxbmcwNHRjZmRacXVnWW1SUjFGZTVDazFiQ0xMclF0VCtpNCtHVTUwSXY1?= =?utf-8?B?ZGwvb2pxUGk4L0JKTzNiTkx6ZDhPUTc4aTN3RkNJbStYanlIdzYzbzZlOFpS?= =?utf-8?B?bmZXTFlVUURVeDRFN3JzSjNTR2dDbklxYzhBaUt4ZmRlcDRtTUxKcUY3L3dZ?= =?utf-8?B?SU5hTW81UCtDRnFGUGcraWJZN0ZxLzE1YUMyRTJjR3FWTFNCd2dSUmY5dUlE?= =?utf-8?B?RHdxN3lwU09saXVVKzVYbVRRak53clFhdnNDY1NadFB0bkJNLzZNcFJrb3pR?= =?utf-8?B?VXRsOHhPSEszMHJhT00vRXhNQzQ0WnZvdGFzSlBrOVJ1UDBoZzBZRUdyUDIx?= =?utf-8?B?RkFjSjIyU2toYlErNGRzbzNkNTlPdGd4bTVKQjl6RzFOd0xHY2NmRGNXaVAw?= =?utf-8?Q?Ig3wH2nQhII1xXjuaH+TC6U=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: e6436ba7-5a36-4b55-dcde-08d9f6f18c36 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2022 17:25:55.2248 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ftj9LzwbLuJhDzok8CI5+MTWWQCrT9OWODmden8gAwmzJEZMfh4oDkVh/bm6+QECgQXkeOTztSElxb887zuoXw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB1994 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/23/2022 12:19 PM, Michal Krawczyk wrote: > The enumeration seems to be leftover from porting the Linux driver to > the DPDK. It was used nowhere and refers to the ethtool which is not > present in the DPDK. > Fixes: 372c1af5ed8f ("net/ena: add dedicated memory area for extra device info") Cc: stable@dpdk.org > Signed-off-by: Michal Krawczyk > Reviewed-by: Artur Rojek > Reviewed-by: Dawid Gorecki > Reviewed-by: Igor Chauskin > Reviewed-by: Shai Brandes > --- > drivers/net/ena/ena_ethdev.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c > index 34fb43cb00..2de2dcf12f 100644 > --- a/drivers/net/ena/ena_ethdev.c > +++ b/drivers/net/ena/ena_ethdev.c > @@ -38,11 +38,6 @@ > > #define ENA_PTYPE_HAS_HASH (RTE_PTYPE_L4_TCP | RTE_PTYPE_L4_UDP) > > -enum ethtool_stringset { > - ETH_SS_TEST = 0, > - ETH_SS_STATS, > -}; > - > struct ena_stats { > char name[ETH_GSTRING_LEN]; > int stat_offset;