From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AC4A7A00C2; Wed, 23 Feb 2022 18:36:30 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4248740E5A; Wed, 23 Feb 2022 18:36:30 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 1270840DF6 for ; Wed, 23 Feb 2022 18:36:28 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1645637789; x=1677173789; h=message-id:date:to:cc:references:from:subject: in-reply-to:content-transfer-encoding:mime-version; bh=gPRaCGaMiRV1+zO3z6KDheyA3CuxNtvW+S03O/WJGlA=; b=HrrRGf/iHB2NRNvV2OWrFebnuqbZcEXUIlEGMguokCQLYINsYlk30rlF cpSIYUWu7tx8ruyQga2Ws3llJFjA1veRN9V2S+Q0n1476cf4FGsKZgqSz b2463e8Yi379LV4AsdU9OEes4jw0tlcn721JiYL3TZXpMvIuKGXhnhM5H n6q4CxdA1ljk85K4MOmMMhrNufl5pITJqhU6dmrnUqb4rwv7bCkj0lF5V 5LZDWQXAomkT1Cel2SXVzBEqF4DU2xFKJAtrYhmwb9+KUqjyPLik/ui7N DclpHMDmT8EzRK/CSpZ9woOfWayvvXrTWbSffx0FkHwdLRSH9FDGoq/lm w==; X-IronPort-AV: E=McAfee;i="6200,9189,10267"; a="232008099" X-IronPort-AV: E=Sophos;i="5.88,391,1635231600"; d="scan'208";a="232008099" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Feb 2022 09:25:51 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,391,1635231600"; d="scan'208";a="548355078" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by orsmga008.jf.intel.com with ESMTP; 23 Feb 2022 09:25:50 -0800 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Wed, 23 Feb 2022 09:25:50 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Wed, 23 Feb 2022 09:25:50 -0800 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.42) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Wed, 23 Feb 2022 09:25:50 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fMsfSTu87pqikvhG4mkTM8WkxRpHP2xPPN+WRODbPsKoyQgMW9DLcFtSU9vB/7HFjcEWhUXkpgQkQbq39orrvzJgx13rCwCwEM92b6HE8SJGll07F79NRjpeYrz88Klqm74kUCwAocCHuEttxn5/6VprHxOwQcDdbWlfeJ5tucVbKu00siL9yAzHATSzPpEbJBrAhw9HnjfsN5/ujGdFIvftc6WGRlh0tnve1bnBvwiC/Vvob+DqGCMQ4c+CFlHIxr8jnpBGXFJW+Ko1tZz6wAOftI3giEgfQllNrlsASgANyrev8yR19Bz+TqLYHqP+Ol5u5r6ZkR4CRTkoZyzs3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/VgjUhRv+2brp4bM4lAEEd/ee5AgjuKrRevGxk75O1I=; b=Stm6HtrMOdjyRovoXzb69bW6IoUSdzQ2+O8t7yWc8y80jpX74zmKNMe7oL3P+IemMor+YNamTtlaGtPyzUyeoIJu+ZLslj764Tg5ZB06T6OmrS4x1oI0TlqLIEIxa3Ds8+H+1zcvy32Yy0Bz855QXYX7gHqiirQ8X4RbsQs4d42cqVEQTCmasTtb2RKS5w+KCtrcSMZY0g8mdPSQTDwbW0/1zI+8Zky8EvixiuHco+ypOWMBhtMITNahf0JOs3t5f1P44el7ZcYL4tKIYho8SKIUh6ODGa0gO7jCWfnCU70DvwqBjiZpDk9qHlaKTla64nO9h+N0cnkHqnyq4B7e/w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by DM5PR11MB1994.namprd11.prod.outlook.com (2603:10b6:3:e::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.17; Wed, 23 Feb 2022 17:25:48 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2%4]) with mapi id 15.20.4995.027; Wed, 23 Feb 2022 17:25:48 +0000 Message-ID: Date: Wed, 23 Feb 2022 17:25:42 +0000 Content-Language: en-US To: Michal Krawczyk , CC: , , Artur Rojek , Dawid Gorecki , Igor Chauskin , Kevin Traynor , Luca Boccassi References: <20220222181146.28882-1-mk@semihalf.com> <20220223121944.24156-1-mk@semihalf.com> <20220223121944.24156-5-mk@semihalf.com> From: Ferruh Yigit Subject: Re: [PATCH v3 04/21] net/ena: remove unused offloads variables X-User: ferruhy In-Reply-To: <20220223121944.24156-5-mk@semihalf.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0224.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a6::13) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d91227c8-b706-43e5-38b6-08d9f6f18835 X-MS-TrafficTypeDiagnostic: DM5PR11MB1994:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7X9A3++sPJkvqwKiD3Dj4BTgdY8q9Z9u6jswuqI6vuRJCuCy+PNEZlG5Dw21OC5FqcnLAcNk/EhqSLMkK7br+bxmTxxGQYDAfemthghd0CUMbMcUSezOvfJwIoVuHNAtsVgEIgGAD5Z4hRl5vkE51kQuTS1y3LgD7CnwL+y0Py+FreJQrzVVPCiym1FxU/R6sU44rMh/JQO1AMkV3Qdi3JnfzicldGV1R06hPDcn1WGL/DM2acKmmQMyU5P0Y6cx7PqUjE3y4lARXChaXFvcoKaWTVlb9winLBWD6w8IwK9WZcHoLYvOgZxcaZrtSmH7OkUOhjFIYRXts6Qiq6fdXYb8zInCHGhnDuEpQwSDkiGck0Ne+ltVetvfA1d4fLHv9M2x/RBqle7pXxXi19gSJLpNXy2DFg7Ai9jKHgoN3sduTBX2Wav6/1F/MCxbgYdWjpj799VDW32k1NpDK226y+SSccTIpKMQLD8sM7iY1gbh2ib9G5zT6ulI9H0ljTrdwKf8KPfL6L5M41Igx7ltsTRw1WjKIhFjCTNbg9Ozq2Gl4i2MSB5scYWXoXM8Zz8qIfGRlHErV/KQpFYb+1DZuHTN5p8qRtIwsjuaK5P5ZrZkQ0rH1Efabuj7mWjARK5cbq01KYpblBfBZ1xbknp0XU6a6WXeefJts76nqXQE5ZQ/F2tNWfCghi88dg+QEfQ56o1aR7zLTisQOzK96035MA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(4326008)(36756003)(38100700002)(44832011)(83380400001)(31686004)(5660300002)(2906002)(8936002)(54906003)(6486002)(66476007)(316002)(186003)(26005)(6512007)(2616005)(66946007)(66556008)(82960400001)(8676002)(53546011)(6506007)(6666004)(508600001)(31696002)(86362001)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b3hHN0NESjFNOUh2Q2p3bitGUlRUOEF6NFVTL2d1VnJWOHJtdUlva081M1Mx?= =?utf-8?B?MkJBZXB5eGJjaGRCOXBXa3VNMHdlZ3ByaURsUDlpSHJPRlVRWkdGRFBxQmRh?= =?utf-8?B?bTJVb1g5ZjlVUmprUGM5M3Foa0VxNHVaV0VvWUJ0Z3lzSUpKNG5QR3JPMnRJ?= =?utf-8?B?ZUtLL2NEcFVXWG8ySnQrMkp2c3VjTUc4QUJOOE15R0JMZkRMdkd1MkhMWjZC?= =?utf-8?B?NkI1Y2xwUjBLUklVcEtSSmI1S1B4TUtDMTZGdW9USmQ3ek9XQjZmT1gzSWxS?= =?utf-8?B?SlFsUTcrQTI0dmkwMlFNMTMvNVg2RkxHbWhIckRsQ2VQbHo5d0JNTEVKVW9D?= =?utf-8?B?V1VHR3ErRitNVEJvV2ZPcmRDVXE4UHhac21jWGRIbUhFZWU1ekM0SHBsaWZ5?= =?utf-8?B?dHREZm5MTWFZdWNWbEpNMnhkZmhUbW5EQ0Eyemg5SnJhbG9ER1F0ZzdCdFVT?= =?utf-8?B?OGVIWnhnMUdhd1oyZHB4cHFvVzRFUll5b0plaktma2pHNDAyTGtya2Yxdkly?= =?utf-8?B?RGtzM0hJL1MxVUNXNzVVTDNYUEdHZDBIZllGd0J5MXY4MVFyNTJPZk9acVht?= =?utf-8?B?cFNKdlJjai85UDlSQzB1a08ydGNvVWpFVy9pSTJ0YmVDMy9TaE5hZVdaeUVz?= =?utf-8?B?RDN2WGg5YjNhd0tvNXJSU1ZpNWJMYkR2NytqS1FkckRkcmlyNTQrV3NOUHFB?= =?utf-8?B?cFpidjYxTitzUnlETWo2SWdBU1NFNjVpdFRLMnJ3cDltRWlOWWQxOW5yeGtG?= =?utf-8?B?djRldnB6NFlJNS9nb2R2VGZNaVk5enhzUFF5Wm1obXZWTHpSQzczSXo1Sk1w?= =?utf-8?B?a0k2T25KVWpsdS81OExNSU85SXVnZEpRbGJ6ZjdPb1l2Nyt1bzRwNmNEd3Rz?= =?utf-8?B?OWtLSWM3L2lYSDBNNEkwYmNzbHIxTCtsQS9Odzh1UDdRY2R3b29FcFZOMDR5?= =?utf-8?B?WWZCY25MQmFuakEvN0VHajZtY3U4d0c0SXBOMHpPV2dnUC95ZFBNMytVcTZG?= =?utf-8?B?V21iRnN5R05Bek4xOE00d09YMHlza08vQkdublVDT2ZiVTRIS1VNYkZocy92?= =?utf-8?B?YjhMLzhVUWUyb2xBUFJvRlFQUTFieEpEM3BLMzBFVFdBbXhxS3NoR3JIV0c3?= =?utf-8?B?RWJmV1pBUjZ2ZW56dnZYVVc2aE1KTlYxSDlxdlhGNm8xMG5HLzZKN1N3a3B6?= =?utf-8?B?QU15dGNTZG5Xa3k4Nm1pWk4vMWpFcXpiSDdQcGkzaUt5dm9mN3NBYXk0U2cw?= =?utf-8?B?U3cyS1REZnZ3SGZGQmp2VkJLUTFUMDd4SU5WRjhranB2V05OWnEyVDBWL05h?= =?utf-8?B?WHJZcTZnWEVXYU5uWFpRbDBUa3FvK1A4TWpkOHp6QXA5cVIvZE51WmdlMzMy?= =?utf-8?B?NW1sSUZpTFkyK3JuT1kvb3cvM3A1WU55d1hZQzdES2Z3WWlIOFVMNDRzZFFK?= =?utf-8?B?ZEgrK3IxeThPMHRDdUJaSXdJVmxNN0JKSTRPdVRRUXcwQ3RwdWd5V1pWRTl4?= =?utf-8?B?TVZieFR0RmtPaitJb0o0emZvZDF5eklFaXhPK1Q3QXJCdmFvVnMwaTUxZWwz?= =?utf-8?B?aEJTK29ZVTUxdEpxbzM5VVJqclZZUjl5aHhvS1B1bW9qOE9zUlpmaGZ2TUVM?= =?utf-8?B?NytUVDlkUG8yd3BIdHBnZDI5bThDd0ZmejRPT0hOQjRFbUl5ajdqZ3Rob0FK?= =?utf-8?B?LzFHN2ZsRlRmeCtBWlRzclVwQnc5anlvci83NXVQVkpsS0JCR056amR5UWFN?= =?utf-8?B?cmNteGVLUGN3ZUc2dytMTXBXVGozRURuangwZFEwZEM2Z1lhOS8yd2ZDaDZh?= =?utf-8?B?aFFlSmFTYnV6OThkbFN2RXdDTGo5azFNWEQvT0c4d1ZuQklIUFhBOTdEbE0z?= =?utf-8?B?dnBNSytLeGhmb2QwKzRObjdkQ241bll3QnpBd3BHSFl0VWQxcjlWZmhLcWdn?= =?utf-8?B?VGZyYzRDeE9IWnhFYzF2SDVyMXNzNVFoMUFVQjBEQmwvUmVKam11QXNsKzd1?= =?utf-8?B?SGg4YVhmVm9jcytnU25rN1E0YkxWQ293QzFhcU1sQURYSTZzcTRMWUNVbk5n?= =?utf-8?B?Ykk4SDdwVmRabVhNZWRFL24xU0R4QmlRdkhERFVtNUM2ekwzODEyVTBRYTM2?= =?utf-8?B?b1dMbklYWHdJMXdWNDV6bTdNMjRoUjlLNEt5Y1NTaElJV1d4amcxdC9wc2Vi?= =?utf-8?Q?/qjq6cbzqmkDxII+yEQ8Tb4=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: d91227c8-b706-43e5-38b6-08d9f6f18835 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2022 17:25:48.5813 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: V56iEOJ46rIrRH+tVKb8Abfng6PTWXTcyYrzfLR5JlUO2KVelQaXcXLdnrl26vt4ulDfYZFJhrT1BhdYkmB0XA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB1994 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/23/2022 12:19 PM, Michal Krawczyk wrote: > Those variables are being set, but never read. As they seem to be > leftover from the old offloads API and don't have any purpose right > now, they are simply being removed. > It can be good to add fixes tag, both for - document in which commit old offload flags because useless - backport the change to LTS, I can see the changes don't do much but backporting them can help to reduce future conflicts for future fixes (cc'ed LTS maintainers for comment) If agreed please send the fixes line, I can amend it in next-net. > Signed-off-by: Michal Krawczyk > Reviewed-by: Artur Rojek > Reviewed-by: Dawid Gorecki > Reviewed-by: Igor Chauskin > Reviewed-by: Shai Brandes > --- > drivers/net/ena/ena_ethdev.c | 3 --- > drivers/net/ena/ena_ethdev.h | 5 ----- > 2 files changed, 8 deletions(-) > > diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c > index 2de2dcf12f..de5fdb8f1d 100644 > --- a/drivers/net/ena/ena_ethdev.c > +++ b/drivers/net/ena/ena_ethdev.c > @@ -2015,9 +2015,6 @@ static int ena_dev_configure(struct rte_eth_dev *dev) > */ > adapter->tx_cleanup_stall_delay = adapter->missing_tx_completion_to / 2; > > - adapter->tx_selected_offloads = dev->data->dev_conf.txmode.offloads; > - adapter->rx_selected_offloads = dev->data->dev_conf.rxmode.offloads; > - > return 0; > } > > diff --git a/drivers/net/ena/ena_ethdev.h b/drivers/net/ena/ena_ethdev.h > index f47ba3fb02..4dfa604d51 100644 > --- a/drivers/net/ena/ena_ethdev.h > +++ b/drivers/net/ena/ena_ethdev.h > @@ -278,11 +278,6 @@ struct ena_adapter { > struct ena_driver_stats *drv_stats; > enum ena_adapter_state state; > > - uint64_t tx_supported_offloads; > - uint64_t tx_selected_offloads; > - uint64_t rx_supported_offloads; > - uint64_t rx_selected_offloads; > - > bool link_status; > > enum ena_regs_reset_reason_types reset_reason;