From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 882F2A04AB; Mon, 31 Aug 2020 08:30:21 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DBBF11515; Mon, 31 Aug 2020 08:30:20 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 0FCCEA3 for ; Mon, 31 Aug 2020 08:30:18 +0200 (CEST) IronPort-SDR: d0mEoZf4X8BOd9jvD8YkFYazvlM97axSs4C1W/6HwOy4zAM4LI4y3eQyBa8+hqlB6CZvZv1YMV DkVnHj50S+AQ== X-IronPort-AV: E=McAfee;i="6000,8403,9729"; a="136450621" X-IronPort-AV: E=Sophos;i="5.76,374,1592895600"; d="scan'208";a="136450621" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Aug 2020 23:30:16 -0700 IronPort-SDR: 7958xIN51z6IRuMiQdFpPMjgvoB454/x1M3YsOoDoBZQhCtmVFOlWN5OyAdzHqtsw2diTHMNi4 oLRHNQ9vFF0g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,374,1592895600"; d="scan'208";a="476602424" Received: from jguo15x-mobl.ccr.corp.intel.com (HELO [10.67.68.171]) ([10.67.68.171]) by orsmga005.jf.intel.com with ESMTP; 30 Aug 2020 23:30:15 -0700 To: =?UTF-8?Q?Morten_Br=c3=b8rup?= , Beilei Xing Cc: dev@dpdk.org References: <98CBD80474FA8B44BF855DF32C47DC35C6126A@smartserver.smartshare.dk> From: Jeff Guo Message-ID: Date: Mon, 31 Aug 2020 14:30:14 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35C6126A@smartserver.smartshare.dk> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Subject: Re: [dpdk-dev] i40e_rxtx_vec_avx2 code review X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" hi, mb Seems that there are a referring issue here which you have found, i think we need to fix it, if there are on objection i will add that fix into the prior burst fixing patch, thanks very much. On 8/29/2020 3:21 PM, Morten Brørup wrote: > Jeff, Beilei, > > Looking closer at i40e_rxtx_vec_avx2.c, I noticed: > 1. i40e_rxq_rearm() uses RTE_I40E_DESCS_PER_LOOP, while all other functions in the file use RTE_I40E_DESCS_PER_LOOP_AVX. It may be correct, but please check. > 2. The function descriptions of i40e_recv_pkts_vec_avx2(), i40e_recv_scattered_burst_vec_avx2() and i40e_recv_scattered_pkts_vec_avx2() refer to RTE_I40E_DESCS_PER_LOOP, but they should be referring to RTE_I40E_DESCS_PER_LOOP_AVX. > 3. RTE_I40E_DESCS_PER_LOOP_AVX is defined in the file, unlike RTE_I40E_DESCS_PER_LOOP, which is defined in the i40e_rxtx.h header file. Your choice, just mentioning it. > > > Med venlig hilsen / kind regards > - Morten Brørup >