Re: [dpdk-dev] [PATCH v3] igb_uio: fail and log if kernel lock down is enabled

[Ferruh Yigit <ferruh.yigit@intel.com>]

On 6/29/2018 8:04 AM, David Marchand wrote:
> Hello Ferruh,
> 
> On Wed, May 16, 2018 at 4:42 PM, Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>> @@ -136,3 +132,22 @@ static bool pci_check_and_mask_intx(struct pci_dev *pdev)
>>  #if LINUX_VERSION_CODE >= KERNEL_VERSION(4, 5, 0)
>>  #define HAVE_PCI_MSI_MASK_IRQ 1
>>  #endif
>> +
>> +#if LINUX_VERSION_CODE >= KERNEL_VERSION(4, 8, 0)
>> +#define HAVE_ALLOC_IRQ_VECTORS 1
>> +#endif
>> +
>> +static inline bool igbuio_kernel_is_locked_down(void)
>> +{
>> +#ifdef CONFIG_LOCK_DOWN_KERNEL
>> +#ifdef CONFIG_LOCK_DOWN_IN_EFI_SECURE_BOOT
>> +       return kernel_is_locked_down(NULL);
>> +#elif CONFIG_EFI_SECURE_BOOT_LOCK_DOWN
>> +       return kernel_is_locked_down();
>> +#else
>> +       return false;
>> +#endif
>> +#else
>> +       return false;
>> +#endif
>> +}
> 
> Missing some defined() for the check on CONFIG_EFI_SECURE_BOOT_LOCK_DOWN.
> It causes a build error with ubuntu-16.04 hwe for aarch64.
> 
> I can send a patch.

Hi David,

You are right, please send the patch if have bandwidth for it, thanks.