From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 65AB9A034F; Mon, 19 Jul 2021 15:20:16 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 236284014E; Mon, 19 Jul 2021 15:20:16 +0200 (CEST) Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by mails.dpdk.org (Postfix) with ESMTP id A118D4003E for ; Mon, 19 Jul 2021 15:20:14 +0200 (CEST) Received: from dggemv711-chm.china.huawei.com (unknown [172.30.72.53]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4GT2Rk1c30z7wQ9; Mon, 19 Jul 2021 21:16:34 +0800 (CST) Received: from dggpeml500024.china.huawei.com (7.185.36.10) by dggemv711-chm.china.huawei.com (10.1.198.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Mon, 19 Jul 2021 21:20:11 +0800 Received: from [10.40.190.165] (10.40.190.165) by dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Mon, 19 Jul 2021 21:20:11 +0800 To: Jerin Jacob CC: Thomas Monjalon , Ferruh Yigit , "Richardson, Bruce" , Jerin Jacob , Andrew Rybchenko , dpdk-dev , =?UTF-8?Q?Morten_Br=c3=b8rup?= , Nipun Gupta , Hemant Agrawal , "Maxime Coquelin" , Honnappa Nagarahalli , David Marchand , Satananda Burla , Prasun Kapoor , "Ananyev, Konstantin" References: <1625231891-2963-1-git-send-email-fengchengwen@huawei.com> <1626665358-48826-1-git-send-email-fengchengwen@huawei.com> From: fengchengwen Message-ID: Date: Mon, 19 Jul 2021 21:20:11 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.40.190.165] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpeml500024.china.huawei.com (7.185.36.10) X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH v6] dmadev: introduce DMA device library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Many thank. Most of the comment fixed in v7, and v7 still include implementation. I did a thorough test of the implementation, so could you please review the implementation also ? One comment is modified as follows: COMMENT: >> + * | | | ------------------ >> + * | |DMA| | | ------ >> + * | | | | |--------| EP | >> + * | | |--------| PCIE Core2 | ------ >> + * | | | | | ------ >> + * | | | | |--------| EP | >> + * | | | | | ------ >> + * | ----- ------------------ > > > This diagram does not show correctly in doxygen. Please fix it. REPLY: I can't find the right way to show it as correctly except split them to two part (one with doxygen format, and the other not), so if you have a good idea, please let me know, thanks. On 2021/7/19 14:21, Jerin Jacob wrote: > On Mon, Jul 19, 2021 at 9:02 AM Chengwen Feng wrote: >> >> This patch introduce 'dmadevice' which is a generic type of DMA >> device. >> >> The APIs of dmadev library exposes some generic operations which can >> enable configuration and I/O with the DMA devices. >> >> Signed-off-by: Chengwen Feng > > > The API specification aspects look pretty good to me. > > Some minor comments are below. You can add my Acked by on future version > API header file where you will split the patch. > [snip]