From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 95B9543AB3; Fri, 9 Feb 2024 14:55:09 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 32E6A42E64; Fri, 9 Feb 2024 14:55:09 +0100 (CET) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2056.outbound.protection.outlook.com [40.107.93.56]) by mails.dpdk.org (Postfix) with ESMTP id F0B9140697 for ; Fri, 9 Feb 2024 14:55:07 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TJjZQ2ojVZOizjSY9WR8X5VC6GgQTqEx7uyYY2EVKTl3GPcIqPIQrRVi6wkHPxt9kEtEP5VEijALGiR44+QNqWYUn0rDh3AxqXRUYdKrmlQVteHHwa6zXty4g/3sZOqOWUH+cNjK5e5nqKzhKpoB4uW2jB2mEF74WvvnALUghV6SRi619f5W1frP/DYJal9IR0rqUV0wIBXjn+lXIt1jfLCQ44kjrLNk5WjEh37gunhw33BXRVS00QdhRsGUjaB3lT3QWiTuipoS96aPeaYhMX6cpLUU1J37Cw/IlmR4Li724V37mFJKBSJE4mkh/dnZy+N8SE9cZRwzy7lbDIF6lQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aUyJ7GsggkPeXW18f6N+bU/fCP0CzDvLO7UrNkW/86o=; b=lrnGr4uFzCWQSkH3uyIqZUDeWp2byuF5bQ76vie38+/arNkhLw8YoSopVWJh047kr5vRqr1po8szX3IT/al5/TkMtYyhKOJsG6YS9jjM7/MIOquVCEtq8S6B7+RFeALAVR8yKc+2n6QFBnb8o1O22AyohR+YO3VDDFWAq+6ukUMeKhCNfUGPgIO29d7X+393khAI/+pjyNkLGRAKppqxVa3MEMIOoSKppTyAnXqjBjrsXZJJ6WeedriLI5G7MuyQZCcre5DaL+OnfI+XwGwHU1JQgqOnvK0BFEk/qC7AMk2wv3iYy2EqDznTqJCjkNvZdgLHwe3SrYsVxjE7GIXcmg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aUyJ7GsggkPeXW18f6N+bU/fCP0CzDvLO7UrNkW/86o=; b=o+IPt/9LG5j/6DLGN4pBOQMUJj2MeOW2oqb9ZH7C0PulcM+F4xlJmWgZbSEkYfMIqa1lT3Gd94sNbrxJMgqtN/IOM32DGIcpGSS9xbbe2wKyXhyk3kA9KskB6LFcM7FmQ8vpgj0G+gl+ydPrNMLcmhhFxvXmOjQKELdYqRDAsmw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by IA0PR12MB7556.namprd12.prod.outlook.com (2603:10b6:208:43c::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7270.17; Fri, 9 Feb 2024 13:55:06 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::815a:45e6:cf5e:479f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::815a:45e6:cf5e:479f%4]) with mapi id 15.20.7292.009; Fri, 9 Feb 2024 13:55:05 +0000 Message-ID: Date: Fri, 9 Feb 2024 13:55:01 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] app/testpmd: add size parameter to raw_encap action Content-Language: en-US To: Dariusz Sosnowski , Gregory Etelson , "dev@dpdk.org" Cc: Maayan Kashani , Ori Kam , Aman Singh , Yuying Zhang References: <20231026073047.300888-1-getelson@nvidia.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0144.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:193::23) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|IA0PR12MB7556:EE_ X-MS-Office365-Filtering-Correlation-Id: 433e6979-0826-4889-7673-08dc2976b874 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: LoYEfeEKhamHQbNvrqaLp2ZPB9yhhW/3xnAAN/G3mdrrL+Tk5Stfjwku7IjmTaq8Ts6y6bpNt9dP2D4mYVlqoguPYakd4l02JFhbb/sxF+LOVkzT9GJ8+O6azbFcP6U75QwnZYZOURsfIvbsD+RwkZH17Z9Jid/nKUYPrCWZD91gsu5tJ3oT6/QX0BOH+wO8ykWKdeNBCmpF7bmd5tQy21FuLmD8QTdJI//H3Df5RMJuIOYBWkZhPMOsI9/sRoc/6IyMlNt6lcFZ6ib0GsEjylFcQUx8Q+N1zZn828H3TKDPYX3YP3K3vknyi2gfIGvBBZyH/p5qBFIMAbRGJw62AJfq8FF3gHFq6pC8r7Q+cIfXtQOB04R+6F5z8nYLO0HEnAv9OZLdg6QPYUSblbi7bzI8txSPGOCE5Q/ooKUHMHfA7EVP3BVfMD7q4xar1DlfuJpJIqPt44W8IGHH2pcESbfgc2YT5CZTqUyQ9w3/gcebAI1ZAaYILOKUUo76rene8CSIIjaXzIOU/B2NEhsJKOO0xi5ArGtEuYZ4/grXF0ORDon9Eqs8IKEAtcIpQoc3 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(39860400002)(376002)(136003)(346002)(366004)(230922051799003)(186009)(1800799012)(64100799003)(451199024)(26005)(31686004)(44832011)(86362001)(83380400001)(66556008)(5660300002)(110136005)(66946007)(2906002)(41300700001)(316002)(31696002)(2616005)(6506007)(478600001)(6666004)(38100700002)(53546011)(6486002)(54906003)(66476007)(6512007)(8936002)(8676002)(36756003)(4326008); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NHpmVm5iYkNtd0FjSjhtdFh0ZzBYbVdIc0pMVVNOYytDUlhqUTJUZ2ZsWVY4?= =?utf-8?B?djlyMlNMa2VYemlabVFObnJ4dlh6d1FCZWZvU1hKQklIV2NSMXByQk5ydHFT?= =?utf-8?B?SktuK1ZEd0FzaXJHTHBXTDhyMzY4eDRMMGUyOGN4TUZYMjl4VkkybmhWeHRH?= =?utf-8?B?aHhOVVpyODM5V1JTTzRvYjg3QnBMb2VOejVkbW9vbnZGa1BIY1N1bzdkOEQ1?= =?utf-8?B?ME9LK0pLTEZnL0FXNWdXRHdvRjBmQWd4ZVZIVUtlc01KdVgrN1JxMVBLUkRN?= =?utf-8?B?d3hDQVl1R3JsdHJ4SFcxc0syNTlmWkcvbVc4cmJxanpscjVyK2M3MGk4cHlt?= =?utf-8?B?VkEzUGpZemUwRk1oOXZ5ZjFhSXhydHBWYmY3dVFzZ1dWSU9xV3kxbDJCbi80?= =?utf-8?B?RFd4dmRjWU1SRG9McFI5KzdNcmR3MWN5ZSs0WGgyVG9IakdpdTVKRWl5TmRR?= =?utf-8?B?RXFOT0FZK0pLcDZTbDRvMDVBK0FkYStxQ0hReVNobmtwOU1wZUNzSmtvNFBP?= =?utf-8?B?cG5EZGwxUmVFZjRQYWIyaVpvQUxlVVVSYlNBYVpQNnJmY1cveVRzM2UrUGdx?= =?utf-8?B?THBiSktWZVo0US9xZnBtRnVhYytFK3ozeW1Nekp0VXVRdmZvTHB3N2Y3SE9u?= =?utf-8?B?SVVIbjBhS3lyRXhuQW5yTlZoaWN0NmEyQzNLZmdpRXhDMGd0Y2ltc284V3VK?= =?utf-8?B?VjFWcUN4TTNiUkFWblVRbkhPUkhzRTZ3dlFCcmdxTXNnQ21aY2UvUENHaWhL?= =?utf-8?B?aFFwZFZDWm83RG1HZitWKzMzNXpWTmxCVUFmZnhNa094QUJoeFBhdTF3NnRR?= =?utf-8?B?UjJvaUNUWlIyc3NRY3JlczcyMDBsVnZDQzJBa1NDczV0RW9KSnlLQkN5RUZq?= =?utf-8?B?MHpDaFpTakFMc3pvTUl0UjVER2d2aFQweVpYQUhRTHF6clltNG5ia3AxOENC?= =?utf-8?B?bGhXbFA2RjVBeDZQRXhsUHROeHJxMnByT2d4Q1RERUhNb3BOUm9GQThFREpJ?= =?utf-8?B?WjBxdWExTER6TDViTk5LOW9XUUxmQzVLaWlXRmRYMDFuc1RoNWQvamRqMWJ2?= =?utf-8?B?d2xOTmE0ZXlXWEg1ZElSU2w3bmZib0Q3SHVSZmt1eHhuN0xqaTNIaWxsRGhO?= =?utf-8?B?dWpXQU56bktHb0V1cXpjUTY4NWQxcUdyMlI2L21VaHRDZTQ1MXlndDFKZkIw?= =?utf-8?B?alZMeFBsSHl5N0UzbjczVmtwRkFTaE9Jcys4d2pQT0NjNk96U0QwZUVaM2Js?= =?utf-8?B?KzkxcDFueHhJWG85UmNQd0N2MHd0MDVIWFMwQzljbFhYVk4zWUlON0R5Qzly?= =?utf-8?B?NTJPWVhSYldjakc1L0dwQURUbFFPeTAyRy9LS2tyZ09wRlE2cFlpQXJ4WWJ4?= =?utf-8?B?dmIweE5aTERvbmVjQ0lISXpQUTl2TjQvU0lGdDFZTUpmalhEbXd4dTFadjJw?= =?utf-8?B?OUVkTDNpWVZPMnpHa0ZwV1MzOUFtR1E2QzB5SGczMFdveW5RbzBJZVhXanpO?= =?utf-8?B?WWpvUkdrR3ExRVpFZ1d3UGZ1anRGY05iZkxOSDFERE9qTDU5NHlYWFJQc3Fx?= =?utf-8?B?NVJodG53amJ5ZVVDS3RRQWtpY0pmNFpRaHBOZEVRTVpvY2twV0pTb3ExVHJ4?= =?utf-8?B?aU8ybnBXUjlFaWVBM0s3QTBZNDRkVllSSXlreENCV2NZVDlSVTFrUE1tU3FU?= =?utf-8?B?d25yN0ZGYXBRS1NoTW90bjdYSlFUWm5MdGZYVHZ6djNiYURnQVY2TzMzOXNt?= =?utf-8?B?cjdaZnpZYXhrR1I3cnU4Ukpjd1Bha3VkbVF4QVcwUC9aQ3BTOHcrVnlaYUE4?= =?utf-8?B?RUx5SE53STJPVGxUTGVXMHlVVU4zYTNWOXdPUUk3MzJXZlM5eWZqTEZadmQ2?= =?utf-8?B?dkxISGhoRXREeGV4UXJvejNqNVdzZzFpUGh0cnlpS0NGOHc4bUIwWWxxcDRS?= =?utf-8?B?NGV5b3YzeEhFV3puLzBzaTdOSzFDQVY1UXU0Z1BYakZBN1dXVWtTK2dGWXps?= =?utf-8?B?aHRONUp6ZUxYUGV1anVtQXVBKzNVQVg1QWtzMXF4RytIQ0N3dkwxeit3bHFW?= =?utf-8?B?WGp0cFVNbjBsdVdrcDFWSEhpR1ZUcnc3K1QvU0lVUDE4ZEd3WU1XTHBqc0Ny?= =?utf-8?Q?s99eaqn9Ch3X/8h7VuAi1brbk?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 433e6979-0826-4889-7673-08dc2976b874 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2024 13:55:05.9209 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: apuJZFln9ujc/t6EYj9MXxMBBHU0vjV36rwFP9EcUFfWaFlutC7bSr29RJWr4gwv X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB7556 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/9/2024 1:43 PM, Dariusz Sosnowski wrote: >> -----Original Message----- >> From: Dariusz Sosnowski >> Sent: Friday, February 9, 2024 12:04 >> To: Gregory Etelson ; dev@dpdk.org >> Cc: Gregory Etelson ; Maayan Kashani >> ; Ori Kam ; Aman Singh >> ; Yuying Zhang >> Subject: RE: [PATCH] app/testpmd: add size parameter to raw_encap action >> >> Hi Gregory, >> >>> -----Original Message----- >>> From: Gregory Etelson >>> Sent: Thursday, October 26, 2023 09:31 >>> To: dev@dpdk.org >>> Cc: Gregory Etelson ; Maayan Kashani >>> ; Ori Kam ; Aman Singh >>> ; Yuying Zhang >>> Subject: [PATCH] app/testpmd: add size parameter to raw_encap action >>> >>> Testpmd always provides RAW_ENCAP flow action configuration with encap >>> buffer and the buffer size. >>> That implementation does not allow to create non-masked raw_encap >>> action in the template API actions template. >>> >>> The patch adds the `size` parameter to testpmd `raw_encap` action >>> configuration. >>> Testpmd can create non-masked raw-encap action template and specify >>> encap buffer during flow creation. >>> >>> Example: >>> >>> # total data size is 50 >>> testpmd> set raw_encap 0 \ >>> eth src is 11:22:33:44:55:66 dst is aa:bb:cc:dd:01:aa / \ >>> ipv4 src is 31.31.31.31 dst is 63.63.63.1 / udp src is 1 / \ >>> vxlan vni is 1 / end_set >>> >>> testpmd> flow actions_template 0 create ingress \ >>> actions_template_id 50 \ >>> template raw_encap size 50 / jump / end \ >>> mask raw_encap size 50 / jump / end \ >>> >>> tstpmd> flow queue 0 create 0 template_table 0 \ >>> pattern_template 0 actions_template 0 postpone no \ >>> pattern ... end \ >>> actions raw_encap index 0 / jump group 1 / end >>> >>> The new `size` parameter is mutually exclusive with the existing >>> `index` parameter. >>> >>> Signed-off-by: Gregory Etelson >> >> The following sequence of commands results in "Bad arguments" error, but I >> think it should be accepted. >> >> testpmd> port stop all >> Stopping ports... >> Checking link statuses... >> Done >> testpmd> flow configure 0 queues_number 4 queues_size 64 >> Configure flows on port 0: number of queues 4 with 64 elements >> testpmd> port start all >> Port 0: B8:CE:F6:7B:D8:E0 >> Checking link statuses... >> Done >> testpmd> set raw_encap 0 eth src is 11:22:33:44:55:66 dst is >> testpmd> aa:bb:cc:dd:01:aa / ipv4 src is 31.31.31.31 dst is 63.63.63.1 / >> testpmd> udp src is 1 / vxlan vni is 1 / end_set flow actions_template 0 >> testpmd> create ingress actions_template_id 100 template raw_encap index >> testpmd> 0 / jump / end mask raw_encap index 0 / jump / end >> Bad arguments > > I bisected the tree, and it appears that this issue is not caused by this commit, but it's an existing problem in testpmd. > The root cause of "Bad arguments" is the fact that when parsing function for raw_encap index is called, > parse_int() is called with size == 0, but raw_encap index size is sizeof(size_t). > This causes a failure in validation introduced in commit 913b919906da ("app/testpmd: add size validation to token parsers"). > > The same issue appears for other cases where parse_int() is called with size == 0 e.g., parsing RSS queues in RSS flow action. > I'll provide a patch for testpmd which addresses that. > Hi Dariusz, I merged that patch recently, and it is still not merged to main repo, so we can drop it from next-net if required, instead of having a fix on top of it. That patch is because of a defect that overwrites some memory, and side impact you mentioned was not expected. Can you please sync with Gregory about it first?