DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Singh, Aman Deep" <aman.deep.singh@intel.com>
To: Jie Wang <jie1x.wang@intel.com>, <dev@dpdk.org>
Cc: <yuying.zhang@intel.com>, <xiaoyun.li@intel.com>,
	<stevex.yang@intel.com>,  Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v3] app/testpmd: fix DCB in VT configuration
Date: Mon, 15 Nov 2021 18:16:51 +0530	[thread overview]
Message-ID: <aaf2d4b2-d852-4784-85f2-15393294a04d@intel.com> (raw)
In-Reply-To: <20211115032958.2535862-1-jie1x.wang@intel.com>

[-- Attachment #1: Type: text/plain, Size: 1393 bytes --]


On 11/15/2021 8:59 AM, Jie Wang wrote:
> When set port DCB in VT mode enabled, it should remove RSS HASH
> offload before reconfiguring the device and queues.
>
> Because port multi-queue mode is changed from RSS to DCB in VT.
>
> Fixes: 2a977b891f99 ("app/testpmd: fix DCB configuration")
>
> Signed-off-by: Jie Wang<jie1x.wang@intel.com>

Acked-by: Aman Deep Singh <aman.deep.singh@intel.com>

> ---
> v3:
>   * update commit log.
>   * remove RSS HASh offload from DCB in VT.
> v2:
>   * update commit log.
>   * remove RSS HASH offload from port->rx_conf[i].offloads.
> ---
>   app/test-pmd/testpmd.c | 7 +++++++
>   1 file changed, 7 insertions(+)
>
> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
> index a66dfb297c..c18942279a 100644
> --- a/app/test-pmd/testpmd.c
> +++ b/app/test-pmd/testpmd.c
> @@ -3948,6 +3948,13 @@ init_port_dcb_config(portid_t pid,
>   	if (retval < 0)
>   		return retval;
>   	port_conf.rxmode.offloads |= RTE_ETH_RX_OFFLOAD_VLAN_FILTER;
> +	/* remove RSS HASH offload for DCB in vt mode */
> +	if (port_conf.rxmode.mq_mode == RTE_ETH_MQ_RX_VMDQ_DCB) {
> +		port_conf.rxmode.offloads &= ~RTE_ETH_RX_OFFLOAD_RSS_HASH;
> +		for (i = 0; i < nb_rxq; i++)
> +			rte_port->rx_conf[i].offloads &=
> +				~RTE_ETH_RX_OFFLOAD_RSS_HASH;
> +	}
>   
>   	/* re-configure the device . */
>   	retval = rte_eth_dev_configure(pid, nb_rxq, nb_rxq, &port_conf);

[-- Attachment #2: Type: text/html, Size: 2822 bytes --]

  reply	other threads:[~2021-11-15 12:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-09  8:02 [dpdk-dev] [PATCH] app/testpmd: fix DCB configuration Jie Wang
2021-11-10  9:08 ` [dpdk-dev] [PATCH v2] " Jie Wang
2021-11-12  9:08   ` Singh, Aman Deep
2021-11-15  3:29   ` [PATCH v3] app/testpmd: fix DCB in VT configuration Jie Wang
2021-11-15 12:46     ` Singh, Aman Deep [this message]
2021-11-15 16:23       ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aaf2d4b2-d852-4784-85f2-15393294a04d@intel.com \
    --to=aman.deep.singh@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=jie1x.wang@intel.com \
    --cc=stevex.yang@intel.com \
    --cc=xiaoyun.li@intel.com \
    --cc=yuying.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).