DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Hunt, David" <david.hunt@intel.com>
To: Anatoly Burakov <anatoly.burakov@intel.com>, dev@dpdk.org
Cc: reshma.pattan@intel.com
Subject: Re: [dpdk-dev] [PATCH 2/2] l3fwd-power: fix updating performance lcore parameters
Date: Mon, 13 Jul 2020 13:29:29 +0100
Message-ID: <ab04709a-cf12-9d9b-1cf2-e46f267d4149@intel.com> (raw)
In-Reply-To: <1ab5d183405f1e1525799310eb1d38a3c88b7009.1594642553.git.anatoly.burakov@intel.com>


On 13/7/2020 1:15 PM, Anatoly Burakov wrote:
> When perf-config option is specified, we are calling into the power
> library even though it may not necessarily be enabled. It is
> questionable whether perf-config option is even applicable to non-power
> library modes, but for now, fix it just by avoiding calling into the
> power library if it wasn't initialized, and assume that every lcore is
> high performance core.
>
> Fixes: e0194feb322c ("examples/l3fwd-power: add interrupt-only mode")
>
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> ---
>   examples/l3fwd-power/perf_core.c | 27 +++++++++++++++++++--------
>   1 file changed, 19 insertions(+), 8 deletions(-)

We saw a segfault with the following use-case: ./l3fwd-power -l 0,1 -- 
-p 0x1 -P --perf-config="(0,0,1,0)"

I've tested it and now runs without segfault.

Acked-by: David Hunt <david.hunt@intel.com>



  reply	other threads:[~2020-07-13 12:29 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-13 12:15 [dpdk-dev] [PATCH 1/2] power: fix power management env detection Anatoly Burakov
2020-07-13 12:15 ` [dpdk-dev] [PATCH 2/2] l3fwd-power: fix updating performance lcore parameters Anatoly Burakov
2020-07-13 12:29   ` Hunt, David [this message]
2020-07-13 12:26 ` [dpdk-dev] [PATCH 1/2] power: fix power management env detection Hunt, David
2020-07-13 14:54 ` [dpdk-dev] [PATCH v2 " Anatoly Burakov
2020-07-13 15:33   ` Bruce Richardson
2020-07-14  9:34     ` Burakov, Anatoly
2020-07-14 10:30   ` [dpdk-dev] [PATCH v3 " Anatoly Burakov
2020-07-15  4:18     ` Ma, LihongX
2020-07-17 12:50     ` Bruce Richardson
2020-07-21 23:57       ` Thomas Monjalon
2020-07-14 10:30   ` [dpdk-dev] [PATCH v3 2/2] l3fwd-power: fix updating performance lcore parameters Anatoly Burakov
2020-07-13 14:54 ` [dpdk-dev] [PATCH v2 " Anatoly Burakov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ab04709a-cf12-9d9b-1cf2-e46f267d4149@intel.com \
    --to=david.hunt@intel.com \
    --cc=anatoly.burakov@intel.com \
    --cc=dev@dpdk.org \
    --cc=reshma.pattan@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git