From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: David Marchand <david.marchand@redhat.com>, dev@dpdk.org
Cc: thomas@monjalon.net, bruce.richardson@intel.com,
Chenbo Xia <chenbo.xia@intel.com>, Jin Yu <jin.yu@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2 08/11] examples/vhost_blk: fix build with pkg-config
Date: Fri, 13 Nov 2020 14:00:45 +0100 [thread overview]
Message-ID: <ab0d4beb-8d9c-e116-1193-a7c1933a35e5@redhat.com> (raw)
In-Reply-To: <20201113122430.25354-9-david.marchand@redhat.com>
On 11/13/20 1:24 PM, David Marchand wrote:
> vhost_blk.c: In function ‘ctrlr_worker’:
> vhost_blk.c:543:2: warning: implicit declaration of function ‘CPU_ZERO’
> [-Wimplicit-function-declaration]
> 543 | CPU_ZERO(&cpuset);
> | ^~~~~~~~
> vhost_blk.c:544:2: warning: implicit declaration of function ‘CPU_SET’
> [-Wimplicit-function-declaration]
> 544 | CPU_SET(0, &cpuset);
> | ^~~~~~~
> vhost_blk.c:545:2: warning: implicit declaration of function
> ‘pthread_setaffinity_np’ [-Wimplicit-function-declaration]
> 545 | pthread_setaffinity_np(thread, sizeof(cpu_set_t), &cpuset);
> | ^~~~~~~~~~~~~~~~~~~~~~
> /usr/bin/ld: /tmp/cczpiMWH.o: in function `ctrlr_worker':
> vhost_blk.c:(.text+0x1076): undefined reference to `CPU_ZERO'
> /usr/bin/ld: vhost_blk.c:(.text+0x1082): undefined reference to
> `CPU_SET'
> collect2: error: ld returned 1 exit status
> gmake: *** [Makefile:34: build/vhost-blk-shared] Error 1
>
> Explicitly pass _GNU_SOURCE and include missing headers (rather than
> rely on automagic inclusion from other system headers).
>
> Fixes: c19beb3f38cd ("examples/vhost_blk: introduce vhost storage sample")
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> examples/vhost_blk/vhost_blk.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/examples/vhost_blk/vhost_blk.c b/examples/vhost_blk/vhost_blk.c
> index 8f5d61a589..bb293d492f 100644
> --- a/examples/vhost_blk/vhost_blk.c
> +++ b/examples/vhost_blk/vhost_blk.c
> @@ -2,6 +2,12 @@
> * Copyright(c) 2010-2019 Intel Corporation
> */
>
> +#ifndef _GNU_SOURCE
> +#define _GNU_SOURCE
> +#endif
> +#include <pthread.h>
> +#include <sched.h>
> +
> #include <stdint.h>
> #include <unistd.h>
> #include <stdbool.h>
>
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
next prev parent reply other threads:[~2020-11-13 13:00 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-10 15:12 [dpdk-dev] [PATCH 00/10] Examples compilation fixes David Marchand
2020-11-10 15:12 ` [dpdk-dev] [PATCH 01/10] examples/fips_validation: fix build with pkg-config David Marchand
2020-11-10 15:12 ` [dpdk-dev] [PATCH 02/10] examples/ipsec-gw: " David Marchand
2020-11-10 15:12 ` [dpdk-dev] [PATCH 03/10] examples/kni: " David Marchand
2020-11-10 15:12 ` [dpdk-dev] [PATCH 04/10] examples/l2fwd-crypto: " David Marchand
2020-11-10 15:12 ` [dpdk-dev] [PATCH 05/10] examples/l3fwd-graph: fix static build David Marchand
2020-11-10 15:12 ` [dpdk-dev] [PATCH 06/10] examples/ntb: fix clean target David Marchand
2020-11-12 1:30 ` Li, Xiaoyun
2020-11-10 15:12 ` [dpdk-dev] [PATCH 07/10] examples/vhost_blk: fix build with pkg-config David Marchand
2020-11-10 15:12 ` [dpdk-dev] [PATCH 08/10] examples/rxtx_callbacks: " David Marchand
2020-11-10 15:12 ` [dpdk-dev] [PATCH 09/10] devtools: compile all examples " David Marchand
2020-11-10 16:02 ` Bruce Richardson
2020-11-10 17:18 ` Bruce Richardson
2020-11-10 17:27 ` David Marchand
2020-11-10 15:12 ` [dpdk-dev] [PATCH 10/10] examples: restore trace point David Marchand
2020-11-10 16:04 ` [dpdk-dev] [PATCH 00/10] Examples compilation fixes Bruce Richardson
2020-11-13 12:24 ` [dpdk-dev] [PATCH v2 00/11] " David Marchand
2020-11-13 12:24 ` [dpdk-dev] [PATCH v2 01/11] examples/fips_validation: fix build with pkg-config David Marchand
2020-11-13 12:24 ` [dpdk-dev] [PATCH v2 02/11] examples/ipsec-gw: " David Marchand
2020-11-16 4:16 ` [dpdk-dev] [EXT] " Anoob Joseph
2020-11-13 12:24 ` [dpdk-dev] [PATCH v2 03/11] examples/kni: " David Marchand
2020-11-13 12:24 ` [dpdk-dev] [PATCH v2 04/11] examples/l2fwd-crypto: " David Marchand
2020-11-13 13:53 ` Bruce Richardson
2020-11-13 14:15 ` David Marchand
2020-11-13 15:41 ` David Marchand
2020-11-13 16:08 ` Bruce Richardson
2020-11-13 12:24 ` [dpdk-dev] [PATCH v2 05/11] examples/l3fwd-graph: fix static build David Marchand
2020-11-13 12:24 ` [dpdk-dev] [PATCH v2 06/11] examples/ntb: fix clean target David Marchand
2020-11-13 12:24 ` [dpdk-dev] [PATCH v2 07/11] examples/performance-thread: fix build with pkg-config David Marchand
2020-11-13 12:24 ` [dpdk-dev] [PATCH v2 08/11] examples/vhost_blk: " David Marchand
2020-11-13 13:00 ` Maxime Coquelin [this message]
2020-11-13 12:24 ` [dpdk-dev] [PATCH v2 09/11] examples/rxtx_callbacks: " David Marchand
2020-11-13 12:24 ` [dpdk-dev] [PATCH v2 10/11] examples: restore trace point David Marchand
2020-11-13 12:24 ` [dpdk-dev] [PATCH v2 11/11] devtools: compile all buildable examples with pkg-config David Marchand
2020-11-13 12:37 ` David Marchand
2020-11-13 14:06 ` Bruce Richardson
2020-11-13 14:14 ` David Marchand
2020-11-13 14:24 ` Bruce Richardson
2020-11-14 9:05 ` [dpdk-dev] [PATCH v3 00/11] Examples compilation fixes David Marchand
2020-11-14 9:05 ` [dpdk-dev] [PATCH v3 01/11] examples/fips_validation: fix build with pkg-config David Marchand
2020-11-14 9:05 ` [dpdk-dev] [PATCH v3 02/11] examples/ipsec-gw: " David Marchand
2020-11-14 9:05 ` [dpdk-dev] [PATCH v3 03/11] examples/kni: " David Marchand
2020-11-14 9:05 ` [dpdk-dev] [PATCH v3 04/11] examples/l2fwd-crypto: " David Marchand
2020-11-14 9:05 ` [dpdk-dev] [PATCH v3 05/11] examples/l3fwd-graph: fix static build David Marchand
2020-11-14 9:05 ` [dpdk-dev] [PATCH v3 06/11] examples/l3fwd-graph: fix pkg-config usage David Marchand
2020-11-14 9:05 ` [dpdk-dev] [PATCH v3 07/11] examples/ntb: fix clean target David Marchand
2020-11-14 9:05 ` [dpdk-dev] [PATCH v3 08/11] examples/performance-thread: fix build with pkg-config David Marchand
2020-11-14 9:05 ` [dpdk-dev] [PATCH v3 09/11] examples/vhost_blk: " David Marchand
2020-11-14 9:05 ` [dpdk-dev] [PATCH v3 10/11] examples/rxtx_callbacks: " David Marchand
2020-11-14 9:05 ` [dpdk-dev] [PATCH v3 11/11] examples: restore trace point David Marchand
2020-11-15 14:37 ` [dpdk-dev] [PATCH v3 00/11] Examples compilation fixes Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab0d4beb-8d9c-e116-1193-a7c1933a35e5@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=chenbo.xia@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=jin.yu@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).