From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Yong Wang <yongwang@vmware.com>,
Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>,
Dmitry Malloy <dmitrym@microsoft.com>,
Pallavi Kadam <pallavi.kadam@intel.com>
Subject: Re: [dpdk-dev] [PATCH] net/vmxnet3: build on Windows
Date: Thu, 25 Mar 2021 16:04:40 +0000 [thread overview]
Message-ID: <ab0e708b-9c18-9533-05fe-cf7f10c378d4@intel.com> (raw)
In-Reply-To: <64F14EF8-F42E-4A3A-B4AE-22A9FA4A21A6@vmware.com>
On 3/24/2021 6:32 PM, Yong Wang wrote:
>
> -----Original Message-----
> From: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
> Date: Wednesday, March 24, 2021 at 10:50 AM
> To: Yong Wang <yongwang@vmware.com>
> Cc: Ferruh Yigit <ferruh.yigit@intel.com>, "dev@dpdk.org" <dev@dpdk.org>, Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>, Dmitry Malloy <dmitrym@microsoft.com>, Pallavi Kadam <pallavi.kadam@intel.com>
> Subject: Re: [dpdk-dev] [PATCH] net/vmxnet3: build on Windows
>
> 2021-03-23 17:13 (UTC+0000), Yong Wang:
> > -----Original Message-----
> > From: Ferruh Yigit <ferruh.yigit@intel.com>
> > Date: Tuesday, March 23, 2021 at 9:11 AM
> > To: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>, "dev@dpdk.org" <dev@dpdk.org>, Yong Wang <yongwang@vmware.com>
> > Cc: Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>, Dmitry Malloy <dmitrym@microsoft.com>, Pallavi Kadam <pallavi.kadam@intel.com>
> > Subject: Re: [dpdk-dev] [PATCH] net/vmxnet3: build on Windows
> >
> > On 2/21/2021 12:55 AM, Dmitry Kozlyuk wrote:
> > > Remove OS restriction and update release notes.
> > >
> > > Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
> >
> > Build looks good, but I wonder if anyone tested the driver on Windows.
> >
> > Yong,
> >
> > Do you have any plan to test the driver on Windows, should we wait your ack?
> >
> > Ferruh,
> >
> > Unfortunately I don't have any Windows setup to test this change. Do you know what kind of tests have been done for this change?
>
> For the record, I tested the following setup with Windows Server 2019 in QEMU
> (-device vmxnet3) before submitting the patch:
>
> [ping ] [ ] [ ping]
> [OS ] [ dpdk-skeleton ] [ OS]
> [virtio---]--sockets--[---vmxnet3 vmxnet3---]--sockets--[---virtio]
> [Debian VM] [ Windows VM ] [Debian VM]
>
> Debian VMs successfully ping'd each other with Windows forwarding.
>
> Thanks Dmitri for the testing results. It will be good if you can try some basic tcp/udp traffic as well.
>
> Acked-by: Yong Wang <yongwang@vmware.com>
>
Applied to dpdk-next-net/main, thanks.
Added the above test detail to commit log for record.
prev parent reply other threads:[~2021-03-25 16:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-21 0:55 Dmitry Kozlyuk
2021-03-23 16:11 ` Ferruh Yigit
2021-03-23 17:13 ` Yong Wang
2021-03-24 17:50 ` Dmitry Kozlyuk
2021-03-24 18:32 ` Yong Wang
2021-03-25 16:04 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab0e708b-9c18-9533-05fe-cf7f10c378d4@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=dmitrym@microsoft.com \
--cc=navasile@linux.microsoft.com \
--cc=pallavi.kadam@intel.com \
--cc=yongwang@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).