From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 50BD0A0A02; Thu, 25 Mar 2021 17:05:04 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E02ED140E52; Thu, 25 Mar 2021 17:05:03 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 610DF140E4D for ; Thu, 25 Mar 2021 17:05:00 +0100 (CET) IronPort-SDR: gOCCMN2XQkFs1P8tw7cwdmmRTok3bBVzGm65ofR3XXU1C8rqB3gORPBgSCU+nywCkAbQ7ImQKi +FxwkwmNfJ5g== X-IronPort-AV: E=McAfee;i="6000,8403,9934"; a="254958462" X-IronPort-AV: E=Sophos;i="5.81,277,1610438400"; d="scan'208";a="254958462" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Mar 2021 09:04:47 -0700 IronPort-SDR: TM0m8NFdj75LvdRS0RCMwiGHGIe2NeJhA/QZCMJObIxohmkjAfPyF3lJNkN+o3VBApt8hTNjhs f0RcPDVtfddw== X-IronPort-AV: E=Sophos;i="5.81,277,1610438400"; d="scan'208";a="391795970" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.252.15.136]) ([10.252.15.136]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Mar 2021 09:04:43 -0700 To: Yong Wang , Dmitry Kozlyuk Cc: "dev@dpdk.org" , Narcisa Ana Maria Vasile , Dmitry Malloy , Pallavi Kadam References: <20210221005552.11739-1-dmitry.kozliuk@gmail.com> <20210324205015.6d30376e@sovereign> <64F14EF8-F42E-4A3A-B4AE-22A9FA4A21A6@vmware.com> From: Ferruh Yigit X-User: ferruhy Message-ID: Date: Thu, 25 Mar 2021 16:04:40 +0000 MIME-Version: 1.0 In-Reply-To: <64F14EF8-F42E-4A3A-B4AE-22A9FA4A21A6@vmware.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] net/vmxnet3: build on Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 3/24/2021 6:32 PM, Yong Wang wrote: > > -----Original Message----- > From: Dmitry Kozlyuk > Date: Wednesday, March 24, 2021 at 10:50 AM > To: Yong Wang > Cc: Ferruh Yigit , "dev@dpdk.org" , Narcisa Ana Maria Vasile , Dmitry Malloy , Pallavi Kadam > Subject: Re: [dpdk-dev] [PATCH] net/vmxnet3: build on Windows > > 2021-03-23 17:13 (UTC+0000), Yong Wang: > > -----Original Message----- > > From: Ferruh Yigit > > Date: Tuesday, March 23, 2021 at 9:11 AM > > To: Dmitry Kozlyuk , "dev@dpdk.org" , Yong Wang > > Cc: Narcisa Ana Maria Vasile , Dmitry Malloy , Pallavi Kadam > > Subject: Re: [dpdk-dev] [PATCH] net/vmxnet3: build on Windows > > > > On 2/21/2021 12:55 AM, Dmitry Kozlyuk wrote: > > > Remove OS restriction and update release notes. > > > > > > Signed-off-by: Dmitry Kozlyuk > > > > Build looks good, but I wonder if anyone tested the driver on Windows. > > > > Yong, > > > > Do you have any plan to test the driver on Windows, should we wait your ack? > > > > Ferruh, > > > > Unfortunately I don't have any Windows setup to test this change. Do you know what kind of tests have been done for this change? > > For the record, I tested the following setup with Windows Server 2019 in QEMU > (-device vmxnet3) before submitting the patch: > > [ping ] [ ] [ ping] > [OS ] [ dpdk-skeleton ] [ OS] > [virtio---]--sockets--[---vmxnet3 vmxnet3---]--sockets--[---virtio] > [Debian VM] [ Windows VM ] [Debian VM] > > Debian VMs successfully ping'd each other with Windows forwarding. > > Thanks Dmitri for the testing results. It will be good if you can try some basic tcp/udp traffic as well. > > Acked-by: Yong Wang > Applied to dpdk-next-net/main, thanks. Added the above test detail to commit log for record.